)]}'
{"tempest/api/volume/test_qos.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"97b68f5cff9ec7e748fac5e6f7a2f8e7612c3bd5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        keys \u003d [\u0027iops_bytes\u0027]"},{"line_number":128,"context_line":"        self.volume_qos_client.unset_qos_key(self.created_qos[\u0027id\u0027], keys)"},{"line_number":129,"context_line":"        operation \u003d \u0027qos-key-unset\u0027"},{"line_number":130,"context_line":"        waiters.wait_for_qos_operations(self.volume_qos_client,"},{"line_number":131,"context_line":"                                        self.created_qos[\u0027id\u0027], operation,"},{"line_number":132,"context_line":"                                        keys)"},{"line_number":133,"context_line":"        body \u003d self.volume_qos_client.show_qos("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_13b3849b","line":130,"updated":"2015-12-12 13:04:07.000000000","message":"Jordan, I like this change, but It looks like this one is not related to the purpose of this patch. I would prefer to have these changes in a separate patch, probably, depending on this one.","commit_id":"e37d0ab5399fe7a93096a159ef938dbe3f6cbc08"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f1f382ca7bde24d6c9d90500a5eff4d598e5d99f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        keys \u003d [\u0027iops_bytes\u0027]"},{"line_number":128,"context_line":"        self.volume_qos_client.unset_qos_key(self.created_qos[\u0027id\u0027], keys)"},{"line_number":129,"context_line":"        operation \u003d \u0027qos-key-unset\u0027"},{"line_number":130,"context_line":"        waiters.wait_for_qos_operations(self.volume_qos_client,"},{"line_number":131,"context_line":"                                        self.created_qos[\u0027id\u0027], operation,"},{"line_number":132,"context_line":"                                        keys)"},{"line_number":133,"context_line":"        body \u003d self.volume_qos_client.show_qos("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_f6f7c6d0","line":130,"in_reply_to":"7a740942_13b3849b","updated":"2015-12-12 14:08:00.000000000","message":"Yeah, I don\"t know what happened, I removed this change in patchset 2 and now it\u0027s back... Will remove it again.","commit_id":"e37d0ab5399fe7a93096a159ef938dbe3f6cbc08"}],"tempest/services/volume/base/base_qos_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"def35e8bedec492ca26a978fec628f153df68f36","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\"Unset the specified keys of QoS specification."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":121,"context_line":"                              api-ref-blockstorage-v2.html#setQoSKey"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        put_body \u003d json.dumps(kwargs)"},{"line_number":124,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_064bc05a","line":121,"updated":"2015-12-10 06:07:02.000000000","message":"this link is right for unset key, please add TODO here like this- https://review.openstack.org/#/c/252152/5/tempest_lib/services/compute/security_group_default_rules_client.py","commit_id":"01df1dd0e65cdf520d7589458d99bf531d15e6a3"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"c5914a46aad505fbf390bde8b3917f2b43e4bf45","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\"Unset the specified keys of QoS specification."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":121,"context_line":"                              api-ref-blockstorage-v2.html#setQoSKey"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        put_body \u003d json.dumps(kwargs)"},{"line_number":124,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b17d3de9","line":121,"in_reply_to":"7a740942_064bc05a","updated":"2015-12-10 10:35:15.000000000","message":"same link is given for setting and unsetting the Qos with the title \u0027Set or unset keys in QoS specification\u0027 and Id is given \u0027setQoSKey\u0027 i think that need to be changed to something like setunsetQoSKey.. Yes till then we can go with TODO.","commit_id":"01df1dd0e65cdf520d7589458d99bf531d15e6a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c18aaec5627ecdf0851258166ab837b6d75ce252","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\"Unset the specified keys of QoS specification."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":121,"context_line":"                              api-ref-blockstorage-v2.html#setQoSKey"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        put_body \u003d json.dumps(kwargs)"},{"line_number":124,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_55be3e00","line":121,"in_reply_to":"7a740942_b17d3de9","updated":"2015-12-10 12:25:45.000000000","message":"right -\u003e not right","commit_id":"01df1dd0e65cdf520d7589458d99bf531d15e6a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"def35e8bedec492ca26a978fec628f153df68f36","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":121,"context_line":"                              api-ref-blockstorage-v2.html#setQoSKey"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        put_body \u003d json.dumps(kwargs)"},{"line_number":124,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"},{"line_number":125,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":126,"context_line":"        return service_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_8657b0c9","line":123,"updated":"2015-12-10 06:07:02.000000000","message":"I think {\u0027keys\u0027: kwargs} will be consistent with other methods","commit_id":"01df1dd0e65cdf520d7589458d99bf531d15e6a3"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"c5914a46aad505fbf390bde8b3917f2b43e4bf45","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":121,"context_line":"                              api-ref-blockstorage-v2.html#setQoSKey"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        put_body \u003d json.dumps(kwargs)"},{"line_number":124,"context_line":"        resp, body \u003d self.put(\u0027qos-specs/%s/delete_keys\u0027 % qos_id, put_body)"},{"line_number":125,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":126,"context_line":"        return service_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_76ba6b70","line":123,"in_reply_to":"7a740942_8657b0c9","updated":"2015-12-10 10:35:15.000000000","message":"Ghanshyan I think this patch has already passed the dictionary(**kwargs) that have \u0027keys\u0027 as key, so no need to again create a dictionary that have \u0027keys\u0027 as key...","commit_id":"01df1dd0e65cdf520d7589458d99bf531d15e6a3"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"389f61d6b29ff45556857f10a69287ff05360847","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def unset_qos_key(self, qos_id, keys):"},{"line_number":118,"context_line":"        \"\"\"Unset the specified keys of QoS specification."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param list keys: keys to delete from the QoS specification."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        TODO(jordanP): Add a link once LP #1524877 is fixed."},{"line_number":123,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4bbce8ba","line":120,"updated":"2015-12-13 11:47:32.000000000","message":"\u0027keys\u0027, not \u0027list keys\u0027\n\n    :param keys: keys to delete from the QoS specification.","commit_id":"0c560dac4101d719b01f19481f8534ade3302a2e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"17a8580cfe7ee1e6d5a1e8ed991028daf6598a7a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def unset_qos_key(self, qos_id, keys):"},{"line_number":118,"context_line":"        \"\"\"Unset the specified keys of QoS specification."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param list keys: keys to delete from the QoS specification."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        TODO(jordanP): Add a link once LP #1524877 is fixed."},{"line_number":123,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_623d332a","line":120,"in_reply_to":"7a740942_4bbce8ba","updated":"2015-12-14 09:06:08.000000000","message":"list is the type here. I know list is not a type in Python :) Maybe I should go with `iterable` ?","commit_id":"0c560dac4101d719b01f19481f8534ade3302a2e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"f7831aec64128ead503f1d702a8b53413958b21f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def unset_qos_key(self, qos_id, keys):"},{"line_number":118,"context_line":"        \"\"\"Unset the specified keys of QoS specification."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param list keys: keys to delete from the QoS specification."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        TODO(jordanP): Add a link once LP #1524877 is fixed."},{"line_number":123,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_c2f0a769","line":120,"in_reply_to":"7a740942_623d332a","updated":"2015-12-14 09:10:47.000000000","message":"Yep, I got it when I was reviewing :) In fact, it should be like this:\n\n    :param keys: keys to delete from the QoS specification.\n    :type keys: list","commit_id":"0c560dac4101d719b01f19481f8534ade3302a2e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1b63357784f0bb953a40bb32b4f977df27030c54","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def unset_qos_key(self, qos_id, keys):"},{"line_number":118,"context_line":"        \"\"\"Unset the specified keys of QoS specification."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param list keys: keys to delete from the QoS specification."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        TODO(jordanP): Add a link once LP #1524877 is fixed."},{"line_number":123,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_1bd33d3a","line":120,"in_reply_to":"7a740942_c2f0a769","updated":"2015-12-14 22:38:28.000000000","message":"nice point. \":type keys: list\" is valid format.\n\nor it is enough without writing it instead like the other parts.","commit_id":"0c560dac4101d719b01f19481f8534ade3302a2e"}]}