)]}'
{"tempest/api/identity/admin/v2/test_users.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a284cfc7852cd910786a37ff516abc9249ac7dc6","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        # Updating the user with new password"},{"line_number":201,"context_line":"        new_pass \u003d data_utils.rand_name(\u0027pass\u0027)"},{"line_number":202,"context_line":"        update_user \u003d self.client.update_user_password("},{"line_number":203,"context_line":"            self.data.user[\u0027id\u0027], password\u003dnew_pass)[\u0027user\u0027]"},{"line_number":204,"context_line":"        self.assertEqual(update_user[\u0027id\u0027], self.data.user[\u0027id\u0027])"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # Validate the updated password"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_7fb85411","line":203,"range":{"start_line":203,"start_character":51,"end_line":203,"end_character":54},"updated":"2015-12-22 01:24:17.000000000","message":"TBN (to be noted)- now \u0027id\u0027 is not passed in kwargs which is fine.\nKeystone ignore update of \u0027id\u0027 if it is in updated arg. Which is fine in this tests. Any tests want to tests that behavior they can pass id (with kwargs) and check id is not updated.","commit_id":"9d9395ea950d24ccb5192ec522e57dc886cc46d9"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"05e422a23e891efc8a97f4b39248ce6fa1c31393","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        # Updating the user with new password"},{"line_number":201,"context_line":"        new_pass \u003d data_utils.rand_name(\u0027pass\u0027)"},{"line_number":202,"context_line":"        update_user \u003d self.client.update_user_password("},{"line_number":203,"context_line":"            self.data.user[\u0027id\u0027], password\u003dnew_pass)[\u0027user\u0027]"},{"line_number":204,"context_line":"        self.assertEqual(update_user[\u0027id\u0027], self.data.user[\u0027id\u0027])"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # Validate the updated password"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_d22ca6ad","line":203,"range":{"start_line":203,"start_character":51,"end_line":203,"end_character":54},"in_reply_to":"3a7e1126_7fb85411","updated":"2015-12-23 08:35:02.000000000","message":"Yes in that case user need to specify the ID. Thanks for the Point :-)","commit_id":"9d9395ea950d24ccb5192ec522e57dc886cc46d9"}],"tempest/services/identity/v2/json/identity_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e392c9fc95585c40979b905c34e94484bd25ec30","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        \"\"\"Enables or disables a user."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":188,"context_line":"                              api-ref-identity-v2-ext.html#enableUser"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":191,"context_line":"        resp, body \u003d self.put(\u0027users/%s/enabled\u0027 % user_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_bab51fd1","line":188,"updated":"2015-12-10 08:00:10.000000000","message":"this link shows OS-KSADM extension which jas url like below but in this method we use without that externsion which is also supported by Keystone.\n\n/v2.0/users/​{userId}​/OS-KSADM/enabled\n\nI did not find doc for \u0027users/%s/enabled\u0027. Using OS_KSADM doc might be confusing. \n\nHow about adding TODO here or this link is ok?","commit_id":"8418ccce02d93edbc7d1062ce55a5cf6303c90dd"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da5c27aef05d133865304a6d487aa2d46bc8c1db","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        \"\"\"Enables or disables a user."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":188,"context_line":"                              api-ref-identity-v2-ext.html#enableUser"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":191,"context_line":"        resp, body \u003d self.put(\u0027users/%s/enabled\u0027 % user_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_aeb0988c","line":188,"in_reply_to":"7a740942_55dacc79","updated":"2015-12-15 06:29:53.000000000","message":"I think it\u0027s ok to have the link as it is, but it would be good to add a note about this, to explain why this URL can be used.","commit_id":"8418ccce02d93edbc7d1062ce55a5cf6303c90dd"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"2962d7b50bf52881ec2137d7af862a626a8ab189","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        \"\"\"Enables or disables a user."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":188,"context_line":"                              api-ref-identity-v2-ext.html#enableUser"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":191,"context_line":"        resp, body \u003d self.put(\u0027users/%s/enabled\u0027 % user_id, put_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_55dacc79","line":188,"in_reply_to":"7a740942_bab51fd1","updated":"2015-12-10 08:18:40.000000000","message":"HI Ghanshyam!! thanks for your review\ncan you please have a look in the patch where Ken\u0027ichi Ohmichi have suggested why we should use this link.\n\nhttps://review.openstack.org/#/c/254734/1/tempest/services/identity/v2/json/identity_client.py","commit_id":"8418ccce02d93edbc7d1062ce55a5cf6303c90dd"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1c506958adc4d3ed644fb60941ac15d491d002b9","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        Available params: see http://developer.openstack.org/"},{"line_number":188,"context_line":"                              api-ref-identity-v2-ext.html#enableUser"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        # (NOTE): The URL(users/\u003cid\u003e/enabled) is different from the api-site"},{"line_number":191,"context_line":"        # one(/users/\u003cid\u003e/OS-KSADM/enabled) , but they are the same API"},{"line_number":192,"context_line":"        # because of the fact that in keystone/contrib/admin_crud/core.py"},{"line_number":193,"context_line":"        # both api use same action\u003d\u0027set_user_enabled\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_ad748467","line":190,"range":{"start_line":190,"start_character":11,"end_line":190,"end_character":15},"updated":"2015-12-21 07:46:53.000000000","message":"We don\u0027t need to put \"(\" and \")\" on NOTE.","commit_id":"4c86474c3b4760cc15579edd5e6713148adfc14d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a284cfc7852cd910786a37ff516abc9249ac7dc6","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        # NOTE: The URL (users/\u003cid\u003e/enabled) is different from the api-site"},{"line_number":191,"context_line":"        # one (users/\u003cid\u003e/OS-KSADM/enabled) , but they are the same API"},{"line_number":192,"context_line":"        # because of the fact that in keystone/contrib/admin_crud/core.py"},{"line_number":193,"context_line":"        # both api use same action\u003d\u0027set_user_enabled\u0027"},{"line_number":194,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":195,"context_line":"        resp, body \u003d self.put(\u0027users/%s/enabled\u0027 % user_id, put_body)"},{"line_number":196,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_9f42e0ac","line":193,"range":{"start_line":193,"start_character":52,"end_line":193,"end_character":53},"updated":"2015-12-22 01:24:17.000000000","message":"Thanks this is nice. Currently keystone supports both URI. I think we should have consistency in this client to send request to KSADM extension or original URI(currently it is mix) or have input from user to select appropriate one.\nBut that\u0027s something we can do later.","commit_id":"9d9395ea950d24ccb5192ec522e57dc886cc46d9"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"05e422a23e891efc8a97f4b39248ce6fa1c31393","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        # NOTE: The URL (users/\u003cid\u003e/enabled) is different from the api-site"},{"line_number":191,"context_line":"        # one (users/\u003cid\u003e/OS-KSADM/enabled) , but they are the same API"},{"line_number":192,"context_line":"        # because of the fact that in keystone/contrib/admin_crud/core.py"},{"line_number":193,"context_line":"        # both api use same action\u003d\u0027set_user_enabled\u0027"},{"line_number":194,"context_line":"        put_body \u003d json.dumps({\u0027user\u0027: kwargs})"},{"line_number":195,"context_line":"        resp, body \u003d self.put(\u0027users/%s/enabled\u0027 % user_id, put_body)"},{"line_number":196,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_b2aa3a18","line":193,"range":{"start_line":193,"start_character":52,"end_line":193,"end_character":53},"in_reply_to":"3a7e1126_9f42e0ac","updated":"2015-12-23 08:35:02.000000000","message":"True that :-)","commit_id":"9d9395ea950d24ccb5192ec522e57dc886cc46d9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a284cfc7852cd910786a37ff516abc9249ac7dc6","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def create_user_ec2_credentials(self, user_id, tenant_id):"},{"line_number":319,"context_line":"        post_body \u003d json.dumps({\u0027tenant_id\u0027: tenant_id})"},{"line_number":320,"context_line":"        resp, body \u003d self.post(\u0027/users/%s/credentials/OS-EC2\u0027 % user_id,"},{"line_number":321,"context_line":"                               post_body)"},{"line_number":322,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_1f9ef0b8","line":319,"range":{"start_line":319,"start_character":54,"end_line":319,"end_character":56},"updated":"2015-12-22 01:24:17.000000000","message":"I think original one was good, why we are changing it to not using kwargs?","commit_id":"9d9395ea950d24ccb5192ec522e57dc886cc46d9"},{"author":{"_account_id":17753,"name":"Piyush Pathak","email":"cyperxprt@gmail.com","username":"piyush110786"},"change_message_id":"05e422a23e891efc8a97f4b39248ce6fa1c31393","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def create_user_ec2_credentials(self, user_id, tenant_id):"},{"line_number":319,"context_line":"        post_body \u003d json.dumps({\u0027tenant_id\u0027: tenant_id})"},{"line_number":320,"context_line":"        resp, body \u003d self.post(\u0027/users/%s/credentials/OS-EC2\u0027 % user_id,"},{"line_number":321,"context_line":"                               post_body)"},{"line_number":322,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_f289a2cb","line":319,"range":{"start_line":319,"start_character":54,"end_line":319,"end_character":56},"in_reply_to":"3a7e1126_1f9ef0b8","updated":"2015-12-23 08:35:02.000000000","message":"Ahh!! that was by mistake, I will rectify it and update the patch..","commit_id":"9d9395ea950d24ccb5192ec522e57dc886cc46d9"}]}