)]}'
{"tempest/tests/test_image_metadata.py":[{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"7ea233a9a8fccb0d9d7549017d19523c8f3ce172","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                self.fail(\u0027An update shouldnt happen for nonexistant image\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @attr(type\u003d\u0027negative\u0027)"},{"line_number":120,"context_line":"    def test_get_nonexistant_image_metadata_item(self):"},{"line_number":121,"context_line":"        \"\"\"Negative test: Get on nonexistant image should not happen\"\"\""},{"line_number":122,"context_line":"        try:"},{"line_number":123,"context_line":"                resp, metadata \u003d self.client.get_image_metadata_item(999,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F68o%3D","line":120,"updated":"2011-12-22 19:59:07.000000000","message":"Could we alter the name of this test slightly? This name makes it sound like you are making a GET on a metadata item that does not exist for a valid image, which is a separate negative test case that we will also have to cover. I would suggest something closer to \"get_metadata_item_from_nonexisting_image\". This comment applies for all tests after this point.","commit_id":"4f5ad38056fd96dd1a894b8ef04f9786d8222671"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"770e91c0a378f994f7963945a7e9fb3053f05e55","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            pass"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            self.fail(\u0027List on nonexistant \\"},{"line_number":106,"context_line":"                       image metadata should not happen\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @attr(type\u003d\u0027negative\u0027)"},{"line_number":109,"context_line":"    def test_update_nonexistant_image_metadata(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAD3%2F%2F%2BJc%3D","line":106,"updated":"2012-01-13 22:58:01.000000000","message":"Please don\u0027t use \\ here. Instead, do the following:\n\n self.fail(\u0027List on nonexistant image metadata should \u0027\n           \u0027not happen\u0027)\n\nPlease also make the same changes to the code below that uses \\","commit_id":"528e00afc2ecd2545127d66678dc19ef81049eaf"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"1865b415a3b1c05e480acb3198629c1a957cc241","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            resp, body \u003d self.client.set_image_metadata_item(999,"},{"line_number":148,"context_line":"                                                            \u0027key1\u0027, meta)"},{"line_number":149,"context_line":"            resp, metadata \u003d self.client.list_image_metadata(999)"},{"line_number":150,"context_line":"        except:"},{"line_number":151,"context_line":"            pass"},{"line_number":152,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAD3%2F%2F9DY%3D","line":149,"updated":"2012-01-18 06:22:48.000000000","message":"This list call seems to be extraneous and doesn\u0027t add anything to the test. It doesn\u0027t seem that it needs to be included.","commit_id":"cf856e1fe2c969921b5b93c66a7ac767d9070cdb"}]}