)]}'
{"tempest/tests/compute/admin/test_flavors_access.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"609a9e133c09e01e67d53e37da0ef3bc65a5dd5f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        resp, flavors \u003d self.flavors_client.list_flavors_with_detail()"},{"line_number":79,"context_line":"        self.assertEqual(resp.status, 200)"},{"line_number":80,"context_line":"        flag \u003d False"},{"line_number":81,"context_line":"        for flavor in flavors:"},{"line_number":82,"context_line":"            if flavor[\u0027id\u0027] \u003d\u003d new_flavor[\u0027id\u0027]:"},{"line_number":83,"context_line":"                flag \u003d True"},{"line_number":84,"context_line":"        self.assertTrue(flag)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2Fv2M%3D","line":81,"updated":"2013-03-29 14:13:23.000000000","message":"Not a nit this works fine as is. Just a suggestion I normally use a lambda function here and make this loop with a flag just a a single line, something like:\n\nself.assertIn(new_flavor[\u0027id\u0027], map(lambda x: x[\u0027id\u0027], flavors))","commit_id":"2d22335be1d8ee9de221e062ecb44fee1d5ec886"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"609a9e133c09e01e67d53e37da0ef3bc65a5dd5f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                                     is_public\u003d\u0027False\u0027)"},{"line_number":127,"context_line":"        self.addCleanup(self.client.delete_flavor, new_flavor[\u0027id\u0027])"},{"line_number":128,"context_line":"        #Add flavor access to a tenant."},{"line_number":129,"context_line":"        resp_body \u003d {"},{"line_number":130,"context_line":"            \"tenant_id\": str(self.tenant_id),"},{"line_number":131,"context_line":"            \"flavor_id\": str(new_flavor[\u0027id\u0027]),"},{"line_number":132,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2Fv3g%3D","line":129,"updated":"2013-03-29 14:13:23.000000000","message":"Is this needed. It doesn\u0027t look like it is used anywhere.","commit_id":"2d22335be1d8ee9de221e062ecb44fee1d5ec886"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"ce284a96028e99f84c2632519c003d1e4357e451","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def tearDownClass(cls):"},{"line_number":55,"context_line":"        super(FlavorsAccessTestJSON, cls).tearDownClass()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_flavor_access_add_remove(self):"},{"line_number":58,"context_line":"        #Test to add and remove flavor access to a given tenant."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fs%2Bg%3D","line":55,"updated":"2013-04-02 12:13:07.000000000","message":"This isn\u0027t necessary as its the default behavior","commit_id":"c16add900f6c351ee3ac8e58196c0c68a0c4ef5b"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"ce284a96028e99f84c2632519c003d1e4357e451","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def tearDownClass(cls):"},{"line_number":55,"context_line":"        super(FlavorsAccessTestJSON, cls).tearDownClass()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_flavor_access_add_remove(self):"},{"line_number":58,"context_line":"        #Test to add and remove flavor access to a given tenant."},{"line_number":59,"context_line":"        flavor_name \u003d rand_name(self.flavor_name_prefix)"},{"line_number":60,"context_line":"        new_flavor_id \u003d rand_int_id(start\u003d1000)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fs%2BI%3D","line":57,"updated":"2013-04-02 12:13:07.000000000","message":"might as well add an attr(\u0027positive\u0027) for this test (we\u0027re not very consistent about it, but should try to be)","commit_id":"c16add900f6c351ee3ac8e58196c0c68a0c4ef5b"}]}