)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"621769f13d6e1977b0d1654b9aba1f13a5786652","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Before scheduling a dvr router with dvr_snat agent, we need to"},{"line_number":10,"context_line":"add external gateway to the router. This would prevent some race"},{"line_number":11,"context_line":"conditions that we are seeing with respect to the dhcp port\u0027s"},{"line_number":12,"context_line":"availability in that dvr_snat agent host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I40b8684f6ec9ddd31753f7bbbdb364d1c0ec838a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a710552_30097096","line":12,"updated":"2015-12-15 02:24:43.000000000","message":"Why not report a bug for race condition by using log http://logs.openstack.org/75/250075/14/check/gate-tempest-dsvm-neutron-dvr-multinode-full/593dd8c/console.html.gz , that may help people easier to understand this patch.","commit_id":"349dbbb89abab2e8a69704ff26296f708e1b76fe"}],"tempest/api/network/admin/test_l3_agent_scheduler.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b1fe467f2ca8e900fe276059bb763c7efa77a1e8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":87,"context_line":"            cls.is_dvr_router \u003d cls.admin_client.show_router("},{"line_number":88,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":89,"context_line":"            if cls.is_dvr_router:"},{"line_number":90,"context_line":"                cls.network \u003d cls.create_network()"},{"line_number":91,"context_line":"                cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":92,"context_line":"                cls.port \u003d cls.create_port(cls.network)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_5152e068","line":89,"updated":"2015-12-17 11:58:18.000000000","message":"I think this part should not be dvr only, it should be executed regardless to dvr usage.","commit_id":"6198fe3a487aa7482eab3b953469d22acda1d646"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9ab7d4ee896b4e0d145d531ddf2dea62905b0f9a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":87,"context_line":"            cls.is_dvr_router \u003d cls.admin_client.show_router("},{"line_number":88,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":89,"context_line":"            if cls.is_dvr_router:"},{"line_number":90,"context_line":"                cls.network \u003d cls.create_network()"},{"line_number":91,"context_line":"                cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":92,"context_line":"                cls.port \u003d cls.create_port(cls.network)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_7d030e43","line":89,"in_reply_to":"3a7e1126_5152e068","updated":"2015-12-17 19:02:43.000000000","message":"We kept everything under the dvr condition to preserve the behavior of the test for centralized routers. In fact I think that for this reason, the update_router_wish_Snat_gw_info should go after line 89.\n\nHaving said that, after much consideration I am starting to believe that this test is not even a candidate for being in Tempest. It\u0027s too grey, and if I recall my chat with Matthew correctly, we should really reconsider what test must live here and what test must be consider a Neutron functional test. The former are (in my understanding) aimed at establishing defcore status. An openstack cloud may as well provide routing capabilities, but have nothing to do with L3 agents.\n\nAssaf promised us to kickstart the initiative, we\u0027ll put together something for your review soon.\n\nSorry I shamelessly use this review to plug something else :)","commit_id":"6198fe3a487aa7482eab3b953469d22acda1d646"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9a562055bbb55869d98fbb88ce6b7c41ab819396","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if test.is_extension_enabled(\u0027dvr\u0027, \u0027network\u0027):"},{"line_number":87,"context_line":"            cls.is_dvr_router \u003d cls.admin_client.show_router("},{"line_number":88,"context_line":"                cls.router[\u0027id\u0027])[\u0027router\u0027].get(\u0027distributed\u0027, False)"},{"line_number":89,"context_line":"            if cls.is_dvr_router:"},{"line_number":90,"context_line":"                cls.network \u003d cls.create_network()"},{"line_number":91,"context_line":"                cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":92,"context_line":"                cls.port \u003d cls.create_port(cls.network)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_f4e38131","line":89,"in_reply_to":"3a7e1126_7d030e43","updated":"2015-12-18 06:18:21.000000000","message":"+1 on removing from tempest, this is clearly a functional test and I think we already have such a test in neutron (if not, it\u0027s very easy to add it)","commit_id":"6198fe3a487aa7482eab3b953469d22acda1d646"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f86258d1594df1708f346eded7a32334e12621b5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                # the test gets executed and so the router is not scheduled"},{"line_number":88,"context_line":"                # on the given agent. By adding the external gateway info to"},{"line_number":89,"context_line":"                # the router, the router should be properly scheduled in the"},{"line_number":90,"context_line":"                # dvr_snat node."},{"line_number":91,"context_line":"                external_gateway_info \u003d {"},{"line_number":92,"context_line":"                    \u0027network_id\u0027: CONF.network.public_network_id,"},{"line_number":93,"context_line":"                    \u0027enable_snat\u0027: True}"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_3457a759","line":90,"updated":"2016-01-05 13:56:27.000000000","message":"Could you add a sentence like \"This is a temporary workaround to prevent a race condition\" or something ? To make it super clear.","commit_id":"ab7d138db6ea2f67eb7c2f8a79563d32b198f8dc"}]}