)]}'
{"tempest/api/identity/admin/v3/test_groups.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d69d24e7fe8972a6587568692f787da0ac515c8b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # create a user"},{"line_number":88,"context_line":"        user \u003d self.client.create_user("},{"line_number":89,"context_line":"            data_utils.rand_name(\u0027User\u0027),"},{"line_number":90,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass\u0027))[\u0027user\u0027]"},{"line_number":91,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"        # create two groups, and add user into them"},{"line_number":93,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_2372197c","side":"PARENT","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":20},"updated":"2015-12-18 14:42:44.000000000","message":"I\u0027m not sure about removing this? It seems unrelated.","commit_id":"9ccf77af488c3b6464356b6fab106ec78e3b7c51"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"8004536c3490a09c2d88b7d81db417d59569f50f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # create a user"},{"line_number":88,"context_line":"        user \u003d self.client.create_user("},{"line_number":89,"context_line":"            data_utils.rand_name(\u0027User\u0027),"},{"line_number":90,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass\u0027))[\u0027user\u0027]"},{"line_number":91,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"        # create two groups, and add user into them"},{"line_number":93,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_71c3e2ed","side":"PARENT","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":20},"in_reply_to":"3a7e1126_104fcf37","updated":"2015-12-29 10:58:47.000000000","message":"I agree to Andrea, but IMHO it\u0027s a nit. We have to fix create_user() in many places then and letting the kwarg password won\u0027t fix it completely since user kwarg is missing also.","commit_id":"9ccf77af488c3b6464356b6fab106ec78e3b7c51"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"b1db9ea8aed102c5f105c24b99f757fbc2940067","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # create a user"},{"line_number":88,"context_line":"        user \u003d self.client.create_user("},{"line_number":89,"context_line":"            data_utils.rand_name(\u0027User\u0027),"},{"line_number":90,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass\u0027))[\u0027user\u0027]"},{"line_number":91,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"        # create two groups, and add user into them"},{"line_number":93,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_c391d5f2","side":"PARENT","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":20},"in_reply_to":"3a7e1126_2372197c","updated":"2015-12-18 14:45:30.000000000","message":"+1","commit_id":"9ccf77af488c3b6464356b6fab106ec78e3b7c51"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"fb749af53aa2c8e234ae52a571205d9005c69bfd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # create a user"},{"line_number":88,"context_line":"        user \u003d self.client.create_user("},{"line_number":89,"context_line":"            data_utils.rand_name(\u0027User\u0027),"},{"line_number":90,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass\u0027))[\u0027user\u0027]"},{"line_number":91,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"        # create two groups, and add user into them"},{"line_number":93,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_439de508","side":"PARENT","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":20},"in_reply_to":"3a7e1126_2372197c","updated":"2015-12-18 14:46:11.000000000","message":"it should works, pls look at L71","commit_id":"9ccf77af488c3b6464356b6fab106ec78e3b7c51"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"250ab88ee15ad1fa003b7c1abae029c083758d56","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # create a user"},{"line_number":88,"context_line":"        user \u003d self.client.create_user("},{"line_number":89,"context_line":"            data_utils.rand_name(\u0027User\u0027),"},{"line_number":90,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass\u0027))[\u0027user\u0027]"},{"line_number":91,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"        # create two groups, and add user into them"},{"line_number":93,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_86c99b28","side":"PARENT","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":20},"in_reply_to":"3a7e1126_439de508","updated":"2015-12-18 14:57:44.000000000","message":"Yes, but when we separate users_client from identity client, we will have to specify name\u003ddata_utils.rand_name(\u0027User\u0027) and password\u003ddata_utils.rand_name(\u0027Pass\u0027). So let\u0027s not remove anything here.","commit_id":"9ccf77af488c3b6464356b6fab106ec78e3b7c51"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dd13618dc02e5ef685386fa80dcbe8709af0325e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # create a user"},{"line_number":88,"context_line":"        user \u003d self.client.create_user("},{"line_number":89,"context_line":"            data_utils.rand_name(\u0027User\u0027),"},{"line_number":90,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass\u0027))[\u0027user\u0027]"},{"line_number":91,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"        # create two groups, and add user into them"},{"line_number":93,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_104fcf37","side":"PARENT","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":20},"in_reply_to":"3a7e1126_5aa4ad06","updated":"2015-12-21 17:18:49.000000000","message":"There is no difference now. But all we need to fix here is data_utils.rand_name(\u0027Pass\u0027) -\u003e data_utils.rand_password() and that\u0027s it. We shouldn\u0027t remove anything here because in the future we will have to specify \u0027password\u003d...\u0027 again.","commit_id":"9ccf77af488c3b6464356b6fab106ec78e3b7c51"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"09b514f355354d3f2cdbeda905f95e6f1142b72f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        # create a user"},{"line_number":88,"context_line":"        user \u003d self.client.create_user("},{"line_number":89,"context_line":"            data_utils.rand_name(\u0027User\u0027),"},{"line_number":90,"context_line":"            password\u003ddata_utils.rand_name(\u0027Pass\u0027))[\u0027user\u0027]"},{"line_number":91,"context_line":"        self.addCleanup(self.client.delete_user, user[\u0027id\u0027])"},{"line_number":92,"context_line":"        # create two groups, and add user into them"},{"line_number":93,"context_line":"        groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_5aa4ad06","side":"PARENT","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":20},"in_reply_to":"3a7e1126_86c99b28","updated":"2015-12-21 09:52:04.000000000","message":"Yaroslav, I really don\u0027t understand what is difference between (L69-71)\n\nname \u003d data_utils.rand_name(\u0027User\u0027)\npassword \u003d data_utils.rand_password()\nuser \u003d self.client.create_user(name, password)[\u0027user\u0027]\n\nand\n\nuser \u003d self.client.create_user(data_utils.rand_name(\u0027User\u0027), data_utils.rand_password())[\u0027user\u0027]|\n\n?","commit_id":"9ccf77af488c3b6464356b6fab106ec78e3b7c51"}]}