)]}'
{"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"f0000862bfc34c837ee4c5ca16352bc333fe4612","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def _migration_available(self):"},{"line_number":237,"context_line":"        \"\"\"Return True if migration is possible. \"\"\""},{"line_number":238,"context_line":"        h_list \u003d self.admin_manager.hypervisor_client.list_hypervisors()"},{"line_number":239,"context_line":"        return [len(h_list[\u0027hypervisors\u0027]) \u003e 1 and"},{"line_number":240,"context_line":"                CONF.compute_feature_enabled.resize]"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def distribute_servers(self, server1, server2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_b55054d5","line":239,"range":{"start_line":239,"start_character":28,"end_line":239,"end_character":39},"updated":"2015-12-20 18:14:34.000000000","message":"Hi Yair , You code call to migration , why do you check resize , as far as i know its not migration .\n\nIn tempest we have a flag for live migration (nova)\n\n# Does the test environment support live migration available? (boolean\n# value)\n#live_migration \u003d true","commit_id":"cf24225d148e3b330293aff70ca9241849cfa321"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"e09b3ce5999efe3b832e7ebb5deca1f25cbc9901","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        server1, server2 \u003d [servers_client.show_server(s[\"id\"])[\"server\"]"},{"line_number":250,"context_line":"                            for s in (server1, server2)]"},{"line_number":251,"context_line":"        if server1[\"OS-EXT-SRV-ATTR:host\"] \u003d\u003d server2[\"OS-EXT-SRV-ATTR:host\"]:"},{"line_number":252,"context_line":"            LOG.info(\"Migrating Server %s to a different compute node\" %"},{"line_number":253,"context_line":"                     server1[\"id\"])"},{"line_number":254,"context_line":"            servers_client.migrate_server(server1[\"id\"])"},{"line_number":255,"context_line":"            waiters.wait_for_server_status(servers_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_ea2b0232","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":12},"updated":"2015-12-22 18:14:16.000000000","message":"you can boot instances on a chosen host :\nhttp://docs.openstack.org/user-guide-admin/cli_nova_specify_host.html","commit_id":"362208da1664695bee328b86328f721fae733359"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"6f89c027d47483b5590cbf2551c200051a6c1104","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        server1, server2 \u003d [servers_client.show_server(s[\"id\"])[\"server\"]"},{"line_number":250,"context_line":"                            for s in (server1, server2)]"},{"line_number":251,"context_line":"        if server1[\"OS-EXT-SRV-ATTR:host\"] \u003d\u003d server2[\"OS-EXT-SRV-ATTR:host\"]:"},{"line_number":252,"context_line":"            LOG.info(\"Migrating Server %s to a different compute node\" %"},{"line_number":253,"context_line":"                     server1[\"id\"])"},{"line_number":254,"context_line":"            servers_client.migrate_server(server1[\"id\"])"},{"line_number":255,"context_line":"            waiters.wait_for_server_status(servers_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_75584157","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":12},"in_reply_to":"1a7b0d38_5530a556","updated":"2015-12-23 06:13:47.000000000","message":"So we can run tempest code twice on existing setup and get different flows in your tests because we dont have a way to force a compute node for instances .\nI think you must to fix it , otherwise its not consistent.\n\nBenny","commit_id":"362208da1664695bee328b86328f721fae733359"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1d779da32ec8b599b94878bd317f0ee828128106","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        server1, server2 \u003d [servers_client.show_server(s[\"id\"])[\"server\"]"},{"line_number":250,"context_line":"                            for s in (server1, server2)]"},{"line_number":251,"context_line":"        if server1[\"OS-EXT-SRV-ATTR:host\"] \u003d\u003d server2[\"OS-EXT-SRV-ATTR:host\"]:"},{"line_number":252,"context_line":"            LOG.info(\"Migrating Server %s to a different compute node\" %"},{"line_number":253,"context_line":"                     server1[\"id\"])"},{"line_number":254,"context_line":"            servers_client.migrate_server(server1[\"id\"])"},{"line_number":255,"context_line":"            waiters.wait_for_server_status(servers_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_5530a556","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":12},"in_reply_to":"1a7b0d38_ea2b0232","updated":"2015-12-23 05:54:06.000000000","message":"Please read the commit message:\n\n  Note: Doesn\u0027t try to influence the boot command because  that will require admin client and prevent tenant users from accessing servers because keys are attached to users and not tenants.","commit_id":"362208da1664695bee328b86328f721fae733359"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9fdd85b7fe98d321ba770bea6dfa5421b5a93125","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            self.assertNotEqual(server1[\"OS-EXT-SRV-ATTR:host\"],"},{"line_number":262,"context_line":"                                server2[\"OS-EXT-SRV-ATTR:host\"],"},{"line_number":263,"context_line":"                                msg\u003d\"Failed to migrate server to \""},{"line_number":264,"context_line":"                                    \"new compute node\")"},{"line_number":265,"context_line":"        LOG.info(\"Servers are on different compute nodes\")"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _create_server(self, name, tenant, security_groups\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_f0a43f09","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":36},"updated":"2015-12-23 06:22:10.000000000","message":"i dont that that log a meesage if a good idea when we skip this phase which is part of test flows. there are otherway to notify about skipping tests","commit_id":"362208da1664695bee328b86328f721fae733359"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"927a6af39dfdb1492306760d028323ec02348243","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        \"\"\""},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        def _filter_zones(zone_data):"},{"line_number":617,"context_line":"            \"\"\"Filter zone list to actual hypervisor list."},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            Match zones that only have nova-compute agents."},{"line_number":620,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_1d75f162","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":12},"updated":"2016-01-05 10:51:35.000000000","message":"Do we really need all these look up ? \nI thought that nova hypervisor-list returns the compure names and there are used in nova boot command.\n?\nAm i missing something ?\nBenny","commit_id":"37605dbbeedca1216f4ce1d76f8bfe5c082aef9d"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"25384cf7635ed972d38175bfbc1d6ef6eddcb932","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        \"\"\""},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        def _filter_zones(zone_data):"},{"line_number":617,"context_line":"            \"\"\"Filter zone list to actual hypervisor list."},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            Match zones that only have nova-compute agents."},{"line_number":620,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_4f3decc2","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":12},"in_reply_to":"fa69d971_1d75f162","updated":"2016-01-05 11:35:08.000000000","message":"Yair , what do you think about this command :\n\n nova service-list\n+----+----------------+---------------------+----------+---------+-------+----------------------------+-----------------+\n| Id | Binary         | Host                | Zone     | Status  | State | Updated_at                 | Disabled Reason |\n\n\nIt returns the service , host  and zone for computes\nyou can lookup by binary and get the service-name.\n\n\n?","commit_id":"37605dbbeedca1216f4ce1d76f8bfe5c082aef9d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"39a16b56dfc8cf13a87d0b54c4125c1e21ec5fe0","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        \"\"\""},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        def _filter_zones(zone_data):"},{"line_number":617,"context_line":"            \"\"\"Filter zone list to actual hypervisor list."},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            Match zones that only have nova-compute agents."},{"line_number":620,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_e3895776","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":12},"in_reply_to":"fa69d971_4f3decc2","updated":"2016-01-05 12:35:56.000000000","message":"tnx. I was unfamiliar with that.","commit_id":"37605dbbeedca1216f4ce1d76f8bfe5c082aef9d"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"927a6af39dfdb1492306760d028323ec02348243","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        try:"},{"line_number":636,"context_line":"            # Admin can list hypervisors and zones and control where the"},{"line_number":637,"context_line":"            # servers are created. Non-admin will boot servers regularly"},{"line_number":638,"context_line":"            hosts \u003d tenant.manager.hypervisor_client.list_hypervisors()"},{"line_number":639,"context_line":"        except exceptions.Forbidden:"},{"line_number":640,"context_line":"            # non-admin client can\u0027t see hypervisor list, and that\u0027s fine"},{"line_number":641,"context_line":"            self.assertEqual(tenant, self.alt_tenant,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_3d68f5b8","line":638,"range":{"start_line":638,"start_character":12,"end_line":638,"end_character":17},"updated":"2016-01-05 10:51:35.000000000","message":"Did you mean to self.hosts , otherwise its not the same as self ?  please fix\nBenny","commit_id":"37605dbbeedca1216f4ce1d76f8bfe5c082aef9d"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"39a16b56dfc8cf13a87d0b54c4125c1e21ec5fe0","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        try:"},{"line_number":636,"context_line":"            # Admin can list hypervisors and zones and control where the"},{"line_number":637,"context_line":"            # servers are created. Non-admin will boot servers regularly"},{"line_number":638,"context_line":"            hosts \u003d tenant.manager.hypervisor_client.list_hypervisors()"},{"line_number":639,"context_line":"        except exceptions.Forbidden:"},{"line_number":640,"context_line":"            # non-admin client can\u0027t see hypervisor list, and that\u0027s fine"},{"line_number":641,"context_line":"            self.assertEqual(tenant, self.alt_tenant,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_238c4f7e","line":638,"range":{"start_line":638,"start_character":12,"end_line":638,"end_character":17},"in_reply_to":"fa69d971_3d68f5b8","updated":"2016-01-05 12:35:56.000000000","message":"Done","commit_id":"37605dbbeedca1216f4ce1d76f8bfe5c082aef9d"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"25384cf7635ed972d38175bfbc1d6ef6eddcb932","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        try:"},{"line_number":636,"context_line":"            # Admin can list hypervisors and zones and control where the"},{"line_number":637,"context_line":"            # servers are created. Non-admin will boot servers regularly"},{"line_number":638,"context_line":"            hosts \u003d tenant.manager.hypervisor_client.list_hypervisors()"},{"line_number":639,"context_line":"        except exceptions.Forbidden:"},{"line_number":640,"context_line":"            # non-admin client can\u0027t see hypervisor list, and that\u0027s fine"},{"line_number":641,"context_line":"            self.assertEqual(tenant, self.alt_tenant,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_6f2550bf","line":638,"range":{"start_line":638,"start_character":12,"end_line":638,"end_character":17},"in_reply_to":"fa69d971_3d68f5b8","updated":"2016-01-05 11:35:08.000000000","message":"Done","commit_id":"37605dbbeedca1216f4ce1d76f8bfe5c082aef9d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7e33e2235108136b4dd54f17bf1e9b6a1ccc321f","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        self.hosts \u003d []"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    def _create_server(self, name, tenant, security_groups\u003dNone, **kwargs):"},{"line_number":614,"context_line":"        \"\"\"Admin client will create the servers on different hosts."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        Need to filter the proper services by searching for those"},{"line_number":617,"context_line":"        that only contain nova-compute agents."}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_370adad3","line":614,"range":{"start_line":614,"start_character":11,"end_line":614,"end_character":67},"updated":"2016-01-12 07:22:56.000000000","message":"Why don\u0027t you use \"different_host\" scheduler_hint for doing this?\n\nThe different_host filter is enabled  now on the gate, so we can use it now.\n\nPlease see https://review.openstack.org/#/c/257660/ as a sample.","commit_id":"11c520d1106548b3339a24d0100d4acb71da228f"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"591841adbd55814110e361adc76b4814c2a3f641","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        on creation."},{"line_number":603,"context_line":"        Validates servers are created as requested, using admin client."},{"line_number":604,"context_line":"        \"\"\""},{"line_number":605,"context_line":"        hints \u003d {\u0027different_host\u0027: self.servers}"},{"line_number":606,"context_line":"        server \u003d super(TestSecurityGroupsMultiNode, self)._create_server("},{"line_number":607,"context_line":"            name, tenant, security_groups, scheduler_hints\u003dhints, **kwargs)"},{"line_number":608,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_4d3797e3","line":605,"updated":"2016-01-18 08:49:56.000000000","message":"Since the different_host is not default filter, likely we need to skip the test when nova does not have this feature enabled. It should be based on default an a config option.","commit_id":"3cc2c55579b0e078f060f2ef7302eeb82d8437c4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8bd0a6d68b360dac098b998dd58c1a6d26e6ff01","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        \"\"\"creates a server and assigns to security group\"\"\""},{"line_number":237,"context_line":"        if security_groups is None:"},{"line_number":238,"context_line":"            security_groups \u003d [tenant.security_groups[\u0027default\u0027]]"},{"line_number":239,"context_line":"        security_groups_names \u003d [{\u0027name\u0027: s[\u0027name\u0027]} for s in security_groups]"},{"line_number":240,"context_line":"        server \u003d self.create_server("},{"line_number":241,"context_line":"            name\u003dname,"},{"line_number":242,"context_line":"            networks\u003d[{\u0027uuid\u0027: tenant.network.id}],"}],"source_content_type":"text/x-python","patch_set":14,"id":"dae33548_7b9f7a50","line":239,"range":{"start_line":239,"start_character":77,"end_line":239,"end_character":78},"updated":"2016-02-16 08:45:24.000000000","message":"Why we cannot boot servers with different hosts here in case of multinode.\n\nSO with if condition we can run same tests for single as well as for multinode.","commit_id":"3d9a71e3b6ed003835249fff9852d35f2d1294ce"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"702710dd8f3102cce89c611ab2d29f84b5b1aea8","unresolved":false,"context_lines":[{"line_number":636,"context_line":"    @test.idempotent_id(\u00275093acd8-6574-4ff4-bc28-19dc52ca94d9\u0027)"},{"line_number":637,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":638,"context_line":"    def test_cross_tenant_traffic(self):"},{"line_number":639,"context_line":"        if not self.credentials_provider.is_multi_tenant():"},{"line_number":640,"context_line":"            raise self.skipException(\"No secondary tenant defined\")"},{"line_number":641,"context_line":"        self._cross_tenant_test()"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"dae33548_9fea8fd9","line":639,"updated":"2016-02-18 14:37:44.000000000","message":"It seems his check is same as L.460. Why not move to L.426?\n\n        if not self.credentials_provider.is_multi_tenant():\n            raise self.skipException(\"No secondary tenant defined\")","commit_id":"3d9a71e3b6ed003835249fff9852d35f2d1294ce"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1f245f185a825e83d8a17176d458dc6129ad0dfd","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if CONF.compute.min_compute_nodes \u003e 1 and \\"},{"line_number":172,"context_line":"                test.is_filter_enabled(\"DifferentHostFilter\"):"},{"line_number":173,"context_line":"            LOG.info(\"Working in Multi Node mode\")"},{"line_number":174,"context_line":"            self.servers \u003d []"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            LOG.info(\"Working in Single Node mode\")"},{"line_number":177,"context_line":"            self.servers \u003d None"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        super(TestSecurityGroupsBasicOps, self).setUp()"},{"line_number":180,"context_line":"        self._deploy_tenant(self.primary_tenant)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aed3d3a_6f9b5dca","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":31},"updated":"2016-02-26 06:36:10.000000000","message":"This way seems too tricky..\n\nit is unreadable to distinguish multi-node-mode from [] or None. How about adding another flag (eg. multi_node)?","commit_id":"7851f5729edc309118de15b93fdec1990994a1ce"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6b1c9d6e3aba32401e523f1fa078528fc48e1b02","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        )"},{"line_number":388,"context_line":"        self._create_security_group_rule("},{"line_number":389,"context_line":"            secgroup\u003dtenant.security_groups[\u0027default\u0027],"},{"line_number":390,"context_line":"            security_groups_client\u003dtenant.manager.network_client,"},{"line_number":391,"context_line":"            **ruleset"},{"line_number":392,"context_line":"        )"},{"line_number":393,"context_line":"        access_point_ssh \u003d self._connect_to_access_point(tenant)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_d335d3da","line":390,"range":{"start_line":390,"start_character":12,"end_line":390,"end_character":64},"updated":"2016-03-02 09:08:45.000000000","message":"two issue here-\n1. do we need this change?\n\n2. If yes then network_client is not security grp client anymore. It should be security_groups_client\u003dtenant.manager.security_groups_client\n\nIt pass because you are passing default sec grp and in that case this method does not use passed \u0027security_groups_client\u0027","commit_id":"4391d18f3e3aa5b1d19c684c03436ae570cb9183"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4718b473222bc785b37cfdb94816b4531a546f91","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        )"},{"line_number":388,"context_line":"        self._create_security_group_rule("},{"line_number":389,"context_line":"            secgroup\u003dtenant.security_groups[\u0027default\u0027],"},{"line_number":390,"context_line":"            security_groups_client\u003dtenant.manager.network_client,"},{"line_number":391,"context_line":"            **ruleset"},{"line_number":392,"context_line":"        )"},{"line_number":393,"context_line":"        access_point_ssh \u003d self._connect_to_access_point(tenant)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_a3aeb8e3","line":390,"range":{"start_line":390,"start_character":12,"end_line":390,"end_character":64},"in_reply_to":"7af24918_9a2d0949","updated":"2016-03-02 23:49:02.000000000","message":"Currently this method is in used with self.primary_tenant only so it works as it is, but yea passing client explicitly does not harm anything as tenant in param can be other than primary.","commit_id":"4391d18f3e3aa5b1d19c684c03436ae570cb9183"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"c38e0600a65c6c9d9507d7cc2e3cda9a840c632f","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        )"},{"line_number":388,"context_line":"        self._create_security_group_rule("},{"line_number":389,"context_line":"            secgroup\u003dtenant.security_groups[\u0027default\u0027],"},{"line_number":390,"context_line":"            security_groups_client\u003dtenant.manager.network_client,"},{"line_number":391,"context_line":"            **ruleset"},{"line_number":392,"context_line":"        )"},{"line_number":393,"context_line":"        access_point_ssh \u003d self._connect_to_access_point(tenant)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_9a2d0949","line":390,"range":{"start_line":390,"start_character":12,"end_line":390,"end_character":64},"in_reply_to":"7af24918_d335d3da","updated":"2016-03-02 14:42:15.000000000","message":"We don\u0027t need this change.\nThe first draft of this patch revealed that the original mode was wrong.\nI can keep it as wrong, or I can add this fix according to your commend.","commit_id":"4391d18f3e3aa5b1d19c684c03436ae570cb9183"}],"tempest/test.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71d1932355d3391d144eea0283c71e803577f2ac","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    return False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def is_filter_enabled(filter_name):"},{"line_number":184,"context_line":"    \"\"\"Check the list of enabled compute scheduler filters from config. \"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    filters \u003d CONF.compute_feature_enabled.scheduler_available_filters"}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_43d2545d","line":183,"range":{"start_line":183,"start_character":21,"end_line":183,"end_character":22},"updated":"2016-03-02 23:52:13.000000000","message":"method name is too generic as \u0027filter\u0027 can be anything how about is_scheduler_filter_enabled(filter_name)","commit_id":"ca5cfb5ef0ebd2b80bf7c7b131803fca90ef8143"}]}