)]}'
{"tempest/api/compute/servers/test_servers_negative.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dbd35e21eb7b11a9cbdb4329a081ccb0a3fb256d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":56,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":59,"context_line":"    @test.idempotent_id(\u0027b8a7235e-5246-4a8f-a08e-b34877c6586f\u0027)"},{"line_number":60,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.personality,"},{"line_number":61,"context_line":"                          \u0027Nova personality feature disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_0e581487","line":58,"range":{"start_line":58,"start_character":30,"end_line":58,"end_character":33},"updated":"2016-01-15 08:53:47.000000000","message":"We should not delete the test","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"660aa31190096395bdb1adc80f0e272009214a6c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":56,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":59,"context_line":"    @test.idempotent_id(\u0027b8a7235e-5246-4a8f-a08e-b34877c6586f\u0027)"},{"line_number":60,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.personality,"},{"line_number":61,"context_line":"                          \u0027Nova personality feature disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_9df6775b","line":58,"range":{"start_line":58,"start_character":30,"end_line":58,"end_character":33},"in_reply_to":"da6ed579_0c7b3cc2","updated":"2016-01-15 10:36:44.000000000","message":"Actually, you\u0027re right. This is a bug and needs to be fixed.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"bb1c269eeeddd536e6844f946a840b391d156a39","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":56,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":59,"context_line":"    @test.idempotent_id(\u0027b8a7235e-5246-4a8f-a08e-b34877c6586f\u0027)"},{"line_number":60,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.personality,"},{"line_number":61,"context_line":"                          \u0027Nova personality feature disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_4e436c6c","line":58,"range":{"start_line":58,"start_character":30,"end_line":58,"end_character":33},"in_reply_to":"da6ed579_0e581487","updated":"2016-01-15 08:56:45.000000000","message":"According to code now, this test is not negative test and is not required, if name is not provided it is created with default name","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":56,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":59,"context_line":"    @test.idempotent_id(\u0027b8a7235e-5246-4a8f-a08e-b34877c6586f\u0027)"},{"line_number":60,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.personality,"},{"line_number":61,"context_line":"                          \u0027Nova personality feature disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_b1c04d51","line":58,"range":{"start_line":58,"start_character":30,"end_line":58,"end_character":33},"in_reply_to":"da6ed579_4e436c6c","updated":"2016-01-15 09:16:24.000000000","message":"This test is providing a blank name, not no name, and should be kept.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"dcca644f466d7de297b0df146f6fd047ab2b5f4a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":56,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":59,"context_line":"    @test.idempotent_id(\u0027b8a7235e-5246-4a8f-a08e-b34877c6586f\u0027)"},{"line_number":60,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.personality,"},{"line_number":61,"context_line":"                          \u0027Nova personality feature disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_0c7b3cc2","line":58,"range":{"start_line":58,"start_character":30,"end_line":58,"end_character":33},"in_reply_to":"da6ed579_b1c04d51","updated":"2016-01-15 09:33:38.000000000","message":"please check L52 here, it won\u0027t be negative test https://review.openstack.org/#/c/259859/10/tempest/common/compute.py","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}],"tempest/common/compute.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efac5e793ff6128bc91b9c73ce0c959ae6c548","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # TODO(jlanoux) add support of wait_until PINGABLE/SSHABLE"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    name \u003d name or data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":53,"context_line":"    flavor \u003d flavor or CONF.compute.flavor_ref"},{"line_number":54,"context_line":"    image_id \u003d image_id or CONF.compute.image_ref"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_b311deb1","line":52,"range":{"start_line":52,"start_character":61,"end_line":52,"end_character":63},"updated":"2016-01-18 06:00:23.000000000","message":"If you are making these param explicitly then, this need to be like below- for all 3 param. For negative tests which want to pass empty string and in case of boot from volume-\n\nif name is not None:\n    name \u003d name\nelse \n   name \u003d data_utils.rand_name(__name__ + \"-instance\")\n\nSame for imgae_id and flavor","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ca3955e508b91f45708be0a21e04705f1bc819d6","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # TODO(jlanoux) add support of wait_until PINGABLE/SSHABLE"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    name \u003d name or data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":53,"context_line":"    flavor \u003d flavor or CONF.compute.flavor_ref"},{"line_number":54,"context_line":"    image_id \u003d image_id or CONF.compute.image_ref"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba63e191_ae6af118","line":52,"range":{"start_line":52,"start_character":61,"end_line":52,"end_character":63},"in_reply_to":"da6ed579_86624915","updated":"2016-01-19 00:31:32.000000000","message":"There is difference, what i suggesting is to allow empty string also which is needed for negative tests removed in this patch.\n\nAlso some tests needs to pass image-id as empty string for volume boot cases.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"fc52684c24bcefc2ba5ef5569479a25f51241ade","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # TODO(jlanoux) add support of wait_until PINGABLE/SSHABLE"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    name \u003d name or data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":53,"context_line":"    flavor \u003d flavor or CONF.compute.flavor_ref"},{"line_number":54,"context_line":"    image_id \u003d image_id or CONF.compute.image_ref"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_86624915","line":52,"range":{"start_line":52,"start_character":61,"end_line":52,"end_character":63},"in_reply_to":"da6ed579_b311deb1","updated":"2016-01-18 11:30:51.000000000","message":"What you suggest is what this patch does. \n\n  name \u003d name or data_utils.rand_name(__name__ + \"-instance\")\n\nis the same as\n\nif name is not None:\n    name \u003d name\nelse \n   name \u003d data_utils.rand_name(__name__ + \"-instance\")","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"afa2b877dc17606143f83fbba5c231ba49a284db","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def create_test_server(clients, validatable\u003dFalse, validation_resources\u003dNone,"},{"line_number":31,"context_line":"                       tenant_network\u003dNone, wait_until\u003dNone,"},{"line_number":32,"context_line":"                       volume_backed\u003dFalse, name\u003dNone, flavor\u003dNone,"},{"line_number":33,"context_line":"                       image_id\u003dNone, **kwargs):"},{"line_number":34,"context_line":"    \"\"\"Common wrapper utility returning a test server."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    This method is a common wrapper returning a test server that can be"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_64c72e13","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":48},"updated":"2016-01-19 07:24:30.000000000","message":"I thought this will need caller to changes also who not passing the image and flavor.\n\nLets discuss this first to get consensus.","commit_id":"f28243da6c69c23c328e9e0bce7471a9a8342642"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f777848bcb4317eaf11cc40b62b2d1b5ba3bd3d9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def create_test_server(clients, validatable\u003dFalse, validation_resources\u003dNone,"},{"line_number":31,"context_line":"                       tenant_network\u003dNone, wait_until\u003dNone,"},{"line_number":32,"context_line":"                       volume_backed\u003dFalse, name\u003dNone, flavor\u003dNone,"},{"line_number":33,"context_line":"                       image_id\u003dNone, **kwargs):"},{"line_number":34,"context_line":"    \"\"\"Common wrapper utility returning a test server."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    This method is a common wrapper returning a test server that can be"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_87a024f6","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":48},"in_reply_to":"ba63e191_64c72e13","updated":"2016-01-19 07:34:36.000000000","message":"Sorry, wrong comment.","commit_id":"f28243da6c69c23c328e9e0bce7471a9a8342642"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"13b8b8f04ee02bc0fef16048f4986be444bf236e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # TODO(jlanoux) add support of wait_until PINGABLE/SSHABLE"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    name \u003d name"},{"line_number":53,"context_line":"    flavor \u003d flavor"},{"line_number":54,"context_line":"    image_id \u003d image_id"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba63e191_82222400","line":52,"updated":"2016-01-19 21:00:35.000000000","message":"What about this:\n\n\nname \u003d name or data_utils.rand_name(__name__ + \"-instance\")\nflavor \u003d flavor or CONF.compute.flavor_ref\nimage_id \u003d image_id or CONF.compute.image_ref\n\n\nThus you can remove \u0027if\u0027 conditions below.","commit_id":"9aaef8b368d44b3637b2476f369b8b9c9176f74e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"15990c6d5edf150c2fefde40630f7ffc2cf10bfe","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # TODO(jlanoux) add support of wait_until PINGABLE/SSHABLE"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    name \u003d name"},{"line_number":53,"context_line":"    flavor \u003d flavor"},{"line_number":54,"context_line":"    image_id \u003d image_id"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba63e191_d718d486","line":52,"in_reply_to":"ba63e191_82222400","updated":"2016-01-19 23:49:30.000000000","message":"That would not work for empty value.","commit_id":"9aaef8b368d44b3637b2476f369b8b9c9176f74e"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb0c659c0d8a5501dce601a3223307c7e21e75f0","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":162,"context_line":"                      validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":163,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":164,"context_line":"        \"\"\"Wrapper utility that returns a test server."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        This wrapper utility calls the common create test server and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_edf04cff","line":163,"range":{"start_line":163,"start_character":65,"end_line":163,"end_character":67},"updated":"2015-12-21 07:43:27.000000000","message":"How about making this function sig as-\ncreate_server(self, validatable\u003dFalse, wait_until\u003dNone,\n                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):\n\naccordingly you need to updates users for it - if they are passing image\u003d then change it to image_id\u003d","commit_id":"e4dda85dc1459c785284a70e3b4e066128e27487"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"27f1e12668938562f02770f507c8030eead5577c","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":162,"context_line":"                      validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":163,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":164,"context_line":"        \"\"\"Wrapper utility that returns a test server."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        This wrapper utility calls the common create test server and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_4d8080c0","line":163,"range":{"start_line":163,"start_character":65,"end_line":163,"end_character":67},"in_reply_to":"3a7e1126_edf04cff","updated":"2015-12-21 08:07:08.000000000","message":"Initially thought of changing the signature, but this might break existing users and external clients using the function like congress etc. ( its hard to track who are using it, hence left the signature as is )","commit_id":"e4dda85dc1459c785284a70e3b4e066128e27487"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb0c659c0d8a5501dce601a3223307c7e21e75f0","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        if image:"},{"line_number":241,"context_line":"            kwargs[\u0027image_id\u0027] \u003d image"},{"line_number":242,"context_line":"        if flavor:"},{"line_number":243,"context_line":"            kwargs[\u0027flavor\u0027] \u003d flavor"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":246,"context_line":"            clients,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_cdaeb0e5","line":243,"range":{"start_line":243,"start_character":31,"end_line":243,"end_character":37},"updated":"2015-12-21 07:43:27.000000000","message":"There other param also not going to compute.create_test_server for example- validatable","commit_id":"e4dda85dc1459c785284a70e3b4e066128e27487"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb0c659c0d8a5501dce601a3223307c7e21e75f0","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":246,"context_line":"            clients,"},{"line_number":247,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":248,"context_line":"            wait_until\u003dwait_until,"},{"line_number":249,"context_line":"            **kwargs)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        # TODO(jlanoux) Move wait_on_delete in compute.py"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_cddc7075","line":248,"range":{"start_line":248,"start_character":33,"end_line":248,"end_character":34},"updated":"2015-12-21 07:43:27.000000000","message":"pass validatable also- \nvalidatable\u003dvalidatable","commit_id":"e4dda85dc1459c785284a70e3b4e066128e27487"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"27f1e12668938562f02770f507c8030eead5577c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":246,"context_line":"            clients,"},{"line_number":247,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":248,"context_line":"            wait_until\u003dwait_until,"},{"line_number":249,"context_line":"            **kwargs)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        # TODO(jlanoux) Move wait_on_delete in compute.py"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_a83c72c8","line":248,"range":{"start_line":248,"start_character":33,"end_line":248,"end_character":34},"in_reply_to":"3a7e1126_cddc7075","updated":"2015-12-21 08:07:08.000000000","message":"Done","commit_id":"e4dda85dc1459c785284a70e3b4e066128e27487"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9e4f0ce1ec188a9e8762b30dd8d75d76a23e7aaf","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":162,"context_line":"                      validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":163,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":164,"context_line":"        \"\"\"Wrapper utility that returns a test server."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        This wrapper utility calls the common create test server and"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_17d19c57","line":163,"range":{"start_line":163,"start_character":65,"end_line":163,"end_character":67},"updated":"2015-12-24 02:03:30.000000000","message":"I prefer to change the sig.","commit_id":"13f91aa25aed618320472febba935fdd1ee0c74c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"288f23e4481cd3f2f7a5d6ca4f24cea8ea34f61f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.addCleanup(client.delete_keypair, name)"},{"line_number":160,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def create_server(self, validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":163,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":164,"context_line":"        \"\"\"Wrapper utility that returns a test server."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_66e70013","line":162,"range":{"start_line":162,"start_character":62,"end_line":162,"end_character":63},"updated":"2016-01-08 09:50:14.000000000","message":"Let\u0027s keep the param name as it is so that it is easy to use this function and more readable.\n\n - name\u003dNone, image\u003dNone, flavor\u003dNone,\n\nJust fix the actual issue. None of these param are passed to common create_test_server() and it end up with creating server with default flavor, image and name always.","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"62975cc13173377bf11f70ae0ed36c7f8778d9dc","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_d36d4399","line":238,"updated":"2015-12-25 10:48:52.000000000","message":"Please, read the note in L172. It looks like we shouldn\u0027t make any changes here.","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"4ec18a8b42b56c06851adb66746d68e6913dcd13","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_ec88a624","line":238,"in_reply_to":"1a7b0d38_46b193e0","updated":"2016-01-04 09:17:12.000000000","message":"As written in the comment, this argument will not be used. You can add it if you wish but if you do, please just add \u0027validatable\u0027 on a new line. Thanks!","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dbb8fc45395a5ef501447f6ac47d530e58cf2058","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_46b193e0","line":238,"in_reply_to":"1a7b0d38_d36d4399","updated":"2015-12-25 11:30:17.000000000","message":"I don\u0027t know whether or not this parameter was purposely missed here, but I think it will not make any harm.","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"cc97f7f41566b97172e47c56c87a9d80f585673d","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_7350725f","line":238,"in_reply_to":"fa69d971_3d172e46","updated":"2016-01-07 11:24:57.000000000","message":"hmm, calling the argument with name would be more clearer and less error prone in my opinion, so it shouldn\u0027t make any difference either way IMO.","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"5ac7e352685bfcd9de0fda709ddaa60c14d6ca46","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_132ed6a5","line":238,"in_reply_to":"fa69d971_7350725f","updated":"2016-01-07 11:29:29.000000000","message":"I feel it\u0027s unnecessary. However, if it gets approved, it needs to be updated everywhere else.","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"6d2eefa4f57d8225e4b568cfe3f6a3f4cd9ee178","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_3d172e46","line":238,"in_reply_to":"fa69d971_a6a1d495","updated":"2016-01-07 09:07:20.000000000","message":"Actually, for every occurence of validatable in a create_test_server call, I added  it in a new line. Also, validatable is a boolean that is passed on by the test so you don\u0027t need to have validatable\u003dvalidatable and the variable will not always be false.","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"a7cd676cbb52362b2a1d53a3eac3b60e5d2b9c10","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_a6a1d495","line":238,"in_reply_to":"fa69d971_ec88a624","updated":"2016-01-07 05:08:41.000000000","message":"Thanks for the comment. Added validatable in the same line as its not crossing the line limit. I think it should be fine to leave it as it is, as it has been done the same at other places too.","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"69a438f6de72a80ff6d0c1810f2c73dd3ab3b1a7","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        tenant_network \u003d self.get_tenant_network()"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        body, servers \u003d compute.create_test_server("},{"line_number":238,"context_line":"            clients, validatable\u003dvalidatable,"},{"line_number":239,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":240,"context_line":"            wait_until\u003dwait_until,"},{"line_number":241,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_e24cf8c9","line":238,"in_reply_to":"fa69d971_ec88a624","updated":"2016-01-05 10:37:30.000000000","message":"Yea so it will passed as False till we make that run for scenario tests.\nBut whats wrong in current way :)","commit_id":"fe40148f75f92a5c8e7eb523235e2b99ac2810dd"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"741d317bfc7b18782f816d4226821469b9237b99","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            clients,"},{"line_number":247,"context_line":"            tenant_network\u003dtenant_network,"},{"line_number":248,"context_line":"            wait_until\u003dwait_until,"},{"line_number":249,"context_line":"            **kwargs)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        # TODO(jlanoux) Move wait_on_delete in compute.py"},{"line_number":252,"context_line":"        if wait_on_delete:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_33408f56","line":249,"updated":"2016-01-12 16:28:42.000000000","message":"honestly, I\u0027d much rather have create_test_server take these args explicity instead of in kwargs.","commit_id":"4d8363221c14dd881a67125cced7eaa3f186681d"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.addCleanup(client.delete_keypair, name)"},{"line_number":161,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":164,"context_line":"                      validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":165,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":166,"context_line":"        \"\"\"Wrapper utility that returns a test server."}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_5159d18c","line":163,"updated":"2016-01-15 09:16:24.000000000","message":"It would be better to change to image_id there.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"dcca644f466d7de297b0df146f6fd047ab2b5f4a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.addCleanup(client.delete_keypair, name)"},{"line_number":161,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":164,"context_line":"                      validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":165,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":166,"context_line":"        \"\"\"Wrapper utility that returns a test server."}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_6cb678fa","line":163,"in_reply_to":"da6ed579_5159d18c","updated":"2016-01-15 09:33:38.000000000","message":"Please check comment on patch set 6","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"660aa31190096395bdb1adc80f0e272009214a6c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.addCleanup(client.delete_keypair, name)"},{"line_number":161,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":164,"context_line":"                      validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":165,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":166,"context_line":"        \"\"\"Wrapper utility that returns a test server."}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_801ccc6a","line":163,"in_reply_to":"da6ed579_6cb678fa","updated":"2016-01-15 10:36:44.000000000","message":"I don\u0027t see anything on patchset 6 related to that. That would be better to have image_id instead of image there so you would not need to modify it in all the scenario tests.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5efac5e793ff6128bc91b9c73ce0c959ae6c548","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.addCleanup(client.delete_keypair, name)"},{"line_number":161,"context_line":"        return body[\u0027keypair\u0027]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def create_server(self, name\u003dNone, image\u003dNone, flavor\u003dNone,"},{"line_number":164,"context_line":"                      validatable\u003dFalse, wait_until\u003dNone,"},{"line_number":165,"context_line":"                      wait_on_delete\u003dTrue, clients\u003dNone, **kwargs):"},{"line_number":166,"context_line":"        \"\"\"Wrapper utility that returns a test server."}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_13746afb","line":163,"in_reply_to":"da6ed579_801ccc6a","updated":"2016-01-18 06:00:23.000000000","message":"Change this to image_id and change if anyone passing \u0027image\u0027.\n\nThis is really bad that two wrapper expecting 2 diff name for same arg.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}],"tempest/scenario/test_encrypted_cinder_volumes.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        image \u003d self.glance_image_create()"},{"line_number":46,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        return self.create_server(image\u003dimage,"},{"line_number":49,"context_line":"                                  key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":50,"context_line":"                                  wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_91074981","line":48,"updated":"2016-01-15 09:16:24.000000000","message":"It would be better to keep image_id.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}],"tempest/scenario/test_minimum_basic.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        image \u003d self.glance_image_create()"},{"line_number":114,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        server \u003d self.create_server(image\u003dimage,"},{"line_number":117,"context_line":"                                    key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":118,"context_line":"                                    wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":119,"context_line":"        servers \u003d self.nova_list()"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_51fd516c","line":116,"updated":"2016-01-15 09:16:24.000000000","message":"ditto.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}],"tempest/scenario/test_server_basic_ops.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        security_groups \u003d [{\u0027name\u0027: self.security_group[\u0027name\u0027]}]"},{"line_number":129,"context_line":"        self.md \u003d {\u0027meta1\u0027: \u0027data1\u0027, \u0027meta2\u0027: \u0027data2\u0027, \u0027metaN\u0027: \u0027dataN\u0027}"},{"line_number":130,"context_line":"        self.instance \u003d self.create_server("},{"line_number":131,"context_line":"            image\u003dself.image_ref,"},{"line_number":132,"context_line":"            flavor\u003dself.flavor_ref,"},{"line_number":133,"context_line":"            key_name\u003dself.keypair[\u0027name\u0027],"},{"line_number":134,"context_line":"            security_groups\u003dsecurity_groups,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_31f77d8c","line":131,"updated":"2016-01-15 09:16:24.000000000","message":"ditto.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}],"tempest/scenario/test_shelve_instance.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            server \u003d self.create_server("},{"line_number":78,"context_line":"                image\u003dCONF.compute.image_ref,"},{"line_number":79,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":80,"context_line":"                security_groups\u003dsecurity_groups,"},{"line_number":81,"context_line":"                wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_912e69f9","line":78,"updated":"2016-01-15 09:16:24.000000000","message":"ditto.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}],"tempest/scenario/test_snapshot_pattern.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # boot an instance and create a timestamp file in it"},{"line_number":49,"context_line":"        server \u003d self.create_server("},{"line_number":50,"context_line":"            image\u003dCONF.compute.image_ref,"},{"line_number":51,"context_line":"            key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            security_groups\u003d[{\u0027name\u0027: security_group[\u0027name\u0027]}],"},{"line_number":53,"context_line":"            wait_until\u003d\u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_114359b3","line":50,"updated":"2016-01-15 09:16:24.000000000","message":"ditto.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}],"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"7070d1af39b40aff05db5ac095051f0eb3d6e549","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        # boot instance from EBS image"},{"line_number":164,"context_line":"        instance \u003d self.create_server("},{"line_number":165,"context_line":"            image\u003dimage[\u0027id\u0027])"},{"line_number":166,"context_line":"        # just ensure that instance booted"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # delete instance"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_d14861ce","line":165,"updated":"2016-01-15 09:16:24.000000000","message":"ditto.","commit_id":"8999e936fd28c332cf242af997634b9ab19f5242"}]}