)]}'
{"tempest/api/identity/base.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"ec102b723940b505dcf6253292c9dc1e3ac947d7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        cls.non_admin_tenants_client \u003d cls.os.tenants_public_client"},{"line_number":79,"context_line":"        cls.non_admin_roles_client \u003d cls.os.roles_public_client"},{"line_number":80,"context_line":"        cls.non_admin_users_client \u003d cls.os.users_public_client"},{"line_number":81,"context_line":"        cls.non_admin_services_client \u003d cls.os.services_v2_public_client"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_dbc46960","line":81,"updated":"2016-01-13 16:20:38.000000000","message":"Is this client used anywhere?","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"df0040c749e326fb412b30f9f7fa6144ee559a2d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        cls.non_admin_tenants_client \u003d cls.os.tenants_public_client"},{"line_number":79,"context_line":"        cls.non_admin_roles_client \u003d cls.os.roles_public_client"},{"line_number":80,"context_line":"        cls.non_admin_users_client \u003d cls.os.users_public_client"},{"line_number":81,"context_line":"        cls.non_admin_services_client \u003d cls.os.services_v2_public_client"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_b11e0d6e","line":81,"in_reply_to":"da6ed579_dbc46960","updated":"2016-01-15 09:19:15.000000000","message":"Done","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"ec102b723940b505dcf6253292c9dc1e3ac947d7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        cls.users_client \u003d cls.os_adm.users_client"},{"line_number":107,"context_line":"        cls.non_admin_users_client \u003d cls.os.users_client"},{"line_number":108,"context_line":"        cls.services_client \u003d cls.os_admin.services_v2_client"},{"line_number":109,"context_line":"        cls.non_admin_services_client \u003d cls.os.services_v2_client"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_3baca59f","line":109,"updated":"2016-01-13 16:20:38.000000000","message":"ditto.","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"df0040c749e326fb412b30f9f7fa6144ee559a2d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        cls.users_client \u003d cls.os_adm.users_client"},{"line_number":107,"context_line":"        cls.non_admin_users_client \u003d cls.os.users_client"},{"line_number":108,"context_line":"        cls.services_client \u003d cls.os_admin.services_v2_client"},{"line_number":109,"context_line":"        cls.non_admin_services_client \u003d cls.os.services_v2_client"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_d12e21a4","line":109,"in_reply_to":"da6ed579_3baca59f","updated":"2016-01-15 09:19:15.000000000","message":"Done","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2b6092a33e20d1fe5b2c43647b132d8249297088","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            self.tenants_client \u003d tenants_client"},{"line_number":205,"context_line":"            self.roles_client \u003d roles_client"},{"line_number":206,"context_line":"            self.users_client \u003d users_client"},{"line_number":207,"context_line":"            self.services_client \u003d services_client"},{"line_number":208,"context_line":"            self.users \u003d []"},{"line_number":209,"context_line":"            self.tenants \u003d []"},{"line_number":210,"context_line":"            self.roles \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_5b72b9ae","line":207,"updated":"2016-01-13 16:15:55.000000000","message":"I think we shouldn\u0027t add services client here.","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"df0040c749e326fb412b30f9f7fa6144ee559a2d","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            self.tenants_client \u003d tenants_client"},{"line_number":205,"context_line":"            self.roles_client \u003d roles_client"},{"line_number":206,"context_line":"            self.users_client \u003d users_client"},{"line_number":207,"context_line":"            self.services_client \u003d services_client"},{"line_number":208,"context_line":"            self.users \u003d []"},{"line_number":209,"context_line":"            self.tenants \u003d []"},{"line_number":210,"context_line":"            self.roles \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_713df5db","line":207,"in_reply_to":"da6ed579_5b72b9ae","updated":"2016-01-15 09:19:15.000000000","message":"Done","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"c05bea14e8bf1fa30069516830452579f6332e4d","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            self.tenants_client \u003d tenants_client"},{"line_number":205,"context_line":"            self.roles_client \u003d roles_client"},{"line_number":206,"context_line":"            self.users_client \u003d users_client"},{"line_number":207,"context_line":"            self.services_client \u003d services_client"},{"line_number":208,"context_line":"            self.users \u003d []"},{"line_number":209,"context_line":"            self.tenants \u003d []"},{"line_number":210,"context_line":"            self.roles \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_6fd6a1f2","line":207,"in_reply_to":"da6ed579_5b72b9ae","updated":"2016-01-14 12:49:55.000000000","message":"Services client is not used to generate test data. Why do you add it here?","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"df0040c749e326fb412b30f9f7fa6144ee559a2d","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            self.tenants_client \u003d tenants_client"},{"line_number":205,"context_line":"            self.roles_client \u003d roles_client"},{"line_number":206,"context_line":"            self.users_client \u003d users_client"},{"line_number":207,"context_line":"            self.services_client \u003d services_client"},{"line_number":208,"context_line":"            self.users \u003d []"},{"line_number":209,"context_line":"            self.tenants \u003d []"},{"line_number":210,"context_line":"            self.roles \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_1129199e","line":207,"in_reply_to":"da6ed579_6fd6a1f2","updated":"2016-01-15 09:19:15.000000000","message":"Done","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"}],"tempest/clients.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"beb52ada330f03815a0865c9bf4ccd60d767f45b","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                                               **params_v2_public)"},{"line_number":505,"context_line":"        self.users_public_client \u003d UsersClient(self.auth_provider,"},{"line_number":506,"context_line":"                                               **params_v2_public)"},{"line_number":507,"context_line":"        self.services_v2_public_client \u003d ServicesV2Client(self.auth_provider,"},{"line_number":508,"context_line":"                                                          **params_v2_public)"},{"line_number":509,"context_line":"        params_v3 \u003d params.copy()"},{"line_number":510,"context_line":"        params_v3[\u0027endpoint_type\u0027] \u003d CONF.identity.v3_endpoint_type"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_21492f8c","line":507,"updated":"2016-01-19 02:56:01.000000000","message":"All changes in this patch look good to me, but I don\u0027t understand why you create services_v2_public_client that is not used anywhere? :)","commit_id":"79cd58e5f2d1a0e8f5a42102aba185c900c42e44"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fc28e98579ec0f21ed1b547814f0dea8f1031430","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                                               **params_v2_public)"},{"line_number":505,"context_line":"        self.users_public_client \u003d UsersClient(self.auth_provider,"},{"line_number":506,"context_line":"                                               **params_v2_public)"},{"line_number":507,"context_line":"        self.services_v2_public_client \u003d ServicesV2Client(self.auth_provider,"},{"line_number":508,"context_line":"                                                          **params_v2_public)"},{"line_number":509,"context_line":"        params_v3 \u003d params.copy()"},{"line_number":510,"context_line":"        params_v3[\u0027endpoint_type\u0027] \u003d CONF.identity.v3_endpoint_type"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_cae2a39f","line":507,"in_reply_to":"ba63e191_21492f8c","updated":"2016-01-19 08:10:15.000000000","message":"Done","commit_id":"79cd58e5f2d1a0e8f5a42102aba185c900c42e44"}],"tempest/common/cred_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"18a41b206f7fd910fb3cb62483e0a712c2a2dd58","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_2255601c","line":43,"updated":"2016-01-13 14:19:23.000000000","message":"Why do we need to add this \"or identity_client\" everywhere ? It makes stuff more complicated because then you never know what the \"self.services_client\" variable holds...","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"d80f3cb11455278d5001fdbdeff9dad7795980e6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_df2d0896","line":43,"in_reply_to":"da6ed579_1bda0179","updated":"2016-01-14 10:06:37.000000000","message":"As it states in the docstring, this class is used as a single interface for managing credentials, so it\u0027s also being called by another files, not only here. That\u0027s why it\u0027d be needed.","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2b6092a33e20d1fe5b2c43647b132d8249297088","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_1bda0179","line":43,"in_reply_to":"da6ed579_2255601c","updated":"2016-01-13 16:15:55.000000000","message":"It looks like this variable is redundant here at all. It is not used anywhere.","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"d80f3cb11455278d5001fdbdeff9dad7795980e6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_5f411837","line":43,"in_reply_to":"da6ed579_2255601c","updated":"2016-01-14 10:06:37.000000000","message":"when I started drafting this, andreaf pointed out that this would be needed until the v3 clients would be separated too, so this will be removed then.","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"196559485717fb9ad1cbde76d230d344ba7c15f7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_7a398af1","line":43,"in_reply_to":"da6ed579_3a8c72d9","updated":"2016-01-14 10:49:55.000000000","message":"This class acts as a wrapper for both kind of clients so if we remove that and it gets a v3 client it\u0027ll break. When the V3 keystone is split we\u0027ll be able to remove those as well.","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"9e3a681a4dc0e5fe13152d900c0595c6260d2a4d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_3a8c72d9","line":43,"in_reply_to":"da6ed579_df2d0896","updated":"2016-01-14 10:43:00.000000000","message":"Hm, OK. But I don\u0027t understand how it is related to V3 clients. Will it be used by V3 clients in the future?","commit_id":"1029ad6ecca956f3f35d1411b8d1edf31ba0c331"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"247f57ef752b88e6f35efd1f25a1829891f772b9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_7d16d6a8","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":65},"updated":"2016-01-18 03:20:23.000000000","message":"I do not think we need to add service client here.\n\nThese client are used on creating cred in case of dynamic cred and Currently no services are managed through these client and seems not to be in future too.\n\nLet\u0027s not add extra clients here.","commit_id":"f335d54356dd1e00510b6c930e26cf6ba1325ea9"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"525d179311634f87cd196a6feab0d9946b430949","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.projects_client \u003d projects_client or identity_client"},{"line_number":41,"context_line":"        self.roles_client \u003d roles_client or identity_client"},{"line_number":42,"context_line":"        self.users_client \u003d users_client or identity_client"},{"line_number":43,"context_line":"        self.services_client \u003d services_client or identity_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":46,"context_line":"        user \u003d self.users_client.create_user("}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_c78cc837","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":65},"in_reply_to":"da6ed579_7d16d6a8","updated":"2016-01-18 08:09:33.000000000","message":"Done","commit_id":"f335d54356dd1e00510b6c930e26cf6ba1325ea9"}],"tempest/common/dynamic_creds.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"247f57ef752b88e6f35efd1f25a1829891f772b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"da6ed579_9d762a05","updated":"2016-01-18 03:20:23.000000000","message":"Ditto. We should not add service client here as there is no usage in dynamic cred.\n\nAll services should be created and dynamic cred should be only responsible to create projects and user etc not  services.","commit_id":"f335d54356dd1e00510b6c930e26cf6ba1325ea9"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"525d179311634f87cd196a6feab0d9946b430949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"da6ed579_277cc41f","in_reply_to":"da6ed579_9d762a05","updated":"2016-01-18 08:09:33.000000000","message":"Done","commit_id":"f335d54356dd1e00510b6c930e26cf6ba1325ea9"}]}