)]}'
{"tempest/api/compute/images/test_image_metadata.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"046b636e9280bfa2da0882ab2e7ceeaee724b424","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(ImagesMetadataTestJSON, cls).setup_clients()"},{"line_number":39,"context_line":"        cls.glance_client \u003d cls.os.image_client"},{"line_number":40,"context_line":"        cls.client \u003d cls.compute_images_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a2863211","line":40,"updated":"2016-01-04 11:39:52.000000000","message":"Do we really need this variable ? I mean, can\u0027t just call cls.compute_images_client direclty, why an alias ?","commit_id":"a4b9b07c382554f889db1d7b0ba0ae6718e739be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eb63e32fb7c0545fa6ef19f14bf998b42a65bd90","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(ImagesMetadataTestJSON, cls).setup_clients()"},{"line_number":39,"context_line":"        cls.glance_client \u003d cls.os.image_client"},{"line_number":40,"context_line":"        cls.client \u003d cls.compute_images_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a5bfc05f","line":40,"in_reply_to":"fa69d971_a2863211","updated":"2016-01-06 05:42:04.000000000","message":"yes nice point. We can do but those will be unrelated to this patch scope so let\u0027s do those cleanup later.","commit_id":"a4b9b07c382554f889db1d7b0ba0ae6718e739be"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a120c4e420df9f3e110c78a70e11a4edf32f6de3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(ImagesMetadataTestJSON, cls).setup_clients()"},{"line_number":39,"context_line":"        cls.glance_client \u003d cls.os.image_client"},{"line_number":40,"context_line":"        cls.client \u003d cls.compute_images_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_c5e17e2b","line":40,"updated":"2016-01-06 15:08:06.000000000","message":"The point of this patch is to rename variable so that we know, just reading the variable name, whether we deal with a glance_client or a compute_image_client.\n\nHere, with just \"cls.client\", we don\u0027t know for sure.","commit_id":"ae76c1208fea7674742f61f45c73becace6cbdc1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a02c74a8f077737cd1d1ae21d1b3173195b2e2db","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(ImagesMetadataTestJSON, cls).setup_clients()"},{"line_number":39,"context_line":"        cls.glance_client \u003d cls.os.image_client"},{"line_number":40,"context_line":"        cls.client \u003d cls.compute_images_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_d65b5784","line":40,"in_reply_to":"fa69d971_6fbdfa00","updated":"2016-01-07 07:00:51.000000000","message":"+1 for cleaning up on the other patches if necessary.","commit_id":"ae76c1208fea7674742f61f45c73becace6cbdc1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1b2b186faa1392fcadb8bee64c5ed94d1a8f2a25","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setup_clients(cls):"},{"line_number":38,"context_line":"        super(ImagesMetadataTestJSON, cls).setup_clients()"},{"line_number":39,"context_line":"        cls.glance_client \u003d cls.os.image_client"},{"line_number":40,"context_line":"        cls.client \u003d cls.compute_images_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_6fbdfa00","line":40,"in_reply_to":"fa69d971_c5e17e2b","updated":"2016-01-07 00:33:36.000000000","message":"Yea, and its in many files. On client manager refactoring, those will be much more cleaner.","commit_id":"ae76c1208fea7674742f61f45c73becace6cbdc1"}],"tempest/cmd/javelin.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"1c5ce9a3ddebd62e81797927de9a39c8024f6d7c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                                  **object_storage_params)"},{"line_number":228,"context_line":"        self.containers \u003d container_client.ContainerClient("},{"line_number":229,"context_line":"            _auth, **object_storage_params)"},{"line_number":230,"context_line":"        self.compute_images \u003d images_client.ImagesClientV2("},{"line_number":231,"context_line":"            _auth,"},{"line_number":232,"context_line":"            CONF.image.catalog_type,"},{"line_number":233,"context_line":"            CONF.image.region or CONF.identity.region,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_18821f95","line":230,"updated":"2015-12-24 11:39:42.000000000","message":"This is incorrect. \u0027images_client\u0027 is a Glance client. See L133.","commit_id":"a4b9b07c382554f889db1d7b0ba0ae6718e739be"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"046b636e9280bfa2da0882ab2e7ceeaee724b424","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                                  **object_storage_params)"},{"line_number":228,"context_line":"        self.containers \u003d container_client.ContainerClient("},{"line_number":229,"context_line":"            _auth, **object_storage_params)"},{"line_number":230,"context_line":"        self.compute_images \u003d images_client.ImagesClientV2("},{"line_number":231,"context_line":"            _auth,"},{"line_number":232,"context_line":"            CONF.image.catalog_type,"},{"line_number":233,"context_line":"            CONF.image.region or CONF.identity.region,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_02f4de83","line":230,"in_reply_to":"1a7b0d38_18821f95","updated":"2016-01-04 11:39:52.000000000","message":"I agree with Yaroslav.","commit_id":"a4b9b07c382554f889db1d7b0ba0ae6718e739be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eb63e32fb7c0545fa6ef19f14bf998b42a65bd90","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                                  **object_storage_params)"},{"line_number":228,"context_line":"        self.containers \u003d container_client.ContainerClient("},{"line_number":229,"context_line":"            _auth, **object_storage_params)"},{"line_number":230,"context_line":"        self.compute_images \u003d images_client.ImagesClientV2("},{"line_number":231,"context_line":"            _auth,"},{"line_number":232,"context_line":"            CONF.image.catalog_type,"},{"line_number":233,"context_line":"            CONF.image.region or CONF.identity.region,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_656c6808","line":230,"in_reply_to":"fa69d971_02f4de83","updated":"2016-01-06 05:42:04.000000000","message":"ops nice catch. Thanks","commit_id":"a4b9b07c382554f889db1d7b0ba0ae6718e739be"}]}