)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"73f26dda4970b16784def7bcf697e85b90a3b98a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        name \u003d data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if \u0027imageRef\u0027 not in kwargs:"},{"line_number":62,"context_line":"        kwargs.update({\u0027imageRef\u0027: CONF.compute.image_ref})"},{"line_number":63,"context_line":"    if \u0027flavorRef\u0027 not in kwargs:"},{"line_number":64,"context_line":"        kwargs.update({\u0027flavorRef\u0027: CONF.compute.flavor_ref})"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_4213845b","line":62,"updated":"2016-01-05 10:17:01.000000000","message":"There\u0027s no reason to call update() here. You should do\n\nkwargs[\u0027imageRef\u0027] \u003d CONF.compute.image_ref\n\nI mean why do a method call ? Why build ann intermediary dict with a single entry ?","commit_id":"858ae7c940793ae3d56e8fecb6c91b59f68d633d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"908eb8fa12b6b181a7c39052ebea9fed91b9485c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        name \u003d data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if \u0027imageRef\u0027 not in kwargs:"},{"line_number":62,"context_line":"        kwargs.update({\u0027imageRef\u0027: CONF.compute.image_ref})"},{"line_number":63,"context_line":"    if \u0027flavorRef\u0027 not in kwargs:"},{"line_number":64,"context_line":"        kwargs.update({\u0027flavorRef\u0027: CONF.compute.flavor_ref})"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_e8b82f2c","line":62,"in_reply_to":"fa69d971_22a690ae","updated":"2016-01-06 05:47:00.000000000","message":"Done.\n\n@Joseph, yea we can do that but again that will be confusing. I think now it should be fine.","commit_id":"858ae7c940793ae3d56e8fecb6c91b59f68d633d"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"5f6e960979c6ba3b33d8e94615a3febef31f632a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        name \u003d data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if \u0027imageRef\u0027 not in kwargs:"},{"line_number":62,"context_line":"        kwargs.update({\u0027imageRef\u0027: CONF.compute.image_ref})"},{"line_number":63,"context_line":"    if \u0027flavorRef\u0027 not in kwargs:"},{"line_number":64,"context_line":"        kwargs.update({\u0027flavorRef\u0027: CONF.compute.flavor_ref})"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_22a690ae","line":62,"in_reply_to":"fa69d971_4213845b","updated":"2016-01-05 10:31:19.000000000","message":"Actually, I think the best is to keep what I wrote and just replace flavor with flavorRef and image_id with imageRef.","commit_id":"858ae7c940793ae3d56e8fecb6c91b59f68d633d"},{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"04714895f2aaa1d2e1ae2e219e6b8b0bdbe19c1e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        name \u003d data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if \u0027imageRef\u0027 not in kwargs:"},{"line_number":62,"context_line":"        kwargs[\u0027imageRef\u0027] \u003d CONF.compute.image_ref"},{"line_number":63,"context_line":"    if \u0027flavorRef\u0027 not in kwargs:"},{"line_number":64,"context_line":"        kwargs[\u0027flavorRef\u0027] \u003d CONF.compute.flavor_ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_4781938e","line":61,"updated":"2016-01-08 11:22:21.000000000","message":"When you\u0027ll rebase the change, you\u0027ll see that kwargs.pop is used for the \u0027name\u0027 variable now. So for consistency, that would be good to have kwargs.pop for imageRef and flavorRef too.","commit_id":"d258e763934eebdf3a925bc2aea61a83041eff13"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5d1127404b716acc599924dbcd7fe947748305c9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        name \u003d data_utils.rand_name(__name__ + \"-instance\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if \u0027imageRef\u0027 not in kwargs:"},{"line_number":62,"context_line":"        kwargs[\u0027imageRef\u0027] \u003d CONF.compute.image_ref"},{"line_number":63,"context_line":"    if \u0027flavorRef\u0027 not in kwargs:"},{"line_number":64,"context_line":"        kwargs[\u0027flavorRef\u0027] \u003d CONF.compute.flavor_ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_e8b96bcc","line":61,"in_reply_to":"fa69d971_4781938e","updated":"2016-01-08 14:56:45.000000000","message":"As far as I understand Joseph is trying to say the following:\n\n    ...\n    name \u003d kwargs.pop(\u0027name\u0027, data_utils.rand_name(__name__ + \"-instance\"))\n    image_ref \u003d kwargs.pop(\u0027imageRef\u0027, CONF.compute.image_ref)\n    flavor_ref \u003d kwargs.pop(\u0027flavorRef\u0027, CONF.compute.flavor_ref)\n    ...","commit_id":"d258e763934eebdf3a925bc2aea61a83041eff13"}]}
