)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"dddfb0d975c27d4d6344c0c32796ea766e07679c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kwargs \u003d fixed_network.set_networks_kwarg("},{"line_number":60,"context_line":"        tenant_network, kwargs) or {}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    multiple_create_request \u003d (kwargs.get(\u0027min_count\u0027) \u003e 1"},{"line_number":63,"context_line":"                               or kwargs.get(\u0027max_count\u0027) \u003e 1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if CONF.validation.run_validation and validatable:"},{"line_number":66,"context_line":"        # As a first implementation, multiple pingable or sshable servers will"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_aa2da347","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":62},"updated":"2015-12-25 01:48:41.000000000","message":"This works enough as our expectation, but how about\n\n ... kwargs.get(\u0027min_count\u0027, 0) \u003e 1\n or kwargs.get(\u0027max_count\u0027, 0) \u003e 1)\n\nfor safe code?","commit_id":"f4c462c4d2188301b108a9a7d8bdb65d74d3f1e2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8dcd0df3f6484638bf0c9985f1acea3060fecc27","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kwargs \u003d fixed_network.set_networks_kwarg("},{"line_number":60,"context_line":"        tenant_network, kwargs) or {}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    multiple_create_request \u003d (kwargs.get(\u0027min_count\u0027, 0) \u003e 1"},{"line_number":63,"context_line":"                               or kwargs.get(\u0027max_count\u0027, 0) \u003e 1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if CONF.validation.run_validation and validatable:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_5f294536","line":62,"updated":"2016-01-08 17:43:39.000000000","message":"multiple_create_request \u003d max(kwargs.get(\u0027min_count\u0027), kwargs.get(\u0027max_count\u0027)) \u003e 1","commit_id":"b6d6f792b6be0c0d03bf763802ed38b5868b3a2d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ea65d8c91afdade6a07a569949445d6639207da4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kwargs \u003d fixed_network.set_networks_kwarg("},{"line_number":60,"context_line":"        tenant_network, kwargs) or {}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    multiple_create_request \u003d (kwargs.get(\u0027min_count\u0027, 0) \u003e 1"},{"line_number":63,"context_line":"                               or kwargs.get(\u0027max_count\u0027, 0) \u003e 1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if CONF.validation.run_validation and validatable:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_d983e301","line":62,"in_reply_to":"fa69d971_4e2415c4","updated":"2016-01-11 11:00:21.000000000","message":"It doesn\u0027t look fine to me. We work with a dynamic language, which brings some nice feature (such as doing the following comparison: None \u003e 1 or calling max(None, 1)) and we should use these features.\n\n\"There are lot of way to do the same.\" ---\u003e\u003e\u003e \"There should be one-- and preferably only one --obvious way to do it.\"","commit_id":"b6d6f792b6be0c0d03bf763802ed38b5868b3a2d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c16dfcce929db9beb59b0801ed647708c0a4488c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kwargs \u003d fixed_network.set_networks_kwarg("},{"line_number":60,"context_line":"        tenant_network, kwargs) or {}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    multiple_create_request \u003d (kwargs.get(\u0027min_count\u0027, 0) \u003e 1"},{"line_number":63,"context_line":"                               or kwargs.get(\u0027max_count\u0027, 0) \u003e 1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if CONF.validation.run_validation and validatable:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_4e2415c4","line":62,"in_reply_to":"fa69d971_5f294536","updated":"2016-01-11 01:55:40.000000000","message":"Yea, we can do that but current way also looks fine for me. There are lot of way to do the same.","commit_id":"b6d6f792b6be0c0d03bf763802ed38b5868b3a2d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a52d8412d77e85a2b015c089756b46d09b220c51","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kwargs \u003d fixed_network.set_networks_kwarg("},{"line_number":60,"context_line":"        tenant_network, kwargs) or {}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    multiple_create_request \u003d (kwargs.get(\u0027min_count\u0027, 0) \u003e 1"},{"line_number":63,"context_line":"                               or kwargs.get(\u0027max_count\u0027, 0) \u003e 1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if CONF.validation.run_validation and validatable:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_a6b0a444","line":62,"in_reply_to":"fa69d971_d983e301","updated":"2016-01-13 01:19:38.000000000","message":"Done","commit_id":"b6d6f792b6be0c0d03bf763802ed38b5868b3a2d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7f4924f79033452e1028d5b6b1cd1b42d209e7f2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    kwargs \u003d fixed_network.set_networks_kwarg("},{"line_number":56,"context_line":"        tenant_network, kwargs) or {}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    multiple_create_request \u003d (max(kwargs.get(\u0027min_count\u0027, 0),"},{"line_number":59,"context_line":"                                   kwargs.get(\u0027max_count\u0027, 0)) \u003e 1)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if CONF.validation.run_validation and validatable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_a2f710f4","line":58,"updated":"2016-01-13 14:06:44.000000000","message":"You didn\u0027t have to add \", 0\", the max() function is perfectly able to deal with None as a value.","commit_id":"4de44ae1cff54ef4dd2b1e26a92548ca61b9f741"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a1a49c3ca1dea80deebe4227134b85a4921fb57f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    kwargs \u003d fixed_network.set_networks_kwarg("},{"line_number":56,"context_line":"        tenant_network, kwargs) or {}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    multiple_create_request \u003d (max(kwargs.get(\u0027min_count\u0027, 0),"},{"line_number":59,"context_line":"                                   kwargs.get(\u0027max_count\u0027, 0)) \u003e 1)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if CONF.validation.run_validation and validatable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_4cc8a2a8","line":58,"in_reply_to":"da6ed579_a2f710f4","updated":"2016-01-14 03:33:00.000000000","message":"I prefer current code because we can clarify it without understanding max() internal behavior :)","commit_id":"4de44ae1cff54ef4dd2b1e26a92548ca61b9f741"}]}