)]}'
{"tempest/common/api_version_utils.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"21076bf2e5bcd477669fb77d1db02fb028162eec","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return max_version.get_string()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def assert_version_header_matches_request(api_microversion_header,"},{"line_number":75,"context_line":"                                          api_microversion,"},{"line_number":76,"context_line":"                                          response):"},{"line_number":77,"context_line":"    # Verify whether microversion header is present in response"},{"line_number":78,"context_line":"    # and with expected value."},{"line_number":79,"context_line":"    api_microversion_header \u003d api_microversion_header.lower()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_96ada98a","line":76,"range":{"start_line":74,"start_character":42,"end_line":76,"end_character":49},"updated":"2016-01-21 03:06:00.000000000","message":"docstring is necessary for these arguments because it is difficult to distinguish the difference between the first and the second based on these names only.\n\nHow about\n\n @param: api_microversion_header: Microversion header string like \"X-OpenStack-Nova-API-Version\"\n @param: api_microversion: Microversion number like \"2.10\"\n @param: response: ...","commit_id":"a8b9f354191b50ff761287c6e038cee4842ee9ea"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39fca665767143d98afcc72a45f68355f21c7710","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return max_version.get_string()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def assert_version_header_matches_request(api_microversion_header,"},{"line_number":75,"context_line":"                                          api_microversion,"},{"line_number":76,"context_line":"                                          response):"},{"line_number":77,"context_line":"    # Verify whether microversion header is present in response"},{"line_number":78,"context_line":"    # and with expected value."},{"line_number":79,"context_line":"    api_microversion_header \u003d api_microversion_header.lower()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cfa61fc1","line":76,"range":{"start_line":74,"start_character":42,"end_line":76,"end_character":49},"in_reply_to":"9a68dd71_96ada98a","updated":"2016-01-21 07:53:49.000000000","message":"Done.","commit_id":"a8b9f354191b50ff761287c6e038cee4842ee9ea"}],"tempest/services/base_microversion_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"21076bf2e5bcd477669fb77d1db02fb028162eec","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    If api_microversion is not set on service client then API request will be"},{"line_number":26,"context_line":"    normal request without microversion."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    :param auth_provider: an auth provider object used to wrap requests in auth"},{"line_number":29,"context_line":"    :param str service: The service name to use for the catalog lookup"},{"line_number":30,"context_line":"    :param str region: The region to use for the catalog lookup"},{"line_number":31,"context_line":"    :param str api_microversion_header: The microversion header name to use for"},{"line_number":32,"context_line":"                                        sending API request with microversion"},{"line_number":33,"context_line":"    :param str endpoint_type: The endpoint type to use for the catalog lookup"},{"line_number":34,"context_line":"    :param int build_interval: Time in seconds between to status checks in"},{"line_number":35,"context_line":"                               wait loops"},{"line_number":36,"context_line":"    :param int build_timeout: Timeout in seconds to wait for a wait operation."},{"line_number":37,"context_line":"    :param bool disable_ssl_certificate_validation: Set to true to disable ssl"},{"line_number":38,"context_line":"                                                    certificate validation"},{"line_number":39,"context_line":"    :param str ca_certs: File containing the CA Bundle to use in verifying a"},{"line_number":40,"context_line":"                         TLS server cert"},{"line_number":41,"context_line":"    :param str trace_request: Regex to use for specifying logging the entirety"},{"line_number":42,"context_line":"                              of the request and response payload"},{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":45,"context_line":"                 api_microversion_header, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_76659543","line":42,"range":{"start_line":28,"start_character":0,"end_line":42,"end_character":65},"updated":"2016-01-21 03:06:00.000000000","message":"How about moving this docstring into __init__() and merging original RestClient\u0027s args into kwargs for avoiding duplicated maintenance against original RestClient\u0027s ones?","commit_id":"a8b9f354191b50ff761287c6e038cee4842ee9ea"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39fca665767143d98afcc72a45f68355f21c7710","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    If api_microversion is not set on service client then API request will be"},{"line_number":26,"context_line":"    normal request without microversion."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    :param auth_provider: an auth provider object used to wrap requests in auth"},{"line_number":29,"context_line":"    :param str service: The service name to use for the catalog lookup"},{"line_number":30,"context_line":"    :param str region: The region to use for the catalog lookup"},{"line_number":31,"context_line":"    :param str api_microversion_header: The microversion header name to use for"},{"line_number":32,"context_line":"                                        sending API request with microversion"},{"line_number":33,"context_line":"    :param str endpoint_type: The endpoint type to use for the catalog lookup"},{"line_number":34,"context_line":"    :param int build_interval: Time in seconds between to status checks in"},{"line_number":35,"context_line":"                               wait loops"},{"line_number":36,"context_line":"    :param int build_timeout: Timeout in seconds to wait for a wait operation."},{"line_number":37,"context_line":"    :param bool disable_ssl_certificate_validation: Set to true to disable ssl"},{"line_number":38,"context_line":"                                                    certificate validation"},{"line_number":39,"context_line":"    :param str ca_certs: File containing the CA Bundle to use in verifying a"},{"line_number":40,"context_line":"                         TLS server cert"},{"line_number":41,"context_line":"    :param str trace_request: Regex to use for specifying logging the entirety"},{"line_number":42,"context_line":"                              of the request and response payload"},{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":45,"context_line":"                 api_microversion_header, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_0fc67767","line":42,"range":{"start_line":28,"start_character":0,"end_line":42,"end_character":65},"in_reply_to":"9a68dd71_76659543","updated":"2016-01-21 07:53:49.000000000","message":"Nice point. Done","commit_id":"a8b9f354191b50ff761287c6e038cee4842ee9ea"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d21b96898419c8affc842eab4f323d52fb8084b1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            auth_provider, service, region, **kwargs)"},{"line_number":33,"context_line":"        self.api_microversion_header_name \u003d api_microversion_header_name"},{"line_number":34,"context_line":"        self.api_microversion \u003d None"},{"line_number":35,"context_line":"    \"\"\"Base Microversion Client __init__"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    :param auth_provider: an auth provider object used to wrap requests in auth"},{"line_number":38,"context_line":"    :param str service: The service name to use for the catalog lookup"},{"line_number":39,"context_line":"    :param str region: The region to use for the catalog lookup"},{"line_number":40,"context_line":"    :param str api_microversion_header_name: The microversion header name to"},{"line_number":41,"context_line":"                                             use for sending API request with"},{"line_number":42,"context_line":"                                             microversion"},{"line_number":43,"context_line":"    :param kwargs: kwargs required by rest_client.RestClient"},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    def get_headers(self):"},{"line_number":46,"context_line":"        headers \u003d super(BaseMicroversionClient, self).get_headers()"},{"line_number":47,"context_line":"        if self.api_microversion:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_acba9921","line":44,"range":{"start_line":35,"start_character":0,"end_line":44,"end_character":7},"updated":"2016-01-22 07:51:12.000000000","message":"This docstring should be put just after __init__().\n\nI mean the docstring needs to be moved to line 33.","commit_id":"9e15068c6d133276251f0633481c4ab590db6371"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1c84867ef85906c4dcbba3dbd6a3a61609f08269","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            auth_provider, service, region, **kwargs)"},{"line_number":33,"context_line":"        self.api_microversion_header_name \u003d api_microversion_header_name"},{"line_number":34,"context_line":"        self.api_microversion \u003d None"},{"line_number":35,"context_line":"    \"\"\"Base Microversion Client __init__"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    :param auth_provider: an auth provider object used to wrap requests in auth"},{"line_number":38,"context_line":"    :param str service: The service name to use for the catalog lookup"},{"line_number":39,"context_line":"    :param str region: The region to use for the catalog lookup"},{"line_number":40,"context_line":"    :param str api_microversion_header_name: The microversion header name to"},{"line_number":41,"context_line":"                                             use for sending API request with"},{"line_number":42,"context_line":"                                             microversion"},{"line_number":43,"context_line":"    :param kwargs: kwargs required by rest_client.RestClient"},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    def get_headers(self):"},{"line_number":46,"context_line":"        headers \u003d super(BaseMicroversionClient, self).get_headers()"},{"line_number":47,"context_line":"        if self.api_microversion:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_4cb43dd0","line":44,"range":{"start_line":35,"start_character":0,"end_line":44,"end_character":7},"in_reply_to":"9a68dd71_acba9921","updated":"2016-01-22 08:01:18.000000000","message":"opps Done.","commit_id":"9e15068c6d133276251f0633481c4ab590db6371"}],"tempest/services/compute/json/base_compute_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"21076bf2e5bcd477669fb77d1db02fb028162eec","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class BaseComputeClient(base_microversion_client.BaseMicroversionClient):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, auth_provider, service, region,"},{"line_number":24,"context_line":"                 api_microversion_header\u003d\u0027X-OpenStack-Nova-API-Version\u0027,"},{"line_number":25,"context_line":"                 **kwargs):"},{"line_number":26,"context_line":"        super(BaseComputeClient, self).__init__("},{"line_number":27,"context_line":"            auth_provider, service, region,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_b64b0db0","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":72},"updated":"2016-01-21 03:06:00.000000000","message":"smart way :)","commit_id":"a8b9f354191b50ff761287c6e038cee4842ee9ea"}]}