)]}'
{"tempest/tests/compute/test_quotas.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"017682c725edf7a8caa1be0874edd822e92f5bf9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                 \u0027fixed_ips\u0027: -1, \u0027key_pairs\u0027: 100,"},{"line_number":37,"context_line":"                                 \u0027injected_file_path_bytes\u0027: 255,"},{"line_number":38,"context_line":"                                 \u0027instances\u0027: 10, \u0027security_group_rules\u0027: 20,"},{"line_number":39,"context_line":"                                 \u0027cores\u0027: 20, \u0027security_groups\u0027: 10}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":42,"context_line":"    def test_get_quotas(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F7qA%3D","line":39,"updated":"2013-04-11 00:23:48.000000000","message":"Not a huge issue since it already exists for test_get_quotas, but I wonder if we should be hard coding values like this or if it should be sourced from a config file?","commit_id":"d977bba12a6fb8c9e353babddf72399e81994ce0"},{"author":{"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},"change_message_id":"92a6c6bb35136d45aa5d234b6270e30b9bc9aed1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                 \u0027fixed_ips\u0027: -1, \u0027key_pairs\u0027: 100,"},{"line_number":37,"context_line":"                                 \u0027injected_file_path_bytes\u0027: 255,"},{"line_number":38,"context_line":"                                 \u0027instances\u0027: 10, \u0027security_group_rules\u0027: 20,"},{"line_number":39,"context_line":"                                 \u0027cores\u0027: 20, \u0027security_groups\u0027: 10}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":42,"context_line":"    def test_get_quotas(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F7nE%3D","line":39,"in_reply_to":"AAAAOn%2F%2F7qA%3D","updated":"2013-04-11 01:19:11.000000000","message":"The value that I expect in this test, is defined in only setUpClass.","commit_id":"d977bba12a6fb8c9e353babddf72399e81994ce0"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"017682c725edf7a8caa1be0874edd822e92f5bf9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # User can get the default quota set for it\u0027s tenant"},{"line_number":61,"context_line":"        expected_quota_set \u003d self.default_quota_set.copy()"},{"line_number":62,"context_line":"        expected_quota_set[\u0027id\u0027] \u003d self.tenant_id"},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            resp, quota_set \u003d self.client.get_default_quota_set(self.tenant_id)"},{"line_number":65,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":66,"context_line":"            self.assertEqual(expected_quota_set, quota_set)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F7qE%3D","line":63,"updated":"2013-04-11 00:23:48.000000000","message":"I don\u0027t see why we need this try/except handling. If the assertions or the get_default_quota_set call raises an exception the test will fail anyway and we don\u0027t need the extra fail message.\n\nAlthough it wasn\u0027t introduced in this patch I think the same goes for test_get_quotas.","commit_id":"d977bba12a6fb8c9e353babddf72399e81994ce0"},{"author":{"_account_id":6761,"name":"leo-toyoda","email":"toyoda-reo@cnt.mxw.nes.nec.co.jp","username":"leo-toyoda"},"change_message_id":"92a6c6bb35136d45aa5d234b6270e30b9bc9aed1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # User can get the default quota set for it\u0027s tenant"},{"line_number":61,"context_line":"        expected_quota_set \u003d self.default_quota_set.copy()"},{"line_number":62,"context_line":"        expected_quota_set[\u0027id\u0027] \u003d self.tenant_id"},{"line_number":63,"context_line":"        try:"},{"line_number":64,"context_line":"            resp, quota_set \u003d self.client.get_default_quota_set(self.tenant_id)"},{"line_number":65,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":66,"context_line":"            self.assertEqual(expected_quota_set, quota_set)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F7nA%3D","line":63,"in_reply_to":"AAAAOn%2F%2F7qE%3D","updated":"2013-04-11 01:19:11.000000000","message":"Thanks for your comment. I remove try/except handling.","commit_id":"d977bba12a6fb8c9e353babddf72399e81994ce0"}]}