)]}'
{"tempest/api/network/test_security_groups.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"80d9c3946fdd085391aaf7ac19ab68a4147efe3c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                           remote_ip_prefix\u003dNone):"},{"line_number":42,"context_line":"        # Create Security Group rule with the input params and validate"},{"line_number":43,"context_line":"        # that SG rule is created with the same parameters."},{"line_number":44,"context_line":"        sec_group_rules_client \u003d self.security_group_rules_client"},{"line_number":45,"context_line":"        rule_create_body \u003d sec_group_rules_client.create_security_group_rule("},{"line_number":46,"context_line":"            security_group_id\u003dsg_id,"},{"line_number":47,"context_line":"            direction\u003ddirection,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_4320c39b","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":30},"updated":"2016-01-21 10:53:31.000000000","message":"nit: How about just client instead of sec_group_rules_client like the other places?","commit_id":"456d9ae44f159f1b5fbd44f549e0fe24ddc62b76"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5ad1f35749d9513d1f941a047b14f60a2426280","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                           remote_ip_prefix\u003dNone):"},{"line_number":42,"context_line":"        # Create Security Group rule with the input params and validate"},{"line_number":43,"context_line":"        # that SG rule is created with the same parameters."},{"line_number":44,"context_line":"        sec_group_rules_client \u003d self.security_group_rules_client"},{"line_number":45,"context_line":"        rule_create_body \u003d sec_group_rules_client.create_security_group_rule("},{"line_number":46,"context_line":"            security_group_id\u003dsg_id,"},{"line_number":47,"context_line":"            direction\u003ddirection,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_bde88911","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":30},"in_reply_to":"9a68dd71_4320c39b","updated":"2016-01-22 04:54:29.000000000","message":"yea, lets do it later if fixing same file.","commit_id":"456d9ae44f159f1b5fbd44f549e0fe24ddc62b76"}],"tempest/services/network/json/security_group_rules_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5fb028173328a967f0bf6b91dec3306d79616d1c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class SecurityGroupRulesClient(base.BaseNetworkClient):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def create_security_group_rule(self, **kwargs):"},{"line_number":19,"context_line":"        uri \u003d \u0027/security-group-rules\u0027"},{"line_number":20,"context_line":"        post_data \u003d {\u0027security_group_rule\u0027: kwargs}"},{"line_number":21,"context_line":"        return self.create_resource(uri, post_data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_3f6cdb07","line":18,"updated":"2016-01-17 17:10:47.000000000","message":"This could be \"def create_rule\"","commit_id":"456d9ae44f159f1b5fbd44f549e0fe24ddc62b76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"80d9c3946fdd085391aaf7ac19ab68a4147efe3c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class SecurityGroupRulesClient(base.BaseNetworkClient):"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    def create_security_group_rule(self, **kwargs):"},{"line_number":19,"context_line":"        uri \u003d \u0027/security-group-rules\u0027"},{"line_number":20,"context_line":"        post_data \u003d {\u0027security_group_rule\u0027: kwargs}"},{"line_number":21,"context_line":"        return self.create_resource(uri, post_data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_839b1bc9","line":18,"in_reply_to":"da6ed579_3f6cdb07","updated":"2016-01-21 10:53:31.000000000","message":"I don\u0027t think so because the other existing clients are based on resource name(/security-group-roules) like this patch.","commit_id":"456d9ae44f159f1b5fbd44f549e0fe24ddc62b76"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5fb028173328a967f0bf6b91dec3306d79616d1c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        post_data \u003d {\u0027security_group_rule\u0027: kwargs}"},{"line_number":21,"context_line":"        return self.create_resource(uri, post_data)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def show_security_group_rule(self, security_group_rule_id, **fields):"},{"line_number":24,"context_line":"        uri \u003d \u0027/security-group-rules/%s\u0027 % security_group_rule_id"},{"line_number":25,"context_line":"        return self.show_resource(uri, **fields)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_5f718fdf","line":23,"updated":"2016-01-17 17:10:47.000000000","message":"def show_rule","commit_id":"456d9ae44f159f1b5fbd44f549e0fe24ddc62b76"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5fb028173328a967f0bf6b91dec3306d79616d1c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        uri \u003d \u0027/security-group-rules/%s\u0027 % security_group_rule_id"},{"line_number":25,"context_line":"        return self.show_resource(uri, **fields)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def delete_security_group_rule(self, security_group_rule_id):"},{"line_number":28,"context_line":"        uri \u003d \u0027/security-group-rules/%s\u0027 % security_group_rule_id"},{"line_number":29,"context_line":"        return self.delete_resource(uri)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_ff7643d7","line":27,"updated":"2016-01-17 17:10:47.000000000","message":"same","commit_id":"456d9ae44f159f1b5fbd44f549e0fe24ddc62b76"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5fb028173328a967f0bf6b91dec3306d79616d1c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        uri \u003d \u0027/security-group-rules/%s\u0027 % security_group_rule_id"},{"line_number":29,"context_line":"        return self.delete_resource(uri)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list_security_group_rules(self, **filters):"},{"line_number":32,"context_line":"        uri \u003d \u0027/security-group-rules\u0027"},{"line_number":33,"context_line":"        return self.list_resources(uri, **filters)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_1f7477cd","line":31,"updated":"2016-01-17 17:10:47.000000000","message":"same","commit_id":"456d9ae44f159f1b5fbd44f549e0fe24ddc62b76"}]}