)]}'
{"tempest/api/identity/base.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8cd5b35e827a6a564b0fff96f63338288f154b6f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    def setup_test_domain(self):"},{"line_number":303,"context_line":"        \"\"\"Set up a test domain.\"\"\""},{"line_number":304,"context_line":"        self.test_domain \u003d data_utils.rand_name(\u0027test_domain\u0027)"},{"line_number":305,"context_line":"        self.test_description \u003d data_utils.rand_name(\u0027desc\u0027)"},{"line_number":306,"context_line":"        self.domain \u003d self.client.create_domain("},{"line_number":307,"context_line":"            name\u003dself.test_domain,"},{"line_number":308,"context_line":"            description\u003dself.test_description)[\u0027domain\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_75892bca","line":305,"updated":"2016-01-20 15:58:51.000000000","message":"This variable should be named \"test_domain_description\" because \"test_description\" is the variable for the description of the project or tenant.","commit_id":"3e2fe7523fc66e94650ad0666f286e2235a03e84"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"31858cf0008d81fb1e82ace7ac1072c10112ab66","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    def setup_test_domain(self):"},{"line_number":303,"context_line":"        \"\"\"Set up a test domain.\"\"\""},{"line_number":304,"context_line":"        self.test_domain \u003d data_utils.rand_name(\u0027test_domain\u0027)"},{"line_number":305,"context_line":"        self.test_description \u003d data_utils.rand_name(\u0027desc\u0027)"},{"line_number":306,"context_line":"        self.domain \u003d self.client.create_domain("},{"line_number":307,"context_line":"            name\u003dself.test_domain,"},{"line_number":308,"context_line":"            description\u003dself.test_description)[\u0027domain\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_f9e195ff","line":305,"in_reply_to":"9a68dd71_75892bca","updated":"2016-01-20 16:05:10.000000000","message":"Yep, you are right. Thanks! Will fix :)","commit_id":"3e2fe7523fc66e94650ad0666f286e2235a03e84"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8dd208baa70f43723d2b18887fe50c1486ab5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.users_client \u003d users_client or client"},{"line_number":205,"context_line":"        self.roles_client \u003d roles_client or client"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self.test_user \u003d \u0027\u0027"},{"line_number":208,"context_line":"        self.test_password \u003d \u0027\u0027"},{"line_number":209,"context_line":"        self.test_tenant \u003d \u0027\u0027"},{"line_number":210,"context_line":"        self.test_project \u003d \u0027\u0027"},{"line_number":211,"context_line":"        self.test_role \u003d \u0027\u0027"},{"line_number":212,"context_line":"        self.test_email \u003d \u0027\u0027"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        self.user \u003d None"},{"line_number":215,"context_line":"        self.tenant \u003d None"},{"line_number":216,"context_line":"        self.project \u003d None"},{"line_number":217,"context_line":"        self.role \u003d None"},{"line_number":218,"context_line":"        self.domain \u003d None"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        self.users \u003d []"},{"line_number":221,"context_line":"        self.tenants \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_0d48f5cb","line":218,"range":{"start_line":207,"start_character":0,"end_line":218,"end_character":26},"updated":"2016-01-26 08:15:44.000000000","message":"self.test_user and self.user are confusing and redundant. And email too. For more cleanup can we keep only- \n\n        self.user \u003d None\n        self.tenant \u003d None\n        self.project \u003d None\n        self.role \u003d None\n        self.domain \u003d None\n        self.user_password \u003d None\n\nuser_password can be stored other all info can be fetched from self.user\n\nSame for tenant, projects and roles.","commit_id":"2c2f036cce58524cd7395623e4887719fe38596d"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"e19da435ec5e68b29ada5dd14e1bac9b5f249cf2","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.users_client \u003d users_client or client"},{"line_number":205,"context_line":"        self.roles_client \u003d roles_client or client"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self.test_user \u003d \u0027\u0027"},{"line_number":208,"context_line":"        self.test_password \u003d \u0027\u0027"},{"line_number":209,"context_line":"        self.test_tenant \u003d \u0027\u0027"},{"line_number":210,"context_line":"        self.test_project \u003d \u0027\u0027"},{"line_number":211,"context_line":"        self.test_role \u003d \u0027\u0027"},{"line_number":212,"context_line":"        self.test_email \u003d \u0027\u0027"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        self.user \u003d None"},{"line_number":215,"context_line":"        self.tenant \u003d None"},{"line_number":216,"context_line":"        self.project \u003d None"},{"line_number":217,"context_line":"        self.role \u003d None"},{"line_number":218,"context_line":"        self.domain \u003d None"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        self.users \u003d []"},{"line_number":221,"context_line":"        self.tenants \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_37088428","line":218,"range":{"start_line":207,"start_character":0,"end_line":218,"end_character":26},"in_reply_to":"9a68dd71_0d48f5cb","updated":"2016-01-26 17:09:17.000000000","message":"Ghanshyam, I would prefer address you suggestions in another patch for more easy review. If you don\u0027t mind, of course :)","commit_id":"2c2f036cce58524cd7395623e4887719fe38596d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2a0bfbdc1785e4163e24599a8bef36f3004a020","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.users_client \u003d users_client or client"},{"line_number":205,"context_line":"        self.roles_client \u003d roles_client or client"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        self.test_user \u003d \u0027\u0027"},{"line_number":208,"context_line":"        self.test_password \u003d \u0027\u0027"},{"line_number":209,"context_line":"        self.test_tenant \u003d \u0027\u0027"},{"line_number":210,"context_line":"        self.test_project \u003d \u0027\u0027"},{"line_number":211,"context_line":"        self.test_role \u003d \u0027\u0027"},{"line_number":212,"context_line":"        self.test_email \u003d \u0027\u0027"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        self.user \u003d None"},{"line_number":215,"context_line":"        self.tenant \u003d None"},{"line_number":216,"context_line":"        self.project \u003d None"},{"line_number":217,"context_line":"        self.role \u003d None"},{"line_number":218,"context_line":"        self.domain \u003d None"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        self.users \u003d []"},{"line_number":221,"context_line":"        self.tenants \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_a32adf7c","line":218,"range":{"start_line":207,"start_character":0,"end_line":218,"end_character":26},"in_reply_to":"9a68dd71_37088428","updated":"2016-01-27 07:12:21.000000000","message":"Sure, I trust you to see follow up patch soon :)","commit_id":"2c2f036cce58524cd7395623e4887719fe38596d"}]}