)]}'
{"tempest/api/orchestration/stacks/test_neutron_resources.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"77605c6d414bd2826ad27e1379c11b20b9c4d089","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def setup_credentials(cls):"},{"line_number":39,"context_line":"        cls.set_network_resources()"},{"line_number":40,"context_line":"        super(NeutronResourcesTestJSON, cls).setup_credentials()"},{"line_number":41,"context_line":"        cls.os \u003d cls.get_client_manager()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_faab711b","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":41},"updated":"2016-01-21 22:55:47.000000000","message":"This line isn\u0027t needed. The base test class handles this automatically. All you need to do is set the class level credentials attribute, which the heat base test class does already: https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L28\n\nSo unless you need more than a regular user for this test you don\u0027t need to do anything","commit_id":"400c853760db91a4d0df25136d058cdf1e964225"},{"author":{"_account_id":19050,"name":"Johan Pas","email":"j20012@outlook.com","username":"jpas"},"change_message_id":"f3215d3ef154f149a35f18363fff0429edef847f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def setup_credentials(cls):"},{"line_number":39,"context_line":"        cls.set_network_resources()"},{"line_number":40,"context_line":"        super(NeutronResourcesTestJSON, cls).setup_credentials()"},{"line_number":41,"context_line":"        cls.os \u003d cls.get_client_manager()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_45a502a0","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":41},"in_reply_to":"9a68dd71_faab711b","updated":"2016-01-21 23:34:28.000000000","message":"If I understood correctly, the credentials setup in BaseOrchestration uses an additional role CONF.orchestration.stack_owner_role: https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L40\nI was not sure if using this additional role would not weaken the neutron_resources test, so I kept the original design of separate credentials in test_neutron_resources, and just replaced the legacy mechanism. If additional role does not impact the test, I can delete the line.","commit_id":"400c853760db91a4d0df25136d058cdf1e964225"}]}