)]}'
{"tempest/api/identity/admin/v3/test_endpoints.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"14517d0f9e7df871c6af3455f74e6a726ac301b9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                url\u003durl, region\u003dregion, enabled\u003dFalse)[\u0027endpoint\u0027])"},{"line_number":157,"context_line":"        self.addCleanup(self.client.delete_endpoint, new_endpoint[\u0027id\u0027])"},{"line_number":158,"context_line":"        actual_endpoint \u003d ("},{"line_number":159,"context_line":"            self.client.show_endpoint(new_endpoint[\u0027id\u0027])[\u0027endpoint\u0027])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # Asserting if the attributes of endpoint are the same"},{"line_number":162,"context_line":"        self.assertEqual(new_service[\u0027id\u0027], actual_endpoint[\u0027service_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_f115afe4","line":159,"updated":"2016-01-29 15:06:38.000000000","message":"So this line is the heart/core of this test. The rest is just setup, and it\u0027s heavy.\n\nThe exact same setup is done in test_create_list_delete_endpoint (line 74). I suggest you rename that test into test_create_list_show_delete_endpoint and insert the call to self.client.show_endpoint after line 89.\n\nAlso add a couple of blank/empty lines to make everything more readable.","commit_id":"4cff127a6f6d09e3cd6c46992f2f39436dc2f7ab"},{"author":{"_account_id":18796,"name":"Alex Petrov","email":"apetrov@mirantis.com","username":"apetrov"},"change_message_id":"be789597e8546c5b91d507a5a8c015f54b119d19","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                url\u003durl, region\u003dregion, enabled\u003dFalse)[\u0027endpoint\u0027])"},{"line_number":157,"context_line":"        self.addCleanup(self.client.delete_endpoint, new_endpoint[\u0027id\u0027])"},{"line_number":158,"context_line":"        actual_endpoint \u003d ("},{"line_number":159,"context_line":"            self.client.show_endpoint(new_endpoint[\u0027id\u0027])[\u0027endpoint\u0027])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # Asserting if the attributes of endpoint are the same"},{"line_number":162,"context_line":"        self.assertEqual(new_service[\u0027id\u0027], actual_endpoint[\u0027service_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_c18a131b","line":159,"in_reply_to":"7a5de9d1_f115afe4","updated":"2016-01-29 20:05:07.000000000","message":"I agree, i\u0027ll do","commit_id":"4cff127a6f6d09e3cd6c46992f2f39436dc2f7ab"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2c1ec187d8ff678416ffc5a7c83281cebdb9db7b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                url\u003durl, region\u003dregion, enabled\u003dFalse)[\u0027endpoint\u0027])"},{"line_number":157,"context_line":"        self.addCleanup(self.client.delete_endpoint, new_endpoint[\u0027id\u0027])"},{"line_number":158,"context_line":"        actual_endpoint \u003d ("},{"line_number":159,"context_line":"            self.client.show_endpoint(new_endpoint[\u0027id\u0027])[\u0027endpoint\u0027])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        # Asserting if the attributes of endpoint are the same"},{"line_number":162,"context_line":"        self.assertEqual(new_service[\u0027id\u0027], actual_endpoint[\u0027service_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_a2da834a","line":159,"in_reply_to":"7a5de9d1_f115afe4","updated":"2016-01-29 15:51:54.000000000","message":"Yes, good idea.","commit_id":"4cff127a6f6d09e3cd6c46992f2f39436dc2f7ab"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d9640c7ebf1d7eedf5c92ee5fbd8d213bab833c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        endpoint \u003d self.client.create_endpoint(service_id\u003dself.service_id,"},{"line_number":79,"context_line":"                                               interface\u003dinterface,"},{"line_number":80,"context_line":"                                               url\u003durl, region\u003dregion,"},{"line_number":81,"context_line":"                                               enabled\u003dTrue)[\u0027endpoint\u0027]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Asserting Create Endpoint response body"},{"line_number":84,"context_line":"        self.assertIn(\u0027id\u0027, endpoint)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_561d0772","line":81,"range":{"start_line":81,"start_character":70,"end_line":81,"end_character":72},"updated":"2016-02-10 05:39:22.000000000","message":"should have cleanup here but can be done later as per patch scope.","commit_id":"5ae389fcde182a030a8da55dbf2e5c92b6c3acbe"}]}