)]}'
{"tempest/scenario/test_server_advanced_ops.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"745ae3554bce5dbe00c288dc2de1565ae40086e1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            self.assertEqual(self.keypair.id, kp_name)"},{"line_number":91,"context_line":"            self.set_resource(\u0027keypair\u0027, self.keypair)"},{"line_number":92,"context_line":"        except AttributeError:"},{"line_number":93,"context_line":"            self.fail(\"Keypair object not successfully created.\")"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def boot_instance(self):"},{"line_number":96,"context_line":"        i_name \u003d rand_name(\u0027instance\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F8JQ%3D","line":93,"updated":"2013-05-18 16:19:07.000000000","message":"Please avoid  the self.fail usage.","commit_id":"a9136cc251a2f79a08e33386830eae64adff340f"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"300fcd9c6b2895ccb5966d5a2577cfdf0ae7b9dc","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    This test case stresses some advanced server instance operations:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"     * Resizing an instance"},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0ic%3D","line":31,"updated":"2013-05-22 10:11:55.000000000","message":"You should add the new testcase in the description","commit_id":"b02091c1181875e521e6c4a023fa84ba2adeaee4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"300fcd9c6b2895ccb5966d5a2577cfdf0ae7b9dc","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def create_keypair(self):"},{"line_number":83,"context_line":"        kp_name \u003d rand_name(\u0027keypair-smoke\u0027)"},{"line_number":84,"context_line":"        self.keypair \u003d self.compute_client.keypairs.create(kp_name)"},{"line_number":85,"context_line":"        self.assertIn(\u0027id\u0027, dir(self.keypair))"},{"line_number":86,"context_line":"        self.assertEqual(self.keypair.id, kp_name)"},{"line_number":87,"context_line":"        self.set_resource(\u0027keypair\u0027, self.keypair)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0iQ%3D","line":85,"updated":"2013-05-22 10:11:55.000000000","message":"I would not assert stuff which should have been tested elsewhere","commit_id":"b02091c1181875e521e6c4a023fa84ba2adeaee4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"300fcd9c6b2895ccb5966d5a2577cfdf0ae7b9dc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.instance \u003d self.compute_client.servers.create("},{"line_number":97,"context_line":"            i_name, base_image_id, flavor_id, **create_kwargs)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.assertEqual(self.instance.name, i_name)"},{"line_number":100,"context_line":"        self.set_resource(\u0027instance\u0027, self.instance)"},{"line_number":101,"context_line":"        self.assertEqual(self.instance.status, \u0027BUILD\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0iM%3D","line":99,"updated":"2013-05-22 10:11:55.000000000","message":"I would not assert stuff which should have been tested elsewhere","commit_id":"b02091c1181875e521e6c4a023fa84ba2adeaee4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"300fcd9c6b2895ccb5966d5a2577cfdf0ae7b9dc","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.set_resource(\u0027instance\u0027, self.instance)"},{"line_number":101,"context_line":"        self.assertEqual(self.instance.status, \u0027BUILD\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def wait_on_active(self):"},{"line_number":104,"context_line":"        instance_id \u003d self.get_resource(\u0027instance\u0027).id"},{"line_number":105,"context_line":"        self.status_timeout("},{"line_number":106,"context_line":"            self.compute_client.servers, instance_id, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0iE%3D","line":103,"updated":"2013-05-22 10:11:55.000000000","message":"Isn\u0027t there in the base class a wrapper which creates and returns an active server?","commit_id":"b02091c1181875e521e6c4a023fa84ba2adeaee4"}],"tempest/tests/compute/servers/test_server_advanced_ops.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"6474e7205f3432d3487450651e3157319f602304","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            self.assertEqual(self.instance.name, i_name)"},{"line_number":103,"context_line":"            self.set_resource(\u0027instance\u0027, self.instance)"},{"line_number":104,"context_line":"        except AttributeError:"},{"line_number":105,"context_line":"            self.fail(\"Instance not successfully created.\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertEqual(self.instance.status, \u0027BUILD\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F9GE%3D","line":104,"updated":"2013-05-16 07:37:07.000000000","message":"Please use self.assertRaises  when the exception is expected normal.","commit_id":"1b370e920ff66b6cefa6c333121a0954391a5a49"},{"author":{"_account_id":6719,"name":"tatyana-leontovich","email":"tleontovich@mirantis.com","username":"tatyana-leontovich"},"change_message_id":"04998209ac8ac6d18bec73122ca0373db0cb6052","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            self.assertEqual(self.instance.name, i_name)"},{"line_number":103,"context_line":"            self.set_resource(\u0027instance\u0027, self.instance)"},{"line_number":104,"context_line":"        except AttributeError:"},{"line_number":105,"context_line":"            self.fail(\"Instance not successfully created.\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertEqual(self.instance.status, \u0027BUILD\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F934%3D","line":104,"in_reply_to":"AAAAO3%2F%2F9GE%3D","updated":"2013-05-17 15:49:06.000000000","message":"In such code I expected that there are no any exceptions, and self.assertRaises verifies that exception is actually raise and expects that exception raise. So There should not be  self.assertRaises. One more example is here (see line  64 )","commit_id":"1b370e920ff66b6cefa6c333121a0954391a5a49"}]}