)]}'
{"tempest/api/compute/floating_ips/test_floating_ips_actions.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c4f61878844bb6f4f890a7a0c540519ad8baec97","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":45,"context_line":"        # Floating IP creation"},{"line_number":46,"context_line":"        kwargs \u003d {\u0027pool\u0027: CONF.network.floating_network_name}"},{"line_number":47,"context_line":"        body \u003d cls.client.create_floating_ip(**kwargs)[\u0027floating_ip\u0027]"},{"line_number":48,"context_line":"        cls.floating_ip_id \u003d body[\u0027id\u0027]"},{"line_number":49,"context_line":"        cls.floating_ip \u003d body[\u0027ip\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_72b4b6f1","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":60},"updated":"2016-01-28 08:41:17.000000000","message":"This test class is for compute(nova) api tests, not for network(neutron) api tests as the directory path.\n\nSo it is a little strange for using network config in this test class. In addition, this option is \"Default floating network name.\" not \"pool name\", so is it right to use it here?\n\nI feel it is nice to add a new option for this as a compute config.","commit_id":"b281db1c3b69b5078b79aafdf17b8bddef7b5f2e"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"cea379272760d435fa07e6d3b61f1762e4c05e2e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":45,"context_line":"        # Floating IP creation"},{"line_number":46,"context_line":"        kwargs \u003d {\u0027pool\u0027: CONF.network.floating_network_name}"},{"line_number":47,"context_line":"        body \u003d cls.client.create_floating_ip(**kwargs)[\u0027floating_ip\u0027]"},{"line_number":48,"context_line":"        cls.floating_ip_id \u003d body[\u0027id\u0027]"},{"line_number":49,"context_line":"        cls.floating_ip \u003d body[\u0027ip\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_2ad92557","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":60},"in_reply_to":"7a5de9d1_44057811","updated":"2016-02-02 03:38:39.000000000","message":"The option \"CONF.network.floating_network_name\" is defined at\n\nhttps://github.com/openstack/tempest/blob/master/tempest/config.py#L519\n\nIn the \"network\" group.\nhttps://github.com/openstack/tempest/blob/master/tempest/config.py#L480\n\nI think the \"network\" group can represent both \"neutron\" \u0026 \"nova-network\", because they\u0027re both \"network\" services.\n\n\nMaybe we just need to remove the \"when neutron is enabled.\" in the help message ?","commit_id":"b281db1c3b69b5078b79aafdf17b8bddef7b5f2e"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"29f14f3ddd0776d3b8b187a8e38b2d11e1a33a61","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":45,"context_line":"        # Floating IP creation"},{"line_number":46,"context_line":"        kwargs \u003d {\u0027pool\u0027: CONF.network.floating_network_name}"},{"line_number":47,"context_line":"        body \u003d cls.client.create_floating_ip(**kwargs)[\u0027floating_ip\u0027]"},{"line_number":48,"context_line":"        cls.floating_ip_id \u003d body[\u0027id\u0027]"},{"line_number":49,"context_line":"        cls.floating_ip \u003d body[\u0027ip\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_9f2b7aeb","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":60},"in_reply_to":"7a5de9d1_72b4b6f1","updated":"2016-01-28 09:24:36.000000000","message":"I believe this is the right option, because :\n\n1. The comments in tempest.conf.sample for \"floating_network_name\" said :\n# Default floating network name. Used to allocate floating IPs when\n# neutron is enabled. (string value)\n\n\n2. when we run CLI command by hand, floating IP pool \u003d\u003d the network name you created.\n\n3. I tested with this change, it works.\n\n\n\n\nI have a question about add a new option for this as a compute config: Would it be a little confusing to tempest users, they need to set 2 options with the same value ?","commit_id":"b281db1c3b69b5078b79aafdf17b8bddef7b5f2e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"002eb13fa704009ac107f3f9169a07380e28230c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        server \u003d cls.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":44,"context_line":"        cls.server_id \u003d server[\u0027id\u0027]"},{"line_number":45,"context_line":"        # Floating IP creation"},{"line_number":46,"context_line":"        kwargs \u003d {\u0027pool\u0027: CONF.network.floating_network_name}"},{"line_number":47,"context_line":"        body \u003d cls.client.create_floating_ip(**kwargs)[\u0027floating_ip\u0027]"},{"line_number":48,"context_line":"        cls.floating_ip_id \u003d body[\u0027id\u0027]"},{"line_number":49,"context_line":"        cls.floating_ip \u003d body[\u0027ip\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_44057811","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":60},"in_reply_to":"7a5de9d1_9f2b7aeb","updated":"2016-02-02 02:50:37.000000000","message":"I am still against that.\n\nThis test module is not only for neutron, but also nova-network.\n\nAs the description of the config, the option is only for neutron. In addition, current test code under tempest/api/compute doesn\u0027t contain CONF.network.*** options at all.\nSo this change seems a little odd for me.\n\nOne more thing is that CONF.network.floating_network_name is not used at all, so additional config would not make confusions at this time I feel.","commit_id":"b281db1c3b69b5078b79aafdf17b8bddef7b5f2e"}]}