)]}'
{"tempest/api/network/test_ports.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"2f11edb884f05a647676d761b1006b894291c076","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        body \u003d self.ports_client.show_port(self.port[\u0027id\u0027])"},{"line_number":123,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":124,"context_line":"        self.assertIn(\u0027id\u0027, port)"},{"line_number":125,"context_line":"        self.assertEqual(self.port, port)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.idempotent_id(\u002745fcdaf2-dab0-4c13-ac6c-fcddfb579dbd\u0027)"},{"line_number":128,"context_line":"    def test_show_port_fields(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_43ce072f","line":125,"updated":"2016-02-01 03:46:09.000000000","message":"self.port contains key \u0027extra_dhcp_opts\u0027 while port not.\nAnd for they are dict type, maybe you could do:\n  self.port.pop(\u0027extra_dhcp_opts\u0027)\nbefore assertEqual(self.port, port).","commit_id":"7486311f48ed587e0422feef28300b59439d4da1"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"316068c071160edcfc0320625f6e1d99891610fb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        body \u003d self.ports_client.show_port(self.port[\u0027id\u0027])"},{"line_number":123,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":124,"context_line":"        self.assertIn(\u0027id\u0027, port)"},{"line_number":125,"context_line":"        self.assertEqual(self.port, port)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.idempotent_id(\u002745fcdaf2-dab0-4c13-ac6c-fcddfb579dbd\u0027)"},{"line_number":128,"context_line":"    def test_show_port_fields(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_252ae590","line":125,"in_reply_to":"7a5de9d1_43ce072f","updated":"2016-02-01 10:52:37.000000000","message":"Done","commit_id":"7486311f48ed587e0422feef28300b59439d4da1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1c62e14ce3b0d472a93829577eca6409311556a8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":124,"context_line":"        self.assertIn(\u0027id\u0027, port)"},{"line_number":125,"context_line":"        # TODO(sreesiv) Remove this pop as the \u0027extra_dhcp_opts\u0027"},{"line_number":126,"context_line":"        # will not be there in port, once the fix for the issue with"},{"line_number":127,"context_line":"        # Change-Id: I29dadb59a7f70e4d731bd7dd90169436196955b0"},{"line_number":128,"context_line":"        # https://review.openstack.org/#/c/273077/ is checked in."},{"line_number":129,"context_line":"        port.pop(\u0027extra_dhcp_opts\u0027, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_23506e5e","line":126,"updated":"2016-03-11 06:18:59.000000000","message":"You\u0027re making a non backward compatible change, and by doing this you\u0027re masking the issue.","commit_id":"00734c9aa48b1bb60ddb4fa26f1a07a1da74b075"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"e2ba3757fbc536146fad828e3320d00676b60842","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        port \u003d body[\u0027port\u0027]"},{"line_number":124,"context_line":"        self.assertIn(\u0027id\u0027, port)"},{"line_number":125,"context_line":"        # TODO(sreesiv) Remove this pop as the \u0027extra_dhcp_opts\u0027"},{"line_number":126,"context_line":"        # will not be there in port, once the fix for the issue with"},{"line_number":127,"context_line":"        # Change-Id: I29dadb59a7f70e4d731bd7dd90169436196955b0"},{"line_number":128,"context_line":"        # https://review.openstack.org/#/c/273077/ is checked in."},{"line_number":129,"context_line":"        port.pop(\u0027extra_dhcp_opts\u0027, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_09af4c95","line":126,"in_reply_to":"5aef4532_23506e5e","updated":"2016-03-11 10:02:43.000000000","message":"I am not trying to mask the issue. I\u0027ve just kept this as a place holder assuming that the original patch for the issue in neutron would be accepted. Since the neutron one is rejected, there is no place for this one, and am abandoning it.\n\nI agree with your comments, it may break back compat if any client is expecting the field.","commit_id":"00734c9aa48b1bb60ddb4fa26f1a07a1da74b075"}]}