)]}'
{"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"08b5c8426f4252d9184a4fa19e42a4e9afd1c426","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(AttachVolumeTestJSON, cls).resource_setup()"},{"line_number":50,"context_line":"        cls.device \u003d CONF.compute.volume_device_name"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def setup_clients(cls):"},{"line_number":54,"context_line":"        super(AttachVolumeTestJSON, cls).setup_clients()"},{"line_number":55,"context_line":"        cls.volumes_client \u003d cls.volumes_extensions_client"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _detach(self, server_id, volume_id):"},{"line_number":58,"context_line":"        if self.attachment:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_b8177fec","line":55,"range":{"start_line":52,"start_character":0,"end_line":55,"end_character":58},"updated":"2016-02-15 05:00:44.000000000","message":"This is not needed. cls.volumes_client can be used for waiter as done below.","commit_id":"5294a8ecc1833160c37750ddf61cf7b13425619b"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3c4175af68acf5478db83d84ab07d9ab469b3785","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def setup_clients(cls):"},{"line_number":54,"context_line":"        super(AttachVolumeTestJSON, cls).setup_clients()"},{"line_number":55,"context_line":"        cls.volumes_client \u003d cls.volumes_extensions_client"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _detach(self, server_id, volume_id):"},{"line_number":58,"context_line":"        if self.attachment:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_46f663d8","line":55,"updated":"2016-03-11 13:35:05.000000000","message":"This is going to be confusing. In tempest, \"volumes_client\" is a client that talks to Cinder whilst \"volumes_extensions_client\" is a client that talks to Nova.\n\nMaking one an alias of the other is confusing. You could use volumes_extensions_client everywhere in that class, but the \"renaming\" is bad.","commit_id":"263eaf16fa39552f24daa75f7653a6da7d0c70c8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"3c4175af68acf5478db83d84ab07d9ab469b3785","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def _detach(self, server_id, volume_id):"},{"line_number":58,"context_line":"        if self.attachment:"},{"line_number":59,"context_line":"            self.servers_client.detach_volume(server_id, volume_id)"},{"line_number":60,"context_line":"            waiters.wait_for_volume_status(self.volumes_client, volume_id,"},{"line_number":61,"context_line":"                                           \u0027available\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _delete_volume(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_c630b3a1","line":60,"updated":"2016-03-11 13:35:05.000000000","message":"I like this change but it should be:\n    waiters.wait_for_volume_status(self.volumes_extensions_client, volume_id,","commit_id":"263eaf16fa39552f24daa75f7653a6da7d0c70c8"}]}