)]}'
{"tempest/api/identity/admin/v3/test_endpoints.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                         \u0027, \u0027.join(str(e) for e in missing_endpoints))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @test.idempotent_id(\u00270e2446d2-c1fd-461b-a729-b9e73e3e3b37\u0027)"},{"line_number":74,"context_line":"    def test_create_list_show_delete_endpoint(self):"},{"line_number":75,"context_line":"        region \u003d data_utils.rand_name(\u0027region\u0027)"},{"line_number":76,"context_line":"        url \u003d data_utils.rand_url()"},{"line_number":77,"context_line":"        interface \u003d \u0027public\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_e2a411a7","line":74,"updated":"2016-02-11 15:42:55.000000000","message":"Did you make these changes or it is because of rebase?","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"}],"tempest/api/identity/admin/v3/test_groups.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"549a415242727653c64ff4812a82e536242cead1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            self.addCleanup(self.groups_client.delete_group, group[\u0027id\u0027])"},{"line_number":100,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"},{"line_number":101,"context_line":"        # list groups which user belongs to"},{"line_number":102,"context_line":"        user_groups \u003d self.client.list_user_groups(user[\u0027id\u0027])[\u0027groups\u0027]"},{"line_number":103,"context_line":"        self.assertEqual(sorted(groups), sorted(user_groups))"},{"line_number":104,"context_line":"        self.assertEqual(2, len(user_groups))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_beaf8993","line":102,"range":{"start_line":102,"start_character":27,"end_line":102,"end_character":33},"updated":"2016-02-09 20:47:12.000000000","message":"Isn\u0027t this supposed to be part of the users_client as well?","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"14c118b0d5b50228ef86b49ee9fd28a6de2dfc5a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            self.addCleanup(self.groups_client.delete_group, group[\u0027id\u0027])"},{"line_number":100,"context_line":"            self.groups_client.add_group_user(group[\u0027id\u0027], user[\u0027id\u0027])"},{"line_number":101,"context_line":"        # list groups which user belongs to"},{"line_number":102,"context_line":"        user_groups \u003d self.client.list_user_groups(user[\u0027id\u0027])[\u0027groups\u0027]"},{"line_number":103,"context_line":"        self.assertEqual(sorted(groups), sorted(user_groups))"},{"line_number":104,"context_line":"        self.assertEqual(2, len(user_groups))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_07b0bbf3","line":102,"range":{"start_line":102,"start_character":27,"end_line":102,"end_character":33},"in_reply_to":"3a57f1b5_beaf8993","updated":"2016-02-10 07:35:31.000000000","message":"My idea would be to put that in the groups_client, would you prefer for this to be included in this patch, maybe Ken\u0027Ichi could clarify the approach.","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"}],"tempest/api/identity/base.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"228972d64c0c808e18f791f8013663c44bc92642","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        super(BaseIdentityV3AdminTest, cls).resource_cleanup()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @classmethod"},{"line_number":169,"context_line":"    def get_user_by_name(cls, name):"},{"line_number":170,"context_line":"        users \u003d cls.users_client.list_users()[\u0027users\u0027]"},{"line_number":171,"context_line":"        user \u003d [u for u in users if u[\u0027name\u0027] \u003d\u003d name]"},{"line_number":172,"context_line":"        if len(user) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_fbddbe14","line":169,"updated":"2016-02-11 03:56:40.000000000","message":"we can delete this method at all because we have the same in the BaseIdentityTest class.","commit_id":"183c0810c9f2ca4632c4d43e4c062345b4655d9d"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    @classmethod"},{"line_number":109,"context_line":"    def resource_setup(cls):"},{"line_number":110,"context_line":"        super(BaseIdentityV2AdminTest, cls).resource_setup()"},{"line_number":111,"context_line":"        cls.data \u003d DataGeneratorV2(cls.client, cls.users_client,"},{"line_number":112,"context_line":"                                   cls.tenants_client, cls.roles_client)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_dd7d361d","line":111,"updated":"2016-02-11 15:42:55.000000000","message":"Could you please change arguments order back?\n\n\ncls.client, cls.tenants_client, cls.users_client, cls.roles_client","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    @classmethod"},{"line_number":160,"context_line":"    def resource_setup(cls):"},{"line_number":161,"context_line":"        super(BaseIdentityV3AdminTest, cls).resource_setup()"},{"line_number":162,"context_line":"        cls.data \u003d DataGeneratorV3(cls.client, cls.users_client,"},{"line_number":163,"context_line":"                                   cls.projects_client)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_fdc6f247","line":162,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"class BaseDataGenerator(object):"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def __init__(self, client, users_client,"},{"line_number":192,"context_line":"                 projects_client, roles_client\u003dNone):"},{"line_number":193,"context_line":"        self.client \u003d client"},{"line_number":194,"context_line":"        self.projects_client \u003d projects_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_5dde2612","line":191,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"}],"tempest/common/cred_client.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     admin credentials used for generating credentials."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, identity_client, users_client, projects_client,"},{"line_number":35,"context_line":"                 roles_client\u003dNone):"},{"line_number":36,"context_line":"        # The client implies version and credentials"},{"line_number":37,"context_line":"        self.identity_client \u003d identity_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_7d08c291","line":34,"updated":"2016-02-11 15:42:55.000000000","message":"Could you please change arguments order back?","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class V2CredsClient(CredsClient):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def __init__(self, identity_client, users_client, projects_client,"},{"line_number":101,"context_line":"                 roles_client):"},{"line_number":102,"context_line":"        super(V2CredsClient, self).__init__(identity_client,"},{"line_number":103,"context_line":"                                            users_client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_fd3b5236","line":100,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class V3CredsClient(CredsClient):"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def __init__(self, identity_client, users_client, projects_client,"},{"line_number":130,"context_line":"                 domain_name):"},{"line_number":131,"context_line":"        super(V3CredsClient, self).__init__(identity_client, users_client,"},{"line_number":132,"context_line":"                                            projects_client)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_1d0d0e90","line":129,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                     roles_client\u003dNone,"},{"line_number":174,"context_line":"                     project_domain_name\u003dNone):"},{"line_number":175,"context_line":"    if isinstance(identity_client, v2_identity.IdentityClient):"},{"line_number":176,"context_line":"        return V2CredsClient(identity_client, users_client, projects_client,"},{"line_number":177,"context_line":"                             roles_client)"},{"line_number":178,"context_line":"    else:"},{"line_number":179,"context_line":"        return V3CredsClient(identity_client, users_client, projects_client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_1d842ed2","line":176,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return V2CredsClient(identity_client, users_client, projects_client,"},{"line_number":177,"context_line":"                             roles_client)"},{"line_number":178,"context_line":"    else:"},{"line_number":179,"context_line":"        return V3CredsClient(identity_client, users_client, projects_client,"},{"line_number":180,"context_line":"                             project_domain_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_fd691226","line":179,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"}],"tempest/common/dynamic_creds.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d59399b1a44c5fd9687f2d5e4cf01f05eb2ea4d8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _create_creds(self, suffix\u003d\"\", admin\u003dFalse, roles\u003dNone):"},{"line_number":102,"context_line":"        \"\"\"Create random credentials under the following schema."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"If        If the name contains a \u0027.\u0027 is the full class path of something, and"},{"line_number":105,"context_line":"        we don\u0027t really care. If it isn\u0027t, it\u0027s probably a meaningful name,"},{"line_number":106,"context_line":"        so use it."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_07e538a7","line":104,"updated":"2016-02-09 17:49:47.000000000","message":"Nope :(","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"14c118b0d5b50228ef86b49ee9fd28a6de2dfc5a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _create_creds(self, suffix\u003d\"\", admin\u003dFalse, roles\u003dNone):"},{"line_number":102,"context_line":"        \"\"\"Create random credentials under the following schema."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"If        If the name contains a \u0027.\u0027 is the full class path of something, and"},{"line_number":105,"context_line":"        we don\u0027t really care. If it isn\u0027t, it\u0027s probably a meaningful name,"},{"line_number":106,"context_line":"        so use it."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_67e72f41","line":104,"in_reply_to":"3a57f1b5_07e538a7","updated":"2016-02-10 07:35:31.000000000","message":"Oops! I\u0027ll fix this in new PS","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.ports \u003d []"},{"line_number":59,"context_line":"        self.default_admin_creds \u003d admin_creds"},{"line_number":60,"context_line":"        (self.identity_admin_client,"},{"line_number":61,"context_line":"         self.users_admin_client,"},{"line_number":62,"context_line":"         self.tenants_admin_client,"},{"line_number":63,"context_line":"         self.roles_admin_client,"},{"line_number":64,"context_line":"         self.network_admin_client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_dddc56e6","line":61,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                self.credentials_domain)"},{"line_number":76,"context_line":"        self.creds_client \u003d cred_client.get_creds_client("},{"line_number":77,"context_line":"            self.identity_admin_client,"},{"line_number":78,"context_line":"            self.users_admin_client,"},{"line_number":79,"context_line":"            self.tenants_admin_client,"},{"line_number":80,"context_line":"            self.roles_admin_client,"},{"line_number":81,"context_line":"            self.creds_domain_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_bde15a9c","line":78,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        os \u003d clients.Manager(self.default_admin_creds)"},{"line_number":91,"context_line":"        if self.identity_version \u003d\u003d \u0027v2\u0027:"},{"line_number":92,"context_line":"            return (os.identity_client, os.users_client, os.tenants_client,"},{"line_number":93,"context_line":"                    os.roles_client, os.network_client, os.networks_client,"},{"line_number":94,"context_line":"                    os.subnets_client, os.ports_client,"},{"line_number":95,"context_line":"                    os.security_groups_client)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_dd03f640","line":92,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    os.subnets_client, os.ports_client,"},{"line_number":95,"context_line":"                    os.security_groups_client)"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            return (os.identity_v3_client, os.users_v3_client,"},{"line_number":98,"context_line":"                    os.projects_client, None, os.network_client,"},{"line_number":99,"context_line":"                    os.networks_client, os.subnets_client, os.ports_client,"},{"line_number":100,"context_line":"                    os.security_groups_client)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_bdf87a4a","line":97,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"}],"tempest/services/identity/v3/json/identity_client.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"549a415242727653c64ff4812a82e536242cead1","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":210,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def list_user_groups(self, user_id):"},{"line_number":213,"context_line":"        \"\"\"Lists groups which a user belongs to.\"\"\""},{"line_number":214,"context_line":"        resp, body \u003d self.get(\u0027users/%s/groups\u0027 % user_id)"},{"line_number":215,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_79092b31","line":212,"range":{"start_line":212,"start_character":3,"end_line":212,"end_character":40},"updated":"2016-02-09 20:47:12.000000000","message":"Shouldn\u0027t this method also be moved to the users_client?","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"14c118b0d5b50228ef86b49ee9fd28a6de2dfc5a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":210,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def list_user_groups(self, user_id):"},{"line_number":213,"context_line":"        \"\"\"Lists groups which a user belongs to.\"\"\""},{"line_number":214,"context_line":"        resp, body \u003d self.get(\u0027users/%s/groups\u0027 % user_id)"},{"line_number":215,"context_line":"        self.expected_success(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_679f2f60","line":212,"range":{"start_line":212,"start_character":3,"end_line":212,"end_character":40},"in_reply_to":"3a57f1b5_79092b31","updated":"2016-02-10 07:35:31.000000000","message":"ditto","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"}],"tempest/services/identity/v3/json/users_clients.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"549a415242727653c64ff4812a82e536242cead1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a57f1b5_2b627ad9","updated":"2016-02-09 20:47:12.000000000","message":"Based on the comment I left in the identity_client, maybe list_user_groups method should be moved to this client?\nI see this client already has similar methods like:\nlist_user_projects","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"14c118b0d5b50228ef86b49ee9fd28a6de2dfc5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a57f1b5_27885722","in_reply_to":"3a57f1b5_2b627ad9","updated":"2016-02-10 07:35:31.000000000","message":"ditto","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"491d26887891edaf02570a67be61f4fe41b91e0b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def create_user(self, user_name, password\u003dNone, project_id\u003dNone,"},{"line_number":25,"context_line":"                    email\u003dNone, domain_id\u003d\u0027default\u0027, **kwargs):"},{"line_number":26,"context_line":"        \"\"\"Creates a user.\"\"\""},{"line_number":27,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, True)"},{"line_number":28,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, None)"},{"line_number":29,"context_line":"        default_project_id \u003d kwargs.get(\u0027default_project_id\u0027)"},{"line_number":30,"context_line":"        post_body \u003d {"},{"line_number":31,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":32,"context_line":"            \u0027default_project_id\u0027: default_project_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_e71056ab","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":61},"updated":"2016-02-14 02:10:31.000000000","message":"I guess we need to pass kwargs directly like the other creation methods, but it is good to make it out of scope from this patch.","commit_id":"7aea534b377009b2ee694ec3c81c0bf44554b3fd"}],"tempest/stress/driver.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2deeb2a44cf7be4cfa7a89612d11c2056cc49459","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                domain \u003d (identity_client.auth_provider.credentials."},{"line_number":158,"context_line":"                          get(\u0027project_domain_name\u0027, \u0027Default\u0027))"},{"line_number":159,"context_line":"                credentials_client \u003d cred_client.get_creds_client("},{"line_number":160,"context_line":"                    identity_client, users_client, projects_client,"},{"line_number":161,"context_line":"                    roles_client, project_domain_name\u003ddomain)"},{"line_number":162,"context_line":"                project \u003d credentials_client.create_project("},{"line_number":163,"context_line":"                    name\u003dtenant_name, description\u003dtenant_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_1d450e6f","line":160,"updated":"2016-02-11 15:42:55.000000000","message":"ditto","commit_id":"01bdf6c6b9b90e386462bd0f557d631798a2a35e"}],"tempest/test.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d59399b1a44c5fd9687f2d5e4cf01f05eb2ea4d8","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        \"\"\""},{"line_number":438,"context_line":"        if CONF.identity.auth_version \u003d\u003d \u0027v2\u0027:"},{"line_number":439,"context_line":"            client \u003d self.os_admin.identity_client"},{"line_number":440,"context_line":"            users_client \u003d self.os_admin.users_client"},{"line_number":441,"context_line":"            project_client \u003d self.os_admin.tenants_client"},{"line_number":442,"context_line":"            roles_client \u003d self.os_admin.roles_client"},{"line_number":443,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_e767bc23","line":440,"updated":"2016-02-09 17:49:47.000000000","message":"You have a couple of unrelated changes in that patch that confuse me as a reviewer :)","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"14c118b0d5b50228ef86b49ee9fd28a6de2dfc5a","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        \"\"\""},{"line_number":438,"context_line":"        if CONF.identity.auth_version \u003d\u003d \u0027v2\u0027:"},{"line_number":439,"context_line":"            client \u003d self.os_admin.identity_client"},{"line_number":440,"context_line":"            users_client \u003d self.os_admin.users_client"},{"line_number":441,"context_line":"            project_client \u003d self.os_admin.tenants_client"},{"line_number":442,"context_line":"            roles_client \u003d self.os_admin.roles_client"},{"line_number":443,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_07b99be9","line":440,"in_reply_to":"3a57f1b5_e767bc23","updated":"2016-02-10 07:35:31.000000000","message":"What would those be? If you mean by reordering the client list I did that in order to be consistent with the clients that are both allowed to be \u0027or identity client\u0027 and \u003d None and the ones that aren\u0027t","commit_id":"3a89b61d24b9c5de9721b24900e8a7c4eb27e729"}]}