)]}'
{"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d6495992dcc5e9eebd73d0a4ca8c699aae6028b7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        cls.volume \u003d cls.create_volume(imageRef\u003dCONF.compute.image_ref,"},{"line_number":41,"context_line":"                                       size\u003dCONF.volume.volume_size)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_backup(self, volume_id, incremental\u003dFalse, force\u003dFalse,"},{"line_number":44,"context_line":"                       name\u003dNone):"},{"line_number":45,"context_line":"        backup \u003d self.backups_adm_client.create_backup(volume_id\u003dvolume_id,"},{"line_number":46,"context_line":"                                                       incremental\u003dincremental,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_9f74019d","line":43,"updated":"2016-02-15 17:56:37.000000000","message":"This wrapper is useless. We are not going to create a method to group each 2-line of code. \n\nEach time a see a new method call in the test, I have to go the the method definition, scroll, etc...","commit_id":"ae5a64e9fa07932f51b14e8e3b9bb46ba00830d3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d6495992dcc5e9eebd73d0a4ca8c699aae6028b7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.backups_adm_client.delete_backup(backup_id)"},{"line_number":55,"context_line":"        self.backups_adm_client.wait_for_backup_deletion(backup_id)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _delete_server(self, server_id):"},{"line_number":58,"context_line":"        servers \u003d self.servers_client.list_servers()[\u0027servers\u0027]"},{"line_number":59,"context_line":"        if server_id not in servers:"},{"line_number":60,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_bf1465f5","line":57,"updated":"2016-02-15 17:56:37.000000000","message":"This wrapper is useless. Are you/we going to check for every delete that the resource actually exists ? Try to follow Python\u0027s zen: \"better ask forgiveness than permission\"","commit_id":"ae5a64e9fa07932f51b14e8e3b9bb46ba00830d3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d6495992dcc5e9eebd73d0a4ca8c699aae6028b7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":67,"context_line":"        backup \u003d self._create_backup(volume_id\u003dself.volume[\u0027id\u0027],"},{"line_number":68,"context_line":"                                     name\u003dbackup_name)"},{"line_number":69,"context_line":"        self.addCleanup(self._delete_backup, backup[\u0027id\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":71,"context_line":"        self.admin_volume_client.wait_for_volume_status("},{"line_number":72,"context_line":"            self.volume[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_ffac2def","line":69,"updated":"2016-02-15 17:56:37.000000000","message":"Why this change ? Why to you have to wait that the backup is deleted ?","commit_id":"ae5a64e9fa07932f51b14e8e3b9bb46ba00830d3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d6495992dcc5e9eebd73d0a4ca8c699aae6028b7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.assertTrue(backup_incr_force[\u0027is_incremental\u0027])"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # Stop and delete vm"},{"line_number":181,"context_line":"        self.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":182,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":183,"context_line":"                                       server[\u0027id\u0027], \u0027SHUTOFF\u0027)"},{"line_number":184,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_5f0439bf","line":181,"updated":"2016-02-15 17:56:37.000000000","message":"Why \"stop and delete\" and not just \"delete\" ?","commit_id":"ae5a64e9fa07932f51b14e8e3b9bb46ba00830d3"}],"tempest/api/volume/test_volumes_backup.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7de46878e62ac7622756ceca365655efe97cbb79","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        Cinder allows to create incremental volume backup."},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        # Create backup"},{"line_number":119,"context_line":"        backup \u003d self.backups_client.create_backup("},{"line_number":120,"context_line":"            volume_id\u003dself.volume[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":121,"context_line":"        self.addCleanup(self.backups_client.delete_backup, backup[\u0027id\u0027])"},{"line_number":122,"context_line":"        self.backups_client.wait_for_backup_status(backup[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_bb57bfc8","line":119,"updated":"2016-08-23 14:58:44.000000000","message":"Use an existing or introduce a new \u0027create_backup\u0027 utility function in one of the base classes.","commit_id":"e8a597334134799f6391f27aec71a8f9d404f89f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7de46878e62ac7622756ceca365655efe97cbb79","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.addCleanup(self.backups_client.delete_backup, backup[\u0027id\u0027])"},{"line_number":122,"context_line":"        self.backups_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":123,"context_line":"                                                   \u0027available\u0027)"},{"line_number":124,"context_line":"        # Create a server"},{"line_number":125,"context_line":"        bd_map \u003d [{"},{"line_number":126,"context_line":"            \u0027device_name\u0027: \u0027vda\u0027,"},{"line_number":127,"context_line":"            \u0027volume_id\u0027: self.volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_7bbd47d7","line":124,"updated":"2016-08-23 14:58:44.000000000","message":"Use an existing \u0027create_server\u0027 utility function. I bet you are not the only one who wants to create a server in a test, why duplicate some code ?","commit_id":"e8a597334134799f6391f27aec71a8f9d404f89f"}]}