)]}'
{"tempest/tests/orchestration/base.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"51091a71305441e5ffbeae8daa54e2a5844f6ac5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2F3YA%3D","line":3,"updated":"2013-05-21 12:47:40.000000000","message":"Probably wants to be Copyright 2013, OpenStack Foundation if you want to assign copyright (but you don\u0027t have to).","commit_id":"8d644d256c64c70d4d1974fe15523fda5d721d16"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1b96aab5bcba9c1746d9e49a1a896b08a38180ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2F1sQ%3D","line":3,"in_reply_to":"AAAAPH%2F%2F3YA%3D","updated":"2013-05-21 23:07:53.000000000","message":"I\u0027ll remove the copyright headers as per this thread http://lists.openstack.org/pipermail/openstack-dev/2013-May/009189.html","commit_id":"8d644d256c64c70d4d1974fe15523fda5d721d16"}],"tempest/tests/orchestration/stacks/test_stacks.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68526f1ee9c95ccc7f46f6880bfe0bc2c1f59a88","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027CREATE_COMPLETE\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # stack count will increment by 1"},{"line_number":66,"context_line":"        resp, body \u003d self.client.list_stacks()"},{"line_number":67,"context_line":"        self.assertEqual(stack_count + 1, len(body[\u0027stacks\u0027]),"},{"line_number":68,"context_line":"                         \u0027Expected stack count to increment by 1\u0027)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FbOU%3D","line":66,"updated":"2013-05-09 23:22:07.000000000","message":"I think it\u0027d be nice to also check if the name matches what was passed at creation time","commit_id":"fe67ed48db4f8b13b4421493f6980ad6764b9194"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"68526f1ee9c95ccc7f46f6880bfe0bc2c1f59a88","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertEqual(\u0027CREATE_COMPLETE\u0027, body[\u0027stack_status\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # delete the stack"},{"line_number":83,"context_line":"        #resp \u003d self.client.delete_stack(stack_identifier)"},{"line_number":84,"context_line":"        #self.assertEqual(\u0027204\u0027, resp[0][\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FbOQ%3D","line":83,"updated":"2013-05-09 23:22:07.000000000","message":"any particular reason for leaving this commented ?","commit_id":"fe67ed48db4f8b13b4421493f6980ad6764b9194"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cc570980aec4a13617f7728514cda1a129ae4223","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertEqual(\u0027CREATE_COMPLETE\u0027, body[\u0027stack_status\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # delete the stack"},{"line_number":83,"context_line":"        #resp \u003d self.client.delete_stack(stack_identifier)"},{"line_number":84,"context_line":"        #self.assertEqual(\u0027204\u0027, resp[0][\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FbKM%3D","line":83,"in_reply_to":"AAAAOn%2F%2FbOQ%3D","updated":"2013-05-10 00:17:15.000000000","message":"I was just checking that BaseOrchestrationTest.clear_stacks was working. I\u0027ll re-enable this.","commit_id":"fe67ed48db4f8b13b4421493f6980ad6764b9194"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"51091a71305441e5ffbeae8daa54e2a5844f6ac5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        stack_count \u003d len(body[\u0027stacks\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # create the stack"},{"line_number":54,"context_line":"        resp, body \u003d self.client.create_stack("},{"line_number":55,"context_line":"            stack_name,"},{"line_number":56,"context_line":"            template\u003dself.empty_template)"},{"line_number":57,"context_line":"        self.assertEqual(\u0027201\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2F3Xg%3D","line":54,"updated":"2013-05-21 12:47:40.000000000","message":"I wonder if creating a stack and the overhead of setting up the cleanup is common enough that it would make sense to extract this code into a base class function - eg see create_server in compute/base.py","commit_id":"8d644d256c64c70d4d1974fe15523fda5d721d16"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"8dbbbb7385f308122e1da2edd1277d71c5122b8e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        stack_id \u003d resp[\u0027location\u0027].split(\u0027/\u0027)[-1]"},{"line_number":59,"context_line":"        stack_identifier \u003d \u0027%s/%s\u0027 % (stack_name, stack_id)"},{"line_number":60,"context_line":"        self.stacks.append(stack_identifier)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # wait for create complete (with no resources it should be instant)"},{"line_number":63,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027CREATE_COMPLETE\u0027)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAO3%2F%2F%2FPQ%3D","line":61,"updated":"2013-05-15 14:03:10.000000000","message":"You should use the self.addCleanup method in-order to be sure the resource cleaned up, even if we have a subsequent exception.","commit_id":"8d644d256c64c70d4d1974fe15523fda5d721d16"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b1f2f25d063b685e5bb0827f533334af2695ed9b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        stack_id \u003d resp[\u0027location\u0027].split(\u0027/\u0027)[-1]"},{"line_number":59,"context_line":"        stack_identifier \u003d \u0027%s/%s\u0027 % (stack_name, stack_id)"},{"line_number":60,"context_line":"        self.stacks.append(stack_identifier)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # wait for create complete (with no resources it should be instant)"},{"line_number":63,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027CREATE_COMPLETE\u0027)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAO3%2F%2F9GY%3D","line":61,"in_reply_to":"AAAAO3%2F%2F%2BTk%3D","updated":"2013-05-16 07:34:04.000000000","message":"The append should happen immediately after the create_stack.","commit_id":"8d644d256c64c70d4d1974fe15523fda5d721d16"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"3921d20abc186f7464f040ccfa0b26f5269d7e57","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        stack_id \u003d resp[\u0027location\u0027].split(\u0027/\u0027)[-1]"},{"line_number":59,"context_line":"        stack_identifier \u003d \u0027%s/%s\u0027 % (stack_name, stack_id)"},{"line_number":60,"context_line":"        self.stacks.append(stack_identifier)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # wait for create complete (with no resources it should be instant)"},{"line_number":63,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027CREATE_COMPLETE\u0027)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAO3%2F%2F%2BTk%3D","line":61,"in_reply_to":"AAAAO3%2F%2F%2FPQ%3D","updated":"2013-05-15 20:10:19.000000000","message":"BaseOrchestrationTest.clear_stacks will be called on tearDownClass which will delete any remaining stacks. Won\u0027t that be enough?","commit_id":"8d644d256c64c70d4d1974fe15523fda5d721d16"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"40261714d21b733dff05e9d29325fde0ce0ac82c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        stack_id \u003d resp[\u0027location\u0027].split(\u0027/\u0027)[-1]"},{"line_number":59,"context_line":"        stack_identifier \u003d \u0027%s/%s\u0027 % (stack_name, stack_id)"},{"line_number":60,"context_line":"        self.stacks.append(stack_identifier)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # wait for create complete (with no resources it should be instant)"},{"line_number":63,"context_line":"        self.client.wait_for_stack_status(stack_identifier, \u0027CREATE_COMPLETE\u0027)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2F%2Fuw%3D","line":61,"in_reply_to":"AAAAO3%2F%2F9GY%3D","updated":"2013-05-16 21:15:37.000000000","message":"The append can\u0027t happen until stack_identifier is built. I could move the assertEqual to below the append but unless the status is 201 then no stack will be created.","commit_id":"8d644d256c64c70d4d1974fe15523fda5d721d16"}]}