)]}'
{"tempest/api/identity/base.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1794c25238b1cc47f282f145e6e4b1457778bd85","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if domain_id:"},{"line_number":42,"context_line":"            params \u003d {\u0027domain_id\u0027: domain_id}"},{"line_number":43,"context_line":"            users \u003d cls.users_client.list_users(params)[\u0027users\u0027]"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            users \u003d cls.users_client.list_users()[\u0027users\u0027]"},{"line_number":46,"context_line":"        user \u003d [u for u in users if u[\u0027name\u0027] \u003d\u003d name]"},{"line_number":47,"context_line":"        if len(user) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_3b808946","line":44,"updated":"2016-02-24 23:14:46.000000000","message":"I think you could get away without an else here. Just do:\n\n    params \u003d {}\n    if domain_id:\n        params \u003d {\u0027domain_id\u0027: domain_id}\n    users \u003d cls.users_client.list_users(params)[\u0027users\u0027]\n\nBut, it\u0027s probably fine like this too","commit_id":"bc3c76c3bac98f7a043ace86803ebedeb32a27eb"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"c6481fcda516c181dcaf679133e8eff0a3e402aa","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if domain_id:"},{"line_number":42,"context_line":"            params \u003d {\u0027domain_id\u0027: domain_id}"},{"line_number":43,"context_line":"            users \u003d cls.users_client.list_users(params)[\u0027users\u0027]"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            users \u003d cls.users_client.list_users()[\u0027users\u0027]"},{"line_number":46,"context_line":"        user \u003d [u for u in users if u[\u0027name\u0027] \u003d\u003d name]"},{"line_number":47,"context_line":"        if len(user) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_4ca64311","line":44,"in_reply_to":"9aed3d3a_221d1010","updated":"2016-02-26 16:06:49.000000000","message":"Sorry Matt is was worth a shot but it looks like the v2 client doesn\u0027t support \u0027params\u0027, cause it to break.  I am reverting back to patch set 2.  Thanks for the idea","commit_id":"bc3c76c3bac98f7a043ace86803ebedeb32a27eb"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"9b4eb28eec64081fba43b5cd43fc8345feeda630","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if domain_id:"},{"line_number":42,"context_line":"            params \u003d {\u0027domain_id\u0027: domain_id}"},{"line_number":43,"context_line":"            users \u003d cls.users_client.list_users(params)[\u0027users\u0027]"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            users \u003d cls.users_client.list_users()[\u0027users\u0027]"},{"line_number":46,"context_line":"        user \u003d [u for u in users if u[\u0027name\u0027] \u003d\u003d name]"},{"line_number":47,"context_line":"        if len(user) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_221d1010","line":44,"in_reply_to":"bae84128_3b808946","updated":"2016-02-25 17:07:55.000000000","message":"Oh yeah that\u0027s better.  new patch set will come soon","commit_id":"bc3c76c3bac98f7a043ace86803ebedeb32a27eb"}]}