)]}'
{"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2167c5c7cfd8faed69854dfbdc3412abf9019dc7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        backup \u003d create_backup(volume_id\u003dself.volume[\u0027id\u0027],"},{"line_number":49,"context_line":"                               name\u003dbackup_name)[\u0027backup\u0027]"},{"line_number":50,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":51,"context_line":"        self.admin_volume_client.wait_for_volume_status("},{"line_number":52,"context_line":"            self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":53,"context_line":"        self.backups_adm_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":54,"context_line":"                                                       \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_33699c26","line":51,"updated":"2016-03-22 11:38:09.000000000","message":"You need to put this line before backup creation","commit_id":"486147ffc8c83ac00355c32445b866a43f2452f6"},{"author":{"_account_id":11706,"name":"Poornima Kshirsagar","email":"pkshiras@redhat.com","username":"Poornima"},"change_message_id":"5b5ba1f94da47c17a89f23fd2b5d5cdc57d7b453","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        backup \u003d create_backup(volume_id\u003dself.volume[\u0027id\u0027],"},{"line_number":49,"context_line":"                               name\u003dbackup_name)[\u0027backup\u0027]"},{"line_number":50,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":51,"context_line":"        self.admin_volume_client.wait_for_volume_status("},{"line_number":52,"context_line":"            self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":53,"context_line":"        self.backups_adm_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":54,"context_line":"                                                       \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_878f77cb","line":51,"in_reply_to":"fa0719c6_33699c26","updated":"2016-04-01 12:22:39.000000000","message":"Done","commit_id":"486147ffc8c83ac00355c32445b866a43f2452f6"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"8b3533fea4d44cef1fd495b30f2c9f082bf15c4a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @test.idempotent_id(\u002761975606-cc8a-4a89-8252-9d2d5f3cf099\u0027)"},{"line_number":44,"context_line":"    def test_volume_backup_create_and_force_delete_when_available(self):"},{"line_number":45,"context_line":"        # Create backup, check status and force delete backup"},{"line_number":46,"context_line":"        self.admin_volume_client.wait_for_volume_status("},{"line_number":47,"context_line":"            self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":48,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":49,"context_line":"        create_backup \u003d self.backups_adm_client.create_backup"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_5e8aac64","line":46,"range":{"start_line":46,"start_character":33,"end_line":46,"end_character":55},"updated":"2016-04-01 16:47:08.000000000","message":"This method was removed from this client. Do a rebase of your code and re-run your tests.","commit_id":"dc2c8e6da99be636e10d226475c5b4a9490e930a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"9f231bc8b6cc7b8375393d34f5d89293cfa7126e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @test.idempotent_id(\u002761975606-cc8a-4a89-8252-9d2d5f3cf099\u0027)"},{"line_number":45,"context_line":"    def test_volume_backup_create_and_force_delete_when_available(self):"},{"line_number":46,"context_line":"        # Create backup, check status and force delete backup"},{"line_number":47,"context_line":"        waiters.wait_for_volume_status(self.admin_volume_client,"},{"line_number":48,"context_line":"                                       self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":49,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":50,"context_line":"        create_backup \u003d self.backups_adm_client.create_backup"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_fcd458be","line":47,"updated":"2016-04-21 14:19:30.000000000","message":"Why do we need it? cls.create_volume() already has it inside.","commit_id":"57baeb1ac2e7e3e61e6462b1f41b6bf337fea3c3"},{"author":{"_account_id":11706,"name":"Poornima Kshirsagar","email":"pkshiras@redhat.com","username":"Poornima"},"change_message_id":"491b1da3130372a09ae098844697b199389ff15b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @test.idempotent_id(\u002761975606-cc8a-4a89-8252-9d2d5f3cf099\u0027)"},{"line_number":45,"context_line":"    def test_volume_backup_create_and_force_delete_when_available(self):"},{"line_number":46,"context_line":"        # Create backup, check status and force delete backup"},{"line_number":47,"context_line":"        waiters.wait_for_volume_status(self.admin_volume_client,"},{"line_number":48,"context_line":"                                       self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":49,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":50,"context_line":"        create_backup \u003d self.backups_adm_client.create_backup"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_60901b44","line":47,"in_reply_to":"1a122d0e_fcd458be","updated":"2016-04-26 11:55:15.000000000","message":"Done","commit_id":"57baeb1ac2e7e3e61e6462b1f41b6bf337fea3c3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d19f4c86251cb4e4f7f2d8f582123db10a8beef0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":52,"context_line":"        self.backups_adm_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":53,"context_line":"                                                       \u0027available\u0027)"},{"line_number":54,"context_line":"        self.backups_adm_client.force_delete_backup(backup[\u0027id\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @test.idempotent_id(\u0027a66eb488-8ee1-47d4-8e9f-575a095728c6\u0027)"},{"line_number":57,"context_line":"    def test_volume_backup_create_get_detailed_list_restore_delete(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_c01cf8c3","line":54,"updated":"2016-11-24 02:53:20.000000000","message":"It would be nice to add\n\n self.client.wait_for_resource_deletion(backup[\u0027id\u0027])\n\nfor verifying the backup is completely deleted like the other test test_volume_force_delete_when_volume_is_creating.","commit_id":"248faff02bee6bd730cdb3876ef3f0f3aa1e706d"},{"author":{"_account_id":11706,"name":"Poornima Kshirsagar","email":"pkshiras@redhat.com","username":"Poornima"},"change_message_id":"05b96542b8148ab915a735e924ebd6f1a4d7d8e7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.assertEqual(backup_name, backup[\u0027name\u0027])"},{"line_number":52,"context_line":"        self.backups_adm_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":53,"context_line":"                                                       \u0027available\u0027)"},{"line_number":54,"context_line":"        self.backups_adm_client.force_delete_backup(backup[\u0027id\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @test.idempotent_id(\u0027a66eb488-8ee1-47d4-8e9f-575a095728c6\u0027)"},{"line_number":57,"context_line":"    def test_volume_backup_create_get_detailed_list_restore_delete(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_95273bb5","line":54,"in_reply_to":"5a74a57a_c01cf8c3","updated":"2016-11-28 06:23:29.000000000","message":"Done","commit_id":"248faff02bee6bd730cdb3876ef3f0f3aa1e706d"}],"tempest/lib/services/volume/v2/backups_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fa0b1e1f63060cace845e0fc8e55c47dcfd597fb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":50,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def force_delete_backup(self, backup_id):"},{"line_number":53,"context_line":"        \"\"\"Delete a backup of volume.\"\"\""},{"line_number":54,"context_line":"        post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})"},{"line_number":55,"context_line":"        resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)"},{"line_number":56,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete_backup(self, backup_id):"},{"line_number":59,"context_line":"        \"\"\"Delete a backup of volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_8be0bd2a","line":56,"range":{"start_line":52,"start_character":0,"end_line":56,"end_character":47},"updated":"2016-11-29 07:58:33.000000000","message":"The *v1* API test class inherits from the *v2* one.\nSo this methods is necessary in tempest/lib/services/volume/v1/backups_client.py also.","commit_id":"18e0e7df4f41952d47392a2552641ec2b91d9701"}],"tempest/services/volume/base/base_backups_client.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"9f231bc8b6cc7b8375393d34f5d89293cfa7126e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                raise exceptions.TimeoutException"},{"line_number":114,"context_line":"            time.sleep(self.build_interval)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def force_delete_backup(self, backup_id):"},{"line_number":117,"context_line":"        \"\"\"Force Delete Backup.\"\"\""},{"line_number":118,"context_line":"        post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})"},{"line_number":119,"context_line":"        resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_1cdcb445","line":116,"updated":"2016-04-21 14:19:30.000000000","message":"I don\u0027t know whether it will be better or not, but what about having one \u0027delete_backup\u0027 method?\n\n\n    def delete_backup(self, backup_id, force\u003dFalse):\n        \"\"\"Delete a backup of volume.\"\"\"\n        if force:\n            post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})\n            resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)\n            body \u003d json.loads(body)\n        else:\n            resp, body \u003d self.delete(\u0027backups/%s\u0027 % (str(backup_id)))\n        self.expected_success(202, resp.status)\n        return rest_client.ResponseBody(resp, body)","commit_id":"57baeb1ac2e7e3e61e6462b1f41b6bf337fea3c3"},{"author":{"_account_id":11706,"name":"Poornima Kshirsagar","email":"pkshiras@redhat.com","username":"Poornima"},"change_message_id":"491b1da3130372a09ae098844697b199389ff15b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                raise exceptions.TimeoutException"},{"line_number":114,"context_line":"            time.sleep(self.build_interval)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def force_delete_backup(self, backup_id):"},{"line_number":117,"context_line":"        \"\"\"Force Delete Backup.\"\"\""},{"line_number":118,"context_line":"        post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})"},{"line_number":119,"context_line":"        resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_05ab3976","line":116,"in_reply_to":"1a122d0e_1cdcb445","updated":"2016-04-26 11:55:15.000000000","message":"see volume services methods tempest/tempest/services/volume/base/base_volumes_client.py","commit_id":"57baeb1ac2e7e3e61e6462b1f41b6bf337fea3c3"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"9f231bc8b6cc7b8375393d34f5d89293cfa7126e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def force_delete_backup(self, backup_id):"},{"line_number":117,"context_line":"        \"\"\"Force Delete Backup.\"\"\""},{"line_number":118,"context_line":"        post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})"},{"line_number":119,"context_line":"        resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)"},{"line_number":120,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":121,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_1cf2f406","line":119,"updated":"2016-04-21 14:19:30.000000000","message":"Should we add \u0027body \u003d json.loads(body)\u0027 here like it is done in other methods?","commit_id":"57baeb1ac2e7e3e61e6462b1f41b6bf337fea3c3"},{"author":{"_account_id":11706,"name":"Poornima Kshirsagar","email":"pkshiras@redhat.com","username":"Poornima"},"change_message_id":"491b1da3130372a09ae098844697b199389ff15b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def force_delete_backup(self, backup_id):"},{"line_number":117,"context_line":"        \"\"\"Force Delete Backup.\"\"\""},{"line_number":118,"context_line":"        post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})"},{"line_number":119,"context_line":"        resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)"},{"line_number":120,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":121,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_800bb723","line":119,"in_reply_to":"1a122d0e_1cf2f406","updated":"2016-04-26 11:55:15.000000000","message":"not required","commit_id":"57baeb1ac2e7e3e61e6462b1f41b6bf337fea3c3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d19f4c86251cb4e4f7f2d8f582123db10a8beef0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def force_delete_backup(self, backup_id):"},{"line_number":117,"context_line":"        \"\"\"Force Delete Backup.\"\"\""},{"line_number":118,"context_line":"        post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})"},{"line_number":119,"context_line":"        resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)"},{"line_number":120,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":121,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_c0d798eb","line":119,"range":{"start_line":119,"start_character":53,"end_line":119,"end_character":64},"updated":"2016-11-24 02:53:20.000000000","message":"nit: unnecessary ()","commit_id":"248faff02bee6bd730cdb3876ef3f0f3aa1e706d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d19f4c86251cb4e4f7f2d8f582123db10a8beef0","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        post_body \u003d json.dumps({\u0027os-force_delete\u0027: {}})"},{"line_number":119,"context_line":"        resp, body \u003d self.post(\u0027backups/%s/action\u0027 % (backup_id), post_body)"},{"line_number":120,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":121,"context_line":"        return rest_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_a0c53c3d","line":121,"updated":"2016-11-24 02:53:20.000000000","message":"Cloud you add this method to tempest/lib/services/volume/v2/backups_client.py ?\nThat is a new module path now.","commit_id":"248faff02bee6bd730cdb3876ef3f0f3aa1e706d"}]}