)]}'
{"tempest/common/dynamic_creds.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"81d9792e2210abaaf257437b2c1a1a749bbe0f04","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                      \"trying to clean them up: %s\""},{"line_number":199,"context_line":"                LOG.warning(msg % (tenant_id, cleanup_exception))"},{"line_number":200,"context_line":"            finally:"},{"line_number":201,"context_line":"                raise setup_exception"},{"line_number":202,"context_line":"        return network, subnet, router"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _create_network(self, name, tenant_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_377927c9","line":201,"updated":"2016-02-29 17:04:42.000000000","message":"This is not best practice. We would lose the stack trace. (i.e which method call raised the setup_exception). We really want to \"raise\" not \"raise setup_exception\".\n\nSo I suggest you remove the \"finally\" statement and just \"raise\" in \"one-less\" indentation level.","commit_id":"8c267c62f95a72289bce67f23ef6fefd5c9d5158"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"20d9e06d4fe0d734311c130940e003026bddf1fc","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                      \"trying to clean them up: %s\""},{"line_number":199,"context_line":"                LOG.warning(msg % (tenant_id, cleanup_exception))"},{"line_number":200,"context_line":"            finally:"},{"line_number":201,"context_line":"                raise setup_exception"},{"line_number":202,"context_line":"        return network, subnet, router"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _create_network(self, name, tenant_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_b0bc0b07","line":201,"in_reply_to":"9aed3d3a_377927c9","updated":"2016-02-29 23:17:41.000000000","message":"Done","commit_id":"8c267c62f95a72289bce67f23ef6fefd5c9d5158"}]}