)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d7bfda49348c8a48bd973a2c9f0417426971fbc1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     37967561 (Merge \"Split roles_client for keystone v3 client\")"},{"line_number":2,"context_line":"Author:     Ken\u0027ichi Ohmichi \u003cken-oomichi@wx.jp.nec.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-03-01 15:52:09 -0800"},{"line_number":4,"context_line":"Commit:     Ken\u0027ichi Ohmichi \u003coomichi@mxs.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-02 12:32:51 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make data_processing/baremetal use rest_client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7af24918_a6b0d1f5","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":55},"updated":"2016-03-02 04:06:08.000000000","message":"You use the old email address :)","commit_id":"494a7995eef3fd969ba184e790a10dc3c983313c"}],"tempest/tests/common/test_service_clients.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d7bfda49348c8a48bd973a2c9f0417426971fbc1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @mock.patch(\u0027tempest.lib.common.rest_client.RestClient.__init__\u0027)"},{"line_number":82,"context_line":"    def test_service_client_creations_with_specified_args(self, mock_init):"},{"line_number":83,"context_line":"        test_clients \u003d ["},{"line_number":84,"context_line":"            baremetal_client.BaremetalClient,"},{"line_number":85,"context_line":"            data_processing_client.DataProcessingClient,"},{"line_number":86,"context_line":"            db_flavor_client.DatabaseFlavorsClient,"},{"line_number":87,"context_line":"            db_version_client.DatabaseVersionsClient,"},{"line_number":88,"context_line":"            network_client.NetworkClient,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_2675e1f8","side":"PARENT","line":85,"range":{"start_line":84,"start_character":12,"end_line":85,"end_character":56},"updated":"2016-03-02 04:06:08.000000000","message":"I actually don\u0027t understand why we should remove these tests here.\nThese client classes are still there. So, I think we should still test them.","commit_id":"37967561f001768bc76705cc75409ada8882ef71"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b16af236fa6685a16ff0487f0690a036f86b1518","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @mock.patch(\u0027tempest.lib.common.rest_client.RestClient.__init__\u0027)"},{"line_number":82,"context_line":"    def test_service_client_creations_with_specified_args(self, mock_init):"},{"line_number":83,"context_line":"        test_clients \u003d ["},{"line_number":84,"context_line":"            baremetal_client.BaremetalClient,"},{"line_number":85,"context_line":"            data_processing_client.DataProcessingClient,"},{"line_number":86,"context_line":"            db_flavor_client.DatabaseFlavorsClient,"},{"line_number":87,"context_line":"            db_version_client.DatabaseVersionsClient,"},{"line_number":88,"context_line":"            network_client.NetworkClient,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_21faeb42","side":"PARENT","line":85,"range":{"start_line":84,"start_character":12,"end_line":85,"end_character":56},"in_reply_to":"7af24918_2675e1f8","updated":"2016-03-02 04:36:47.000000000","message":"because this test is just for service_client, not rest_client as the test name.\n\nWe have added this test for verifying all arguments are passed into rest_client via service_client. However, this patch some clients use rest_client directly, so this test becomes meaningless for these clients.\n\nThat is a reason why the migrated clients(into tempest-lib before) are not contained in this test.","commit_id":"37967561f001768bc76705cc75409ada8882ef71"}]}