)]}'
{"tempest/common/negative_rest_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bb0cbfbdc89552ab2ecb4d508d4bd62f56a3c431","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                 build_interval\u003dNone, build_timeout\u003dNone,"},{"line_number":28,"context_line":"                 disable_ssl_certificate_validation\u003dNone,"},{"line_number":29,"context_line":"                 ca_certs\u003dNone, trace_requests\u003dNone):"},{"line_number":30,"context_line":"        region, endpoint_type \u003d self._get_region_and_endpoint_type(service)"},{"line_number":31,"context_line":"        super(NegativeRestClient, self).__init__("},{"line_number":32,"context_line":"            auth_provider,"},{"line_number":33,"context_line":"            service,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_e69d5d0b","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":75},"updated":"2016-03-03 08:13:49.000000000","message":"Same problem can occur here as self._get_region_and_endpoint_type(service) can return None as endpoint_type.\n\nwe should not pass endpoint_type to Restclient if it is None ?","commit_id":"81171cdd4c4d114fe62eac858af486114674dc05"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"914137692f44aabeb4df3959c829f7b46a52a44c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def __init__(self, auth_provider, service, **kwargs):"},{"line_number":27,"context_line":"        region, endpoint_type \u003d self._get_region_and_endpoint_type(service)"},{"line_number":28,"context_line":"        super(NegativeRestClient, self).__init__("},{"line_number":29,"context_line":"            auth_provider, service, region, **kwargs)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _get_region_and_endpoint_type(self, service):"},{"line_number":32,"context_line":"        \"\"\"Returns the region for a specific service\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_1b6226d8","line":29,"range":{"start_line":29,"start_character":44,"end_line":29,"end_character":51},"updated":"2016-03-04 01:50:35.000000000","message":"I think we should add region, endpoint_type fetched from L27 in **kwargs","commit_id":"42bffa782d81c0fd0ec9e5ac6dff63a2557fa5be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"db15976ff094f2dbdf0014bf70239893268af737","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class NegativeRestClient(rest_client.RestClient):"},{"line_number":25,"context_line":"    \"\"\"Version of RestClient that does not raise exceptions.\"\"\""},{"line_number":26,"context_line":"    def __init__(self, auth_provider, service, **kwargs):"},{"line_number":27,"context_line":"        region, endpoint_type \u003d self._get_region_and_endpoint_type(service)"},{"line_number":28,"context_line":"        super(NegativeRestClient, self).__init__("},{"line_number":29,"context_line":"            auth_provider, service, region, endpoint_type\u003dendpoint_type,"},{"line_number":30,"context_line":"            **kwargs)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _get_region_and_endpoint_type(self, service):"},{"line_number":33,"context_line":"        \"\"\"Returns the region for a specific service\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_d47a4bbc","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":21},"updated":"2016-03-04 04:24:34.000000000","message":"\u0027None\u0027 check should be there to avoid sending the None in RestClient. For database cfg does not have endpoint_type and it will be None for them.\nHow about-\n\n        region, endpoint_type \u003d self._get_region_and_endpoint_type(service)\n        if endpoint_type:\n            kwargs.update({\u0027endpoint_type\u0027: endpoint_type})\n        super(NegativeRestClient, self).__init__(\n            auth_provider, service, region, **kwargs)","commit_id":"54030529104c8df82dbc7cd81fe23930b9d81c78"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c12ddcf6c6d4ee29d23fcfbf6bad59a7d34154fc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class NegativeRestClient(rest_client.RestClient):"},{"line_number":25,"context_line":"    \"\"\"Version of RestClient that does not raise exceptions.\"\"\""},{"line_number":26,"context_line":"    def __init__(self, auth_provider, service, **kwargs):"},{"line_number":27,"context_line":"        region, endpoint_type \u003d self._get_region_and_endpoint_type(service)"},{"line_number":28,"context_line":"        super(NegativeRestClient, self).__init__("},{"line_number":29,"context_line":"            auth_provider, service, region, endpoint_type\u003dendpoint_type,"},{"line_number":30,"context_line":"            **kwargs)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _get_region_and_endpoint_type(self, service):"},{"line_number":33,"context_line":"        \"\"\"Returns the region for a specific service\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_03db807d","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"7af24918_44fdc5af","updated":"2016-03-07 23:52:10.000000000","message":"I see your point. It should be fine as per this patch scope. We can fix that if this client is being used by any such cases where endpoint_type is None.","commit_id":"54030529104c8df82dbc7cd81fe23930b9d81c78"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7f4f9d61d3ec5e4d0f1ba377f4f7630b1a1f1f00","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class NegativeRestClient(rest_client.RestClient):"},{"line_number":25,"context_line":"    \"\"\"Version of RestClient that does not raise exceptions.\"\"\""},{"line_number":26,"context_line":"    def __init__(self, auth_provider, service, **kwargs):"},{"line_number":27,"context_line":"        region, endpoint_type \u003d self._get_region_and_endpoint_type(service)"},{"line_number":28,"context_line":"        super(NegativeRestClient, self).__init__("},{"line_number":29,"context_line":"            auth_provider, service, region, endpoint_type\u003dendpoint_type,"},{"line_number":30,"context_line":"            **kwargs)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _get_region_and_endpoint_type(self, service):"},{"line_number":33,"context_line":"        \"\"\"Returns the region for a specific service\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_44fdc5af","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"7af24918_d47a4bbc","updated":"2016-03-04 16:49:35.000000000","message":"Current code is the same as the original behavior, then I don\u0027t the above part is perfectly valid.","commit_id":"54030529104c8df82dbc7cd81fe23930b9d81c78"}]}