)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"a79fbe2afb07b9b9573a53f82918f4dee4cb3251","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We added block_migration\u003d\u0027auto\u0027 support, added a test case to test"},{"line_number":10,"context_line":"block_migration\u003d\u0027auto\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0fb5567cb4f7363465b68b86174b2df039f183d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_63b81f2b","line":12,"updated":"2016-03-03 07:38:02.000000000","message":"This should have cross repo dependency on https://review.openstack.org/#/c/287363/","commit_id":"cd55513e2c996dd6d4b0eaeeb790c4b2006a0228"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"8424cff1b98f637442aaa9b9cc5902ccda1bf5ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new live_migration case to support block_migration\u003dauto"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compute microversion 2.25 supports auto block_migration"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Details: http://docs.openstack.org/developer/nova/api_microversion_history.html#maximum-in-mitaka"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1aa78d24_09ac979d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":55},"updated":"2016-07-13 13:38:09.000000000","message":"please can you add that from 2.25 also the disk_over_commit flag has been removed?","commit_id":"b57c6e33f42b152d42b0c3ac64a17eaf6a1901d2"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"a4480b62c6aeae83f0a2da09f709d53dce8bb1a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new live_migration case to support block_migration\u003dauto"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compute microversion 2.25 supports auto block_migration"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Details: http://docs.openstack.org/developer/nova/api_microversion_history.html#maximum-in-mitaka"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1aa78d24_7ee78246","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":55},"in_reply_to":"1aa78d24_062f42a8","updated":"2016-07-14 17:28:01.000000000","message":"right but as you call out explicitly the block_migration thing I think it is worth for the sake of clarity to report the other change was implemented in 2.25.","commit_id":"b57c6e33f42b152d42b0c3ac64a17eaf6a1901d2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"914ea78f29fbde9e7f74e2250e70d25095a6d4ac","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new live_migration case to support block_migration\u003dauto"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compute microversion 2.25 supports auto block_migration"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Details: http://docs.openstack.org/developer/nova/api_microversion_history.html#maximum-in-mitaka"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1aa78d24_062f42a8","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":55},"in_reply_to":"1aa78d24_09ac979d","updated":"2016-07-14 00:52:25.000000000","message":"actually all details are in link given below. I think should be enough. But i can add anyways.","commit_id":"b57c6e33f42b152d42b0c3ac64a17eaf6a1901d2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"b995e6bd8195413fabcdcd69ff61e8ec749475db","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Details: http://docs.openstack.org/developer/nova/api_microversion_history.html#maximum-in-mitaka"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit adds tests for the same."},{"line_number":15,"context_line":"Also adds the required schema for version 2.25 tests."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I0fb5567cb4f7363465b68b86174b2df039f183d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1aa78d24_d7991dd2","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"updated":"2016-07-15 08:58:00.000000000","message":"Perhaps more details about the versions covered by the schema changes could be useful in the git history.","commit_id":"20a605a601c5189f57ae6bdf3e88ff926bb56b73"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0095ccc12c5ee4a92dda5361af536b15c45eb026","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Details: http://docs.openstack.org/developer/nova/api_microversion_history.html#maximum-in-mitaka"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit adds tests for the same."},{"line_number":15,"context_line":"Also adds the required schema for version 2.25 tests."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I0fb5567cb4f7363465b68b86174b2df039f183d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"dada55a8_6c9393fb","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"in_reply_to":"1aa78d24_d7991dd2","updated":"2016-07-17 13:01:46.000000000","message":"Done.","commit_id":"20a605a601c5189f57ae6bdf3e88ff926bb56b73"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f434d62a4e412a89e5cc3ff065f5ba9ea80f20c0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This commit adds tests for the same."},{"line_number":15,"context_line":"Also adds the below required schema for version 2.25 tests."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- 2.3 Schema. Details:"},{"line_number":18,"context_line":"http://docs.openstack.org/developer/nova/api_microversion_history.html#maximum-in-kilo"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- 2.16 Schema. Details:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dada55a8_a0ae19e5","line":17,"updated":"2016-07-22 14:14:08.000000000","message":"If you need to respin, this also closes bug 1600186.","commit_id":"e07eaccf844e3dbcb992ec26a085d5c37757ea85"}],"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"ffa7f420e8837f563314c31cf444d29e5cb4f9b1","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.idempotent_id(\u00278ab1223c-3dab-4660-a878-2b780d66f937\u0027)"},{"line_number":134,"context_line":"    def test_live_block_migration_auto(self):"},{"line_number":135,"context_line":"        self._test_live_migration(block_migration\u003d\u0027auto\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @test.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"},{"line_number":138,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_06b31eea","line":135,"range":{"start_line":135,"start_character":34,"end_line":135,"end_character":56},"updated":"2016-03-03 11:13:50.000000000","message":"I think we need to set the API version to 2.25 otherwise we get an error when the nova API tries to interpret the \u0027auto\u0027 value using the srtutils.bool_from_string:\nhttps://github.com/openstack/nova/blob/f18a46c072b964b6c9ceffc9832e4221f64dc9c4/nova/api/openstack/compute/migrate_server.py#L85","commit_id":"1994464d8b57a6a3f981cf421b6869ce9361caf1"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"222be06482c1dd6cdb18c0ebb45d2a135caefc91","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.idempotent_id(\u00278ab1223c-3dab-4660-a878-2b780d66f937\u0027)"},{"line_number":134,"context_line":"    def test_live_block_migration_auto(self):"},{"line_number":135,"context_line":"        self._test_live_migration(block_migration\u003d\u0027auto\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @test.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"},{"line_number":138,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_d298a96c","line":135,"range":{"start_line":135,"start_character":34,"end_line":135,"end_character":56},"in_reply_to":"7af24918_06b31eea","updated":"2016-03-03 21:55:52.000000000","message":"agree, checked logs, now header is: \u0027x-openstack-nova-api-version\u0027: \u00272.1\u0027 which cause test to fail","commit_id":"1994464d8b57a6a3f981cf421b6869ce9361caf1"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"437093880b939ea4c8cb2fdfd9764225782b2f11","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.idempotent_id(\u00278ab1223c-3dab-4660-a878-2b780d66f937\u0027)"},{"line_number":134,"context_line":"    def test_live_block_migration_auto(self):"},{"line_number":135,"context_line":"        self._test_live_migration(block_migration\u003d\u0027auto\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @test.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"},{"line_number":138,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.pause,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_1b34e6db","line":135,"range":{"start_line":135,"start_character":34,"end_line":135,"end_character":56},"in_reply_to":"7af24918_d298a96c","updated":"2016-03-04 01:48:53.000000000","message":"hi Andrea, Timofey\n\nthanks for point me out, I talked with qa team. I think my patch need to be rebased on https://review.openstack.org/#/c/284414/ and a new sub  class test_live_migraton_v225 need to be implemented.","commit_id":"1994464d8b57a6a3f981cf421b6869ce9361caf1"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"8424cff1b98f637442aaa9b9cc5902ccda1bf5ed","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _migrate_server_to(self, server_id, dest_host, volume_backed\u003dFalse):"},{"line_number":70,"context_line":"        kwargs \u003d dict()"},{"line_number":71,"context_line":"        if self.disk_over_commit is not None:"},{"line_number":72,"context_line":"            kwargs[\u0027disk_over_commit\u0027] \u003d self.disk_over_commit"},{"line_number":73,"context_line":"        if self.block_migration is None:"},{"line_number":74,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":75,"context_line":"                               block_migration_for_live_migration and"},{"line_number":76,"context_line":"                               not volume_backed)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_6998bbc0","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":40},"updated":"2016-07-13 13:38:09.000000000","message":"minor: please be consistent in using the if logic, the logic at line #73 is opposite to the one at line #71.","commit_id":"b57c6e33f42b152d42b0c3ac64a17eaf6a1901d2"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"a4480b62c6aeae83f0a2da09f709d53dce8bb1a8","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _migrate_server_to(self, server_id, dest_host, volume_backed\u003dFalse):"},{"line_number":70,"context_line":"        kwargs \u003d dict()"},{"line_number":71,"context_line":"        if self.disk_over_commit is not None:"},{"line_number":72,"context_line":"            kwargs[\u0027disk_over_commit\u0027] \u003d self.disk_over_commit"},{"line_number":73,"context_line":"        if self.block_migration is None:"},{"line_number":74,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":75,"context_line":"                               block_migration_for_live_migration and"},{"line_number":76,"context_line":"                               not volume_backed)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_de3cb6c1","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":40},"in_reply_to":"1aa78d24_6659e65b","updated":"2016-07-14 17:28:01.000000000","message":"sorry I wasn\u0027t clear, in the first if you have \"if ... is not None\" in the second you have a \"if ...is None\" and you have also an else, I was proposing to invert the logic in the second If to use the same pattern of the first one \" if is not None\".","commit_id":"b57c6e33f42b152d42b0c3ac64a17eaf6a1901d2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"914ea78f29fbde9e7f74e2250e70d25095a6d4ac","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _migrate_server_to(self, server_id, dest_host, volume_backed\u003dFalse):"},{"line_number":70,"context_line":"        kwargs \u003d dict()"},{"line_number":71,"context_line":"        if self.disk_over_commit is not None:"},{"line_number":72,"context_line":"            kwargs[\u0027disk_over_commit\u0027] \u003d self.disk_over_commit"},{"line_number":73,"context_line":"        if self.block_migration is None:"},{"line_number":74,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":75,"context_line":"                               block_migration_for_live_migration and"},{"line_number":76,"context_line":"                               not volume_backed)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_6659e65b","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":40},"in_reply_to":"1aa78d24_6998bbc0","updated":"2016-07-14 00:52:25.000000000","message":"Those are not opposite. first is for disk_over_commit and second for disk_over_commit","commit_id":"b57c6e33f42b152d42b0c3ac64a17eaf6a1901d2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"32185ecd6a77949ef7d50109a6f11029c91d7cbe","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _migrate_server_to(self, server_id, dest_host, volume_backed\u003dFalse):"},{"line_number":70,"context_line":"        kwargs \u003d dict()"},{"line_number":71,"context_line":"        if self.disk_over_commit is not None:"},{"line_number":72,"context_line":"            kwargs[\u0027disk_over_commit\u0027] \u003d self.disk_over_commit"},{"line_number":73,"context_line":"        if self.block_migration is None:"},{"line_number":74,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":75,"context_line":"                               block_migration_for_live_migration and"},{"line_number":76,"context_line":"                               not volume_backed)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            block_migration \u003d self.block_migration"},{"line_number":79,"context_line":"        body \u003d self.admin_servers_client.live_migrate_server("},{"line_number":80,"context_line":"            server_id, host\u003ddest_host, block_migration\u003dblock_migration,"},{"line_number":81,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_b490cf43","line":78,"range":{"start_line":71,"start_character":8,"end_line":78,"end_character":50},"updated":"2016-07-15 08:57:16.000000000","message":"I\u0027m not convinced you need both disk_over_commit and block_migration to be defined at class level. You could set only block_migration, only in the new class, and then:\n\nblock_migration \u003d getattr(self, block_migration, None)\nIf block_migration is None:\n    kwargs[\u0027disk_over_commit\u0027] \u003d False\n    block_migration \u003d (CONF.compute_feature_enabled.\n                                 block_migration_for_live_migration and\n                                 not volume_backed)","commit_id":"20a605a601c5189f57ae6bdf3e88ff926bb56b73"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"38e5e07b1e0a40396754aa2183847d641deef606","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _migrate_server_to(self, server_id, dest_host, volume_backed\u003dFalse):"},{"line_number":70,"context_line":"        kwargs \u003d dict()"},{"line_number":71,"context_line":"        if self.disk_over_commit is not None:"},{"line_number":72,"context_line":"            kwargs[\u0027disk_over_commit\u0027] \u003d self.disk_over_commit"},{"line_number":73,"context_line":"        if self.block_migration is None:"},{"line_number":74,"context_line":"            block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":75,"context_line":"                               block_migration_for_live_migration and"},{"line_number":76,"context_line":"                               not volume_backed)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            block_migration \u003d self.block_migration"},{"line_number":79,"context_line":"        body \u003d self.admin_servers_client.live_migrate_server("},{"line_number":80,"context_line":"            server_id, host\u003ddest_host, block_migration\u003dblock_migration,"},{"line_number":81,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_8c09a7e0","line":78,"range":{"start_line":71,"start_character":8,"end_line":78,"end_character":50},"in_reply_to":"1aa78d24_b490cf43","updated":"2016-07-17 12:15:46.000000000","message":"Yea, much better way. Thanks.\n\nDone","commit_id":"20a605a601c5189f57ae6bdf3e88ff926bb56b73"}]}