)]}'
{"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"850895318e30941255fd13f6c396d2f987563d7b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def _get_host_for_server(self, server_id):"},{"line_number":63,"context_line":"        return self._get_server_details(server_id)[self._host_key]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _migrate_server_to(self, server_id, dest_host, volume_backed):"},{"line_number":66,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":67,"context_line":"                           block_migration_for_live_migration and"},{"line_number":68,"context_line":"                           not volume_backed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_8e38b5d4","line":65,"range":{"start_line":65,"start_character":55,"end_line":65,"end_character":68},"updated":"2016-03-04 00:32:30.000000000","message":"How about setting False as the default value instead?\n\nIf doing that, the default values becomes consistent in this test class and easy to maintain the code in long-term.","commit_id":"536fc99bfe4a8b0423176ba8fad6a7ae53af0092"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"47e6c62c7b5d1ed788705fc9530c8b685a4711a1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def _get_host_for_server(self, server_id):"},{"line_number":63,"context_line":"        return self._get_server_details(server_id)[self._host_key]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _migrate_server_to(self, server_id, dest_host, volume_backed):"},{"line_number":66,"context_line":"        block_migration \u003d (CONF.compute_feature_enabled."},{"line_number":67,"context_line":"                           block_migration_for_live_migration and"},{"line_number":68,"context_line":"                           not volume_backed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_5ba13893","line":65,"range":{"start_line":65,"start_character":55,"end_line":65,"end_character":68},"in_reply_to":"7af24918_8e38b5d4","updated":"2016-03-04 12:36:16.000000000","message":"Done","commit_id":"536fc99bfe4a8b0423176ba8fad6a7ae53af0092"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"850895318e30941255fd13f6c396d2f987563d7b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.volumes_client.wait_for_volume_status(volume_id, \u0027available\u0027)"},{"line_number":87,"context_line":"        self.volumes_client.delete_volume(volume_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _test_live_migration(self, state\u003d\u0027ACTIVE\u0027, volume_backed\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Tests live migration between two hosts."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        Requires CONF.compute_feature_enabled.live_migration to be True."}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_e3051214","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":70},"updated":"2016-03-04 00:32:30.000000000","message":"In this method, the default value is False.","commit_id":"536fc99bfe4a8b0423176ba8fad6a7ae53af0092"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"47e6c62c7b5d1ed788705fc9530c8b685a4711a1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.volumes_client.wait_for_volume_status(volume_id, \u0027available\u0027)"},{"line_number":87,"context_line":"        self.volumes_client.delete_volume(volume_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _test_live_migration(self, state\u003d\u0027ACTIVE\u0027, volume_backed\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Tests live migration between two hosts."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        Requires CONF.compute_feature_enabled.live_migration to be True."}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_bbacbc8c","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":70},"in_reply_to":"7af24918_e3051214","updated":"2016-03-04 12:36:16.000000000","message":"Done","commit_id":"536fc99bfe4a8b0423176ba8fad6a7ae53af0092"}]}