)]}'
{"tempest/tests/test_decorators.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"40f556ee9a724392edb1cd8def15d2c2a705cc78","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        if expected_to_skip:"},{"line_number":202,"context_line":"            self.assertRaises(testtools.TestCase.skipException, t.test_bar)"},{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            self.assertEqual(t.test_bar(), 0)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_requires_ext_decorator(self):"},{"line_number":207,"context_line":"        self._test_requires_ext_helper(expected_to_skip\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_0795ac31","line":204,"range":{"start_line":204,"start_character":12,"end_line":204,"end_character":45},"updated":"2016-03-10 12:19:38.000000000","message":"Strange it was skipped not failed. This checks itself is wrong. This is skipping the unit tests itself which is supposed to fail if skipped :).\n\nelse part should be something like below\n\n      else:\n          try:\n              t.test_bar()\n          except testtools.TestCase.skipException as e:\n              raise testtools.TestCase.failureException(\"Not supposed to skip\")","commit_id":"2be4325b9c418b3f61ad1959388175b86c708e86"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"595679a665bb5cb6e1c7da94e035113ce8bd8608","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        if expected_to_skip:"},{"line_number":202,"context_line":"            self.assertRaises(testtools.TestCase.skipException, t.test_bar)"},{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            self.assertEqual(t.test_bar(), 0)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_requires_ext_decorator(self):"},{"line_number":207,"context_line":"        self._test_requires_ext_helper(expected_to_skip\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_8da180ac","line":204,"range":{"start_line":204,"start_character":12,"end_line":204,"end_character":45},"in_reply_to":"5aef4532_0795ac31","updated":"2016-03-29 14:45:48.000000000","message":"You are right ! Nice catch !","commit_id":"2be4325b9c418b3f61ad1959388175b86c708e86"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"7498ea864f52abcea39343dbb1f36abea41956de","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            try:"},{"line_number":205,"context_line":"                self.assertEqual(t.test_bar(), 0)"},{"line_number":206,"context_line":"            except testtools.TestCase.skipException:"},{"line_number":207,"context_line":"                # We caught a skipException but we didn\"t expect to skip"},{"line_number":208,"context_line":"                # this test so, raise a hard test failure instead. "},{"line_number":209,"context_line":"                raise testtools.TestCase.failureException("},{"line_number":210,"context_line":"                    \"Not supposed to skip\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_63ab54d7","line":207,"updated":"2016-03-29 17:10:04.000000000","message":"s/didn\"t/didn\u0027t","commit_id":"edcf6a722170c0ef6935bc4ec3eae9b36918362d"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"7498ea864f52abcea39343dbb1f36abea41956de","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.assertEqual(t.test_bar(), 0)"},{"line_number":206,"context_line":"            except testtools.TestCase.skipException:"},{"line_number":207,"context_line":"                # We caught a skipException but we didn\"t expect to skip"},{"line_number":208,"context_line":"                # this test so, raise a hard test failure instead. "},{"line_number":209,"context_line":"                raise testtools.TestCase.failureException("},{"line_number":210,"context_line":"                    \"Not supposed to skip\")"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_23f79cf6","line":208,"updated":"2016-03-29 17:10:04.000000000","message":"remove \u0027,\u0027 or put \u0027,\u0027 after test? Also, please remove trailing space.","commit_id":"edcf6a722170c0ef6935bc4ec3eae9b36918362d"}]}