)]}'
{"tempest/api/volume/v2/test_volumes_list.py":[{"author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"change_message_id":"e95d3c89f83388f805458269ab429a995a8aabe7","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        verify_volume_list \u003d sorted_times[:index_marker]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # Validating the expected list is the same like the observed list"},{"line_number":220,"context_line":"        self.assertEqual(verify_volume_list,"},{"line_number":221,"context_line":"                         sorted(map(lambda x: x[\u0027created_at\u0027],"},{"line_number":222,"context_line":"                                    vol_with_marker)),"},{"line_number":223,"context_line":"                         \"Failed to list volume details by marker\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_fd0ada24","line":220,"updated":"2016-03-10 10:26:54.000000000","message":"assertEqual(expected,observed)","commit_id":"c4e49305fae4950eca86556bd18ffdb28ca679d7"},{"author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"change_message_id":"e95d3c89f83388f805458269ab429a995a8aabe7","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        self.assertEqual(verify_volume_list,"},{"line_number":221,"context_line":"                         sorted(map(lambda x: x[\u0027created_at\u0027],"},{"line_number":222,"context_line":"                                    vol_with_marker)),"},{"line_number":223,"context_line":"                         \"Failed to list volume details by marker\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_7d1eca70","line":223,"range":{"start_line":223,"start_character":25,"end_line":223,"end_character":66},"updated":"2016-03-10 10:26:54.000000000","message":"These strings could be pulled out into variables since they are used more than once.","commit_id":"c4e49305fae4950eca86556bd18ffdb28ca679d7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e7e35948ee5115a2378a56be83247dd6f08eabba","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def test_volume_list_with_detail_param_marker(self):"},{"line_number":192,"context_line":"        # Creating a dictionary which will fetch the volumes ids and the time"},{"line_number":193,"context_line":"        # they were created"},{"line_number":194,"context_line":"        volumes_times \u003d {}"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        volume_list_local \u003d self.client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]"},{"line_number":197,"context_line":"        for vol in volume_list_local:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_2abd9868","line":194,"updated":"2016-03-14 10:35:22.000000000","message":"Please use a dict comprehension:\n\nvolumes_times \u003d {\n  vol[\u0027created_at\u0027]: vol[\u0027id\u0027] \n    for vol in self.client.list_volumes(detail\u003dTrue)[\u0027volumes\u0027]\n}","commit_id":"f87939b1ade184bcd9df1deb5593144603c7542a"},{"author":{"_account_id":19587,"name":"Joshua White","email":"joshua.l.white@intel.com","username":"jwhite"},"change_message_id":"3bacb4d3a73c69527f8fb458bdd5dc0a34da3417","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        # Validating the expected list is the same like the observed list"},{"line_number":222,"context_line":"        self.assertEqual(verify_volume_list,"},{"line_number":223,"context_line":"                         sorted(map(lambda x: x[\u0027created_at\u0027],"},{"line_number":224,"context_line":"                                    vol_with_marker)), failed_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_5278abf2","line":224,"range":{"start_line":224,"start_character":55,"end_line":224,"end_character":65},"updated":"2016-03-13 17:31:17.000000000","message":"Saw prior comment, but don\u0027t understand why it needed to be a variable. Still, looks good.","commit_id":"f87939b1ade184bcd9df1deb5593144603c7542a"},{"author":{"_account_id":19587,"name":"Joshua White","email":"joshua.l.white@intel.com","username":"jwhite"},"change_message_id":"ac095939fa31ad59df22c7337504419f91cd7ef3","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        index_marker \u003d self.volume_id_list.index(random_volume)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # The expected list with marker parameter"},{"line_number":206,"context_line":"        verify_volume_list \u003d self.volume_id_list[:index_marker]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        failed_msg \u003d \"Failed to list volume details by marker\""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_ed782792","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":26},"updated":"2016-03-15 15:36:43.000000000","message":"Looks good.  I noticed that if it randomly chooses the 0 index of volume_id_list neither vol_with_marker or verify_volume_list will be populated. Which isn\u0027t necessarily bad I think, because its still doing what it\u0027s intended to do. However, just wanted to point it out.","commit_id":"4c55e57749302cc0c714502aa4a7eabf5b9e9b8f"}]}