)]}'
{"tools/generate-tempest-plugins-list.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0d3728f970403653c8a8c16c6123c891ae685b46","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        False"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"r \u003d requests.get(url)"},{"line_number":60,"context_line":"projects \u003d sorted(filter(is_in_openstack_namespace, json.loads(r.text[4:])))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"found_plugins \u003d filter(has_tempest_plugin, projects)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_fcd460be","line":60,"updated":"2016-03-11 10:36:35.000000000","message":"It seems you really have to strip the first 4 bytes, but you should add a code comment about it.","commit_id":"38d9a4e62099cb517f3eb8044284385bcb1d3120"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0d3728f970403653c8a8c16c6123c891ae685b46","unresolved":false,"context_lines":[{"line_number":62,"context_line":"found_plugins \u003d filter(has_tempest_plugin, projects)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"for project in found_plugins:"},{"line_number":65,"context_line":"    print(project[10:])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_7ca69054","line":65,"updated":"2016-03-11 10:36:35.000000000","message":"Why this \u0027[10:]\u0027 ?","commit_id":"38d9a4e62099cb517f3eb8044284385bcb1d3120"},{"author":{"_account_id":16272,"name":"Clint Adams","email":"clint@gcfm.net","username":"clint"},"change_message_id":"e58a78e093871ec72e3510c8c8348a440042b056","unresolved":false,"context_lines":[{"line_number":62,"context_line":"found_plugins \u003d filter(has_tempest_plugin, projects)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"for project in found_plugins:"},{"line_number":65,"context_line":"    print(project[10:])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_20ccbb34","line":65,"in_reply_to":"3afc51ec_aaceec57","updated":"2016-03-12 06:21:59.000000000","message":"Matthew is correct.  I can comment this too.","commit_id":"38d9a4e62099cb517f3eb8044284385bcb1d3120"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"f53000ffc61961cd2f2bfccf46c4b85f4ce84a8e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"found_plugins \u003d filter(has_tempest_plugin, projects)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"for project in found_plugins:"},{"line_number":65,"context_line":"    print(project[10:])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_aaceec57","line":65,"in_reply_to":"5aef4532_7ca69054","updated":"2016-03-12 02:54:12.000000000","message":"I think that\u0027s to drop openstack/ from the front of the string for the project name","commit_id":"38d9a4e62099cb517f3eb8044284385bcb1d3120"}],"tools/generate-tempest-plugins-list.sh":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1efff6055c050485d298d1de0aa5e8aeff6678c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_062f74a1","line":1,"updated":"2016-03-24 11:18:01.000000000","message":"This file should be executable.\n\nAlso prefer this form:\n  #!/bin/bash\n  set -xue\n\nOtherwise if one invokes this script with bash generate-tempest-plugins-list.sh then the \"-x -e\" options are not taken into account.","commit_id":"d403087fd229140d4f4dc9e12a04ef9d873d590d"},{"author":{"_account_id":16272,"name":"Clint Adams","email":"clint@gcfm.net","username":"clint"},"change_message_id":"f79a70507861bd318c9206f9014d839f14b388bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development Company, L.P."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba0121b8_d9e19dd2","line":1,"in_reply_to":"fa0719c6_062f74a1","updated":"2016-03-29 00:11:06.000000000","message":"Though the proposal job will be setting -xe I can\u0027t see the case for forcing either.","commit_id":"d403087fd229140d4f4dc9e12a04ef9d873d590d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1efff6055c050485d298d1de0aa5e8aeff6678c1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"fi"},{"line_number":60,"context_line":") \u003e doc/source/plugin-registry.rst"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if [[ -n ${1} ]]; then"},{"line_number":63,"context_line":"    cp doc/source/plugin-registry.rst ${1}/doc/source/plugin-registry.rst"},{"line_number":64,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_49021f0b","line":62,"updated":"2016-03-24 11:18:01.000000000","message":"I tried to run this script it failed with:\n\n  jordan@jordan-XPS13:/opt/stack/tempest/tools (master %\u003e)$ bash generate-tempest-plugins-list.sh\ngenerate-tempest-plugins-list.sh: line 60: doc/source/plugin-registry.rst: No such file or directory\n\nThen I tried:\n  jordan@jordan-XPS13:/opt/stack/tempest/tools (master %\u003e)$ bash -x generate-tempest-plugins-list.sh\ngenerate-tempest-plugins-list.sh: line 60: doc/source/plugin-registry.rst: No such file or directory\n+ [[ -n \u0027\u0027 ]]\n\n\nI am confused. What is this $1 argument ?","commit_id":"d403087fd229140d4f4dc9e12a04ef9d873d590d"},{"author":{"_account_id":16272,"name":"Clint Adams","email":"clint@gcfm.net","username":"clint"},"change_message_id":"20a7f51f7083e6f04f943422c426883aa7d50dbc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"fi"},{"line_number":60,"context_line":") \u003e doc/source/plugin-registry.rst"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"if [[ -n ${1} ]]; then"},{"line_number":63,"context_line":"    cp doc/source/plugin-registry.rst ${1}/doc/source/plugin-registry.rst"},{"line_number":64,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_0a7c92b3","line":62,"in_reply_to":"fa0719c6_49021f0b","updated":"2016-03-24 13:01:43.000000000","message":"$1 is so the proposal job can copy the generated file to the correct git checkout to submit it to gerrit.\n\nAs for your error, you\u0027ll probably get better results if your working directory is /opt/stack/tempest","commit_id":"d403087fd229140d4f4dc9e12a04ef9d873d590d"}]}