)]}'
{"tempest/tests/test_images.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d87512e79723197c71ca23d432b7b1985a31cbf4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"        #Create a new image after server is deleted"},{"line_number":76,"context_line":"            name \u003d rand_name(\u0027image\u0027)"},{"line_number":77,"context_line":"            meta \u003d {\u0027image_type\u0027: \u0027test\u0027}"},{"line_number":78,"context_line":"            resp, body \u003d self.client.create_image(server[\u0027id\u0027], name, meta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAD3%2F%2F%2Fes%3D","line":75,"updated":"2012-01-10 14:19:08.000000000","message":"Please make the comment indent and space after # consistent with other comments. This should have a space after # and should be indented to align with the code below it.","commit_id":"3fe661020f5b4b7da918c9221d2d6d905a34646c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d87512e79723197c71ca23d432b7b1985a31cbf4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            self.client.wait_for_image_status(image_id, \u0027ACTIVE\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        #Run Get Image"},{"line_number":85,"context_line":"            resp, image \u003d self.client.get_image(image_id)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        except:"},{"line_number":88,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAD3%2F%2F%2Few%3D","line":85,"updated":"2012-01-10 14:19:08.000000000","message":"What is the above line asserting?","commit_id":"3fe661020f5b4b7da918c9221d2d6d905a34646c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d87512e79723197c71ca23d432b7b1985a31cbf4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            self.fail(\"should not create snapshot from deleted instance\")"},{"line_number":92,"context_line":"        #Teardown"},{"line_number":93,"context_line":"            self.client.delete_image(image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAD3%2F%2F%2Fe0%3D","line":93,"updated":"2012-01-10 14:19:08.000000000","message":"This needs to be left-indented. As-is, this line will never run, since self.fail() will assert and thus jump out of this method.","commit_id":"3fe661020f5b4b7da918c9221d2d6d905a34646c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"394bd400498396c1e4b0d93ba06993591d36362f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            # Create a new image after server is deleted"},{"line_number":76,"context_line":"            name \u003d rand_name(\u0027image\u0027)"},{"line_number":77,"context_line":"            meta \u003d {\u0027image_type\u0027: \u0027test\u0027}"},{"line_number":78,"context_line":"            resp, body \u003d self.client.create_image(server[\u0027id\u0027], name, meta)"},{"line_number":79,"context_line":"            image_id \u003d _parse_image_id(resp[\u0027location\u0027])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"            self.client.wait_for_image_resp_code(image_id, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2FaI%3D","line":78,"updated":"2012-01-10 17:50:58.000000000","message":"I *think* that we should be able to remove the wait_for_XXX methods below and just verify that an assertion (ComputeFault?) was thrown by create_image() above, right?","commit_id":"f6d93ed9b7bb97f0fe04b25c27ab9bc0a19ac5e4"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"1856bd376d14e39c12939360815474813acecaf5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                                         self.flavor_ref)"},{"line_number":69,"context_line":"        self.servers_client.wait_for_server_status(server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Delete setrver before trying to create server"},{"line_number":72,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FQs%3D","line":71,"updated":"2012-01-10 22:25:21.000000000","message":"/setrver/server/","commit_id":"800e5a4439b7b1c567107d1ec12984b0fd6aab03"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"1856bd376d14e39c12939360815474813acecaf5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # Delete setrver before trying to create server"},{"line_number":72,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            # Create a new image after server is deleted"},{"line_number":76,"context_line":"            name \u003d rand_name(\u0027image\u0027)"},{"line_number":77,"context_line":"            meta \u003d {\u0027image_type\u0027: \u0027test\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FQo%3D","line":74,"updated":"2012-01-10 22:25:21.000000000","message":"Please use assertRaises here rather than the try/except/else syntax. It is a much cleaner approach to ensuring a specific exception is raised.","commit_id":"800e5a4439b7b1c567107d1ec12984b0fd6aab03"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"43fa663b3b31805cae5604a3e0a92750f688dd5e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # Delete setrver before trying to create server"},{"line_number":72,"context_line":"        self.servers_client.delete_server(server[\u0027id\u0027])"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            # Create a new image after server is deleted"},{"line_number":76,"context_line":"            name \u003d rand_name(\u0027image\u0027)"},{"line_number":77,"context_line":"            meta \u003d {\u0027image_type\u0027: \u0027test\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAD3%2F%2F%2FOU%3D","line":74,"in_reply_to":"AAAAD3%2F%2F%2FQo%3D","updated":"2012-01-10 23:19:51.000000000","message":"True, self.assertRaises is cleaner. However, the disadvantage is that you cannot give a descriptive failure message with assertRaises like you can with, say, self.fail() or self.assertEqual() and the like. :)","commit_id":"800e5a4439b7b1c567107d1ec12984b0fd6aab03"}]}