)]}'
{"tempest/common/glance_http.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"a04ae810731133be76357e79895100bf49899a6f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    def connect(self):"},{"line_number":308,"context_line":"        \"\"\"Connect to SSL port and apply per-connection parameters.\"\"\""},{"line_number":309,"context_line":"        result \u003d socket.getaddrinfo(self.host, self.port, 0,"},{"line_number":310,"context_line":"                                    socket.SOCK_STREAM)"},{"line_number":311,"context_line":"        if result:"},{"line_number":312,"context_line":"            socket_family \u003d result[0][0]"},{"line_number":313,"context_line":"            if socket_family \u003d\u003d socket.AF_INET6:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_e08577ad","line":310,"updated":"2016-03-16 22:12:40.000000000","message":"Per RFC 3484:\n\n\n   Well-behaved applications SHOULD iterate through the list of\n   addresses returned from getaddrinfo() until they find a working\n   address.\n\nDo we take this into consideration? Meaning, do we try the first entry returned by getaddrinfo(), and if that doesn\u0027t work, try the following entries until we have a successful connection?","commit_id":"5976fceabd0e3698e74894eae66fc38dc6e88665"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fd235f0fddcf54a5c4b93ad1b4e46ec1e668b48b","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    def connect(self):"},{"line_number":308,"context_line":"        \"\"\"Connect to SSL port and apply per-connection parameters.\"\"\""},{"line_number":309,"context_line":"        result \u003d socket.getaddrinfo(self.host, self.port, 0,"},{"line_number":310,"context_line":"                                    socket.SOCK_STREAM)"},{"line_number":311,"context_line":"        if result:"},{"line_number":312,"context_line":"            socket_family \u003d result[0][0]"},{"line_number":313,"context_line":"            if socket_family \u003d\u003d socket.AF_INET6:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_3d53a218","line":310,"in_reply_to":"1af94dfe_e08577ad","updated":"2016-03-24 13:09:12.000000000","message":"This is addressed in this patchset.","commit_id":"5976fceabd0e3698e74894eae66fc38dc6e88665"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bdda0705b457a60aaee8f0379b178f8281f69401","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                sock \u003d socket.socket(socket.AF_INET6, socket.SOCK_STREAM)"},{"line_number":315,"context_line":"            else:"},{"line_number":316,"context_line":"                sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":317,"context_line":"        else:"},{"line_number":318,"context_line":"            # If due to some reason the address lookup fails - we still connect"},{"line_number":319,"context_line":"            # to IPv4 socket. This retains the older behavior."},{"line_number":320,"context_line":"            sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":321,"context_line":"        if self.timeout is not None:"},{"line_number":322,"context_line":"            # \u00270\u0027 microseconds"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_4378b52a","line":319,"range":{"start_line":317,"start_character":0,"end_line":319,"end_character":61},"updated":"2016-03-16 22:38:12.000000000","message":"This comment seems unclear for me, especially \"some reason\".\n\nAccording to glance code where calls getaddrinfo, the following comment exists:\n\n    # TODO(jaypipes): eventlet\u0027s greened socket module does not actually\n    # support IPv6 in getaddrinfo(). We need to get around this in the\n    # future or monitor upstream for a fix\n\nSo does here say the above jay\u0027s meaning?\nIf so, it is better to clarify it here like jay\u0027s comment.","commit_id":"5976fceabd0e3698e74894eae66fc38dc6e88665"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"fd235f0fddcf54a5c4b93ad1b4e46ec1e668b48b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                sock \u003d socket.socket(socket.AF_INET6, socket.SOCK_STREAM)"},{"line_number":315,"context_line":"            else:"},{"line_number":316,"context_line":"                sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":317,"context_line":"        else:"},{"line_number":318,"context_line":"            # If due to some reason the address lookup fails - we still connect"},{"line_number":319,"context_line":"            # to IPv4 socket. This retains the older behavior."},{"line_number":320,"context_line":"            sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":321,"context_line":"        if self.timeout is not None:"},{"line_number":322,"context_line":"            # \u00270\u0027 microseconds"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_dd99c6c5","line":319,"range":{"start_line":317,"start_character":0,"end_line":319,"end_character":61},"in_reply_to":"1af94dfe_4378b52a","updated":"2016-03-24 13:09:12.000000000","message":"The comment above is a reminder that they *don\u0027t* use getaddrinfo from eventlet because it doesn\u0027t support IPv6.  They use the socket.getaddrinfo method.","commit_id":"5976fceabd0e3698e74894eae66fc38dc6e88665"}]}