)]}'
{"tempest/lib/common/api_version_request.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"17c81e98b6910aaedc478256b90d57b3fc9f1696","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Defines the minimum and maximum version of the API across all of the"},{"line_number":21,"context_line":"# REST API. The format of the version is:"},{"line_number":22,"context_line":"# X.Y where:"},{"line_number":23,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_2a1d76bd","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":9},"updated":"2016-03-17 02:19:54.000000000","message":"Why here should be Defines?","commit_id":"7d866ab1a8985991e5f9ff476b32d118173af584"}],"tempest/lib/common/api_version_utils.py":[{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"de516935ae98a3a54a76bb6bdacaa7511ee93c97","unresolved":false,"context_lines":[{"line_number":101,"context_line":"def assert_version_header_matches_request(api_microversion_header_name,"},{"line_number":102,"context_line":"                                          api_microversion,"},{"line_number":103,"context_line":"                                          response_header):"},{"line_number":104,"context_line":"    \"\"\"Checks API microversion in resposne header"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    Verifies whether microversion is present in response header"},{"line_number":107,"context_line":"    and with specified \u0027api_microversion\u0027 value."}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_97650e47","line":104,"range":{"start_line":104,"start_character":34,"end_line":104,"end_character":42},"updated":"2016-03-16 06:24:52.000000000","message":"response","commit_id":"2709e93c582d230cdafbc9d647fa04bc32ee7b26"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd78bd8c0317ff78d72cd0ce5588bb16276408fc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"def assert_version_header_matches_request(api_microversion_header_name,"},{"line_number":102,"context_line":"                                          api_microversion,"},{"line_number":103,"context_line":"                                          response_header):"},{"line_number":104,"context_line":"    \"\"\"Checks API microversion in resposne header"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    Verifies whether microversion is present in response header"},{"line_number":107,"context_line":"    and with specified \u0027api_microversion\u0027 value."}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_604cfa70","line":104,"range":{"start_line":104,"start_character":34,"end_line":104,"end_character":42},"in_reply_to":"1af94dfe_97650e47","updated":"2016-03-16 07:33:49.000000000","message":"Done","commit_id":"2709e93c582d230cdafbc9d647fa04bc32ee7b26"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"17c81e98b6910aaedc478256b90d57b3fc9f1696","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                                 cfg_min_version, cfg_max_version):"},{"line_number":38,"context_line":"    \"\"\"Checks API microversions range and returns whether test needs to be skip"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Compares the test and configured microversion range and returns"},{"line_number":41,"context_line":"    whether test microversion range is out of configured one."},{"line_number":42,"context_line":"    This method can be used to skip the test based on configured and test"},{"line_number":43,"context_line":"    microversion range."}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_ea69ce26","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":12},"updated":"2016-03-17 02:19:54.000000000","message":"are there any rule for this \"s\"?\n\nThe docstring is inconsistent without/with \"s\", but I am not sure which is the best.","commit_id":"7d866ab1a8985991e5f9ff476b32d118173af584"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"48a2b5521c6a22a92f2e4594e145e4a27f16b389","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                                 cfg_min_version, cfg_max_version):"},{"line_number":38,"context_line":"    \"\"\"Checks API microversions range and returns whether test needs to be skip"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Compares the test and configured microversion range and returns"},{"line_number":41,"context_line":"    whether test microversion range is out of configured one."},{"line_number":42,"context_line":"    This method can be used to skip the test based on configured and test"},{"line_number":43,"context_line":"    microversion range."}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_45bb9527","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":12},"in_reply_to":"1af94dfe_ea69ce26","updated":"2016-03-17 02:40:35.000000000","message":"Yea on this case, both with/without s is correct as English grammar.\n\nAs we have no consistent rule so let\u0027s leave these as of now.","commit_id":"7d866ab1a8985991e5f9ff476b32d118173af584"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fbbf88787813231582fc205e2137ca01f87d5cdd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"def select_request_microversion(test_min_version, cfg_min_version):"},{"line_number":85,"context_line":"    \"\"\"Select microversion from test and configuration min version."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    Compare requested microversion and returns the maximum"},{"line_number":88,"context_line":"    microversion out of those."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    :param test_min_version: Test Minimum Microversion"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_85d11d5a","line":87,"range":{"start_line":87,"start_character":45,"end_line":87,"end_character":46},"updated":"2016-03-17 02:43:34.000000000","message":"this also is necessary to be changed.","commit_id":"84f668fba0113df6bda8f7b8db02befd8a0bc281"}],"tempest/lib/services/compute/base_compute_client.py":[{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"de516935ae98a3a54a76bb6bdacaa7511ee93c97","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            min_version \u003d api_version_request.APIVersionRequest(items[\u0027min\u0027])"},{"line_number":80,"context_line":"            max_version \u003d api_version_request.APIVersionRequest(items[\u0027max\u0027])"},{"line_number":81,"context_line":"            # This is case where self.api_microversion is None, which means"},{"line_number":82,"context_line":"            # request without microversion So select base v2.1 schema."},{"line_number":83,"context_line":"            if version.is_null() and items[\u0027min\u0027] is None:"},{"line_number":84,"context_line":"                schema \u003d items[\u0027schema\u0027]"},{"line_number":85,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_977eaee2","line":82,"range":{"start_line":82,"start_character":14,"end_line":82,"end_character":52},"updated":"2016-03-16 06:24:52.000000000","message":"I think even this comment needs a fix.","commit_id":"2709e93c582d230cdafbc9d647fa04bc32ee7b26"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cd78bd8c0317ff78d72cd0ce5588bb16276408fc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            min_version \u003d api_version_request.APIVersionRequest(items[\u0027min\u0027])"},{"line_number":80,"context_line":"            max_version \u003d api_version_request.APIVersionRequest(items[\u0027max\u0027])"},{"line_number":81,"context_line":"            # This is case where self.api_microversion is None, which means"},{"line_number":82,"context_line":"            # request without microversion So select base v2.1 schema."},{"line_number":83,"context_line":"            if version.is_null() and items[\u0027min\u0027] is None:"},{"line_number":84,"context_line":"                schema \u003d items[\u0027schema\u0027]"},{"line_number":85,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_60351ad9","line":82,"range":{"start_line":82,"start_character":14,"end_line":82,"end_character":52},"in_reply_to":"1af94dfe_977eaee2","updated":"2016-03-16 07:33:49.000000000","message":"Nice catch. Thanks","commit_id":"2709e93c582d230cdafbc9d647fa04bc32ee7b26"}]}
