)]}'
{"tempest/api/compute/base.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d38e0ca92f8033ddf43c5becbd19ac6036dd7891","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            name, image_id, flavor, **kwargs)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # handle the case of multiple servers"},{"line_number":199,"context_line":"        servers \u003d []"},{"line_number":200,"context_line":"        if \u0027min_count\u0027 in kwargs or \u0027max_count\u0027 in kwargs:"},{"line_number":201,"context_line":"            servers \u003d cls._get_created_servers(name)"},{"line_number":202,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FnDU%3D","line":199,"updated":"2013-05-29 13:01:05.000000000","message":"nit: could do servers \u003d [body] and eliminate the else in L202","commit_id":"0eff1f28500ce59f8a53540a0a6487e41661bccd"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d38e0ca92f8033ddf43c5becbd19ac6036dd7891","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            servers \u003d cls._get_created_servers(name)"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            servers \u003d [body]"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        cls.servers.extend(servers)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if \u0027wait_until\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FnBw%3D","line":204,"updated":"2013-05-29 13:01:05.000000000","message":"also can we move this new block above to inside _get_created_servers? would make things clear here..\nsomething like \ncls.servers.extend(cls._get_created_servers(body, kwargs.get(min_count, None), kwargs.get(max_count, None))) #body not name here cause we don\u0027t know what it is yet\n\nand in get_created_servers check if it\u0027s a multiple create or not","commit_id":"0eff1f28500ce59f8a53540a0a6487e41661bccd"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"79aae7359a18ef674023b4941c8a49143e1f8ead","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            servers \u003d cls._get_created_servers(name)"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            servers \u003d [body]"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        cls.servers.extend(servers)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if \u0027wait_until\u0027 in kwargs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2F%2FKc%3D","line":204,"in_reply_to":"AAAAPH%2F%2FnBw%3D","updated":"2013-06-04 14:33:01.000000000","message":"I would need to pass body, name and kwargs, as I would like to avoid the list_servers() in case of single server, and just return the original body back.  But than again, I would probably remove the get_created_servers function completely.\nI need to keep the servers variable for the loop in L208.","commit_id":"0eff1f28500ce59f8a53540a0a6487e41661bccd"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"64cadb09a3a0905c8ad7a88b77df0b01649ae105","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            admin_client.delete_tenant(tenant[\u0027id\u0027])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @classmethod"},{"line_number":162,"context_line":"    def _get_created_servers(cls, name):"},{"line_number":163,"context_line":"        \"\"\"Get servers created which name match with name param.\"\"\""},{"line_number":164,"context_line":"        resp, body \u003d cls.servers_client.list_servers()"},{"line_number":165,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2F91I%3D","line":162,"updated":"2013-06-04 23:54:45.000000000","message":"is it used anywhere ?","commit_id":"79e0ccfb70ff97445be99d6f08ebd4e9243fbf9e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"61c148ac0bce004f45736544495906b206013c1e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            admin_client.delete_tenant(tenant[\u0027id\u0027])"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @classmethod"},{"line_number":162,"context_line":"    def _get_created_servers(cls, name):"},{"line_number":163,"context_line":"        \"\"\"Get servers created which name match with name param.\"\"\""},{"line_number":164,"context_line":"        resp, body \u003d cls.servers_client.list_servers()"},{"line_number":165,"context_line":"        servers \u003d body[\u0027servers\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2F90A%3D","line":162,"in_reply_to":"AAAAPX%2F%2F91I%3D","updated":"2013-06-05 00:17:36.000000000","message":"upz, I forgot to remove, will do, thanks","commit_id":"79e0ccfb70ff97445be99d6f08ebd4e9243fbf9e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"64cadb09a3a0905c8ad7a88b77df0b01649ae105","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if \u0027min_count\u0027 in kwargs or \u0027max_count\u0027 in kwargs:"},{"line_number":203,"context_line":"            # Get servers created which name match with name param."},{"line_number":204,"context_line":"            r, b \u003d cls.servers_client.list_servers()"},{"line_number":205,"context_line":"            servers \u003d [s for s in b[\u0027servers\u0027] if s[\u0027name\u0027].startswith(name)]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        cls.servers.extend(servers)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2F91A%3D","line":205,"updated":"2013-06-04 23:54:45.000000000","message":"Do we have any other option to seek for newly created servers ?","commit_id":"79e0ccfb70ff97445be99d6f08ebd4e9243fbf9e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"61c148ac0bce004f45736544495906b206013c1e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if \u0027min_count\u0027 in kwargs or \u0027max_count\u0027 in kwargs:"},{"line_number":203,"context_line":"            # Get servers created which name match with name param."},{"line_number":204,"context_line":"            r, b \u003d cls.servers_client.list_servers()"},{"line_number":205,"context_line":"            servers \u003d [s for s in b[\u0027servers\u0027] if s[\u0027name\u0027].startswith(name)]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        cls.servers.extend(servers)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2F9zc%3D","line":205,"in_reply_to":"AAAAPX%2F%2F91A%3D","updated":"2013-06-05 00:17:36.000000000","message":"The create method returns either the first server of the list or the reservation ID. Neither helps much in discovering the list of created severs.  Considering that the name is randomized, this approach shall be safe enough. Another way could be to use something like metadata, and then as part of the test verify that the name actually matches what\u0027s expected, i.e. that it starts with the provided name.\nA change in this is not in scope for this patch, which only aims moving the existing logic to the base class.","commit_id":"79e0ccfb70ff97445be99d6f08ebd4e9243fbf9e"}]}