)]}'
{"releasenotes/notes/add-httptimeout-in-restclient-ax78061900e3f3d7.yaml":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"52eec6c4f0b03af00f4e1efdf2eb727e2594da2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - RestClient now supports setting timeout in urllib3.poolmanager."},{"line_number":4,"context_line":"    Clients will use CONF.service_clients.http_timeout for timeout "},{"line_number":5,"context_line":"    value to wait for http request to response."},{"line_number":6,"context_line":"  - KeystoneAuthProvider will accept http_timeout and will use it in"},{"line_number":7,"context_line":"    get_credentials."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"bacf61ea_1fa010f4","line":4,"updated":"2016-07-28 08:53:57.000000000","message":"NIT: trailing space","commit_id":"e02b23d0f9bc26e707dd9483007197eff622a590"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"b8fc637b8265ef277cce85c0bc794bfc56244201","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - RestClient now supports setting timeout in urllib3.poolmanager."},{"line_number":4,"context_line":"    Clients will use CONF.service_clients.http_timeout for timeout "},{"line_number":5,"context_line":"    value to wait for http request to response."},{"line_number":6,"context_line":"  - KeystoneAuthProvider will accept http_timeout and will use it in"},{"line_number":7,"context_line":"    get_credentials."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"bacf61ea_e1f448f3","line":4,"in_reply_to":"bacf61ea_1fa010f4","updated":"2016-07-29 06:35:55.000000000","message":"sorry I forgot that.\nMaybe I can fix it in a following patch which moves some config items from identity to the new group service_clients.","commit_id":"e02b23d0f9bc26e707dd9483007197eff622a590"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5e3a95a057062a9aa4f790adb6208c0c929e348e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - RestClient now supports setting timeout in urllib3.poolmanager."},{"line_number":4,"context_line":"    Clients will use CONF.service_clients.http_timeout for timeout "},{"line_number":5,"context_line":"    value to wait for http request to response."},{"line_number":6,"context_line":"  - KeystoneAuthProvider will accept http_timeout and will use it in"},{"line_number":7,"context_line":"    get_credentials."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"bacf61ea_33b5e830","line":4,"in_reply_to":"bacf61ea_e1f448f3","updated":"2016-07-29 23:32:10.000000000","message":"nice to fix this also at this time for fixing the other part together.","commit_id":"e02b23d0f9bc26e707dd9483007197eff622a590"}],"tempest/config.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b60b5287f59cd73d41ed7a52a970f551d249e192","unresolved":false,"context_lines":[{"line_number":625,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the TCP connection to be \u0027"},{"line_number":626,"context_line":"                    \u0027successful.\u0027),"},{"line_number":627,"context_line":"    cfg.IntOpt(\u0027http_timeout\u0027,"},{"line_number":628,"context_line":"               default\u003d300,"},{"line_number":629,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the http request to \u0027"},{"line_number":630,"context_line":"                    \u0027return\u0027),"},{"line_number":631,"context_line":"    cfg.IntOpt(\u0027ssh_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_c05c4b7f","line":628,"updated":"2016-04-15 08:02:51.000000000","message":"300 second to reply to a single HTTP request seems a bit high. What about 30 seconds ?","commit_id":"238cb5affdfa9e7fda7d7cfbdec9e266b3e6b4cd"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f5054bf7c261cd4df484c6128e278ebc1f1af863","unresolved":false,"context_lines":[{"line_number":625,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the TCP connection to be \u0027"},{"line_number":626,"context_line":"                    \u0027successful.\u0027),"},{"line_number":627,"context_line":"    cfg.IntOpt(\u0027http_timeout\u0027,"},{"line_number":628,"context_line":"               default\u003d300,"},{"line_number":629,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the http request to \u0027"},{"line_number":630,"context_line":"                    \u0027return\u0027),"},{"line_number":631,"context_line":"    cfg.IntOpt(\u0027ssh_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a1531f4_77ad0a88","line":628,"in_reply_to":"5a18252c_c05c4b7f","updated":"2016-04-15 08:55:36.000000000","message":"I don\u0027t know how long will it take for a http request to return if the system is busy or the network is congested,\nso for safety sake I put the default value 300 seconds.\n\nIt looks really a bit too long, and how about 60 seconds or\n90 seconds?","commit_id":"238cb5affdfa9e7fda7d7cfbdec9e266b3e6b4cd"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e114fec7ad34b6e51c1d29e6d1f4678a90393fed","unresolved":false,"context_lines":[{"line_number":596,"context_line":"               default\u003d60,"},{"line_number":597,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the TCP connection to be \u0027"},{"line_number":598,"context_line":"                    \u0027successful.\u0027),"},{"line_number":599,"context_line":"    cfg.IntOpt(\u0027http_timeout\u0027,"},{"line_number":600,"context_line":"               default\u003d60,"},{"line_number":601,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the http request to \u0027"},{"line_number":602,"context_line":"                    \u0027return\u0027),"},{"line_number":603,"context_line":"    cfg.IntOpt(\u0027ssh_timeout\u0027,"},{"line_number":604,"context_line":"               default\u003d300,"},{"line_number":605,"context_line":"               help\u003d\u0027Timeout in seconds to wait for the ssh banner.\u0027),"}],"source_content_type":"text/x-python","patch_set":22,"id":"dada55a8_93bcd6dc","line":602,"range":{"start_line":599,"start_character":0,"end_line":602,"end_character":30},"updated":"2016-07-25 10:14:55.000000000","message":"This option applies to all service clients and it\u0027s not really related to validation of VMs, which is what this group is about.","commit_id":"cfbdf9d31cee7d2bea006957a170fe0b3653b7f2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"fcecf6ac69ed41c2ca3cbba2b11c7c6349c059e6","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"            CONF.identity.disable_ssl_certificate_validation,"},{"line_number":1407,"context_line":"        \u0027ca_certs\u0027: CONF.identity.ca_certificates_file,"},{"line_number":1408,"context_line":"        \u0027trace_requests\u0027: CONF.debug.trace_requests,"},{"line_number":1409,"context_line":"        \u0027http_timeout\u0027: CONF.service_clients.http_timeout"},{"line_number":1410,"context_line":"    }"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"    if service_client_name is None:"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_91c09ee2","line":1409,"range":{"start_line":1409,"start_character":9,"end_line":1409,"end_character":23},"updated":"2016-07-27 14:59:44.000000000","message":"Docstring after L1386 should be updated as well.","commit_id":"920f169597b18cbb2fbe4089371ce2abc2455f56"}],"tempest/lib/auth.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"fcecf6ac69ed41c2ca3cbba2b11c7c6349c059e6","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    def __init__(self, credentials, auth_url,"},{"line_number":262,"context_line":"                 disable_ssl_certificate_validation\u003dNone,"},{"line_number":263,"context_line":"                 ca_certs\u003dNone, trace_requests\u003dNone, scope\u003d\u0027project\u0027,"},{"line_number":264,"context_line":"                 http_timeout\u003dNone):"},{"line_number":265,"context_line":"        super(KeystoneAuthProvider, self).__init__(credentials, scope)"},{"line_number":266,"context_line":"        self.dscv \u003d disable_ssl_certificate_validation"},{"line_number":267,"context_line":"        self.ca_certs \u003d ca_certs"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_5c8d9d7a","line":264,"updated":"2016-07-27 14:59:44.000000000","message":"You shouldn\u0027t add an unused parameter here. http_timeout should be honoured for the token clients as well, so you have to store this value like for the other parameters and pass it on to token clients v2 and v3 in the respective classes.\n\nSince you\u0027re extending a stable interface you\u0027ll need to mention this in the release notes as well.","commit_id":"920f169597b18cbb2fbe4089371ce2abc2455f56"}],"tempest/lib/common/http.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"5edcf53ebfb5cd4af01a60e14d0d1835c487edef","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ClosingHttp(urllib3.poolmanager.PoolManager):"},{"line_number":20,"context_line":"    def __init__(self, disable_ssl_certificate_validation\u003dFalse,"},{"line_number":21,"context_line":"                 ca_certs\u003dNone, timeout\u003dNone):"},{"line_number":22,"context_line":"        kwargs \u003d {}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        if disable_ssl_certificate_validation:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_74dbc64f","line":21,"range":{"start_line":21,"start_character":30,"end_line":21,"end_character":44},"updated":"2016-04-14 05:09:46.000000000","message":"Timeout is never used.\nIt should be added to kargs dictionary so that it is passed to urllib3","commit_id":"03086853a173c34b1ed2efd0daee4e4d38bfa2a5"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"002a92d510a2865fe5bfb4f7d767a7dd42b70b16","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            kwargs[\u0027cert_reqs\u0027] \u003d \u0027CERT_REQUIRED\u0027"},{"line_number":30,"context_line":"            kwargs[\u0027ca_certs\u0027] \u003d ca_certs"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        if timeout:"},{"line_number":33,"context_line":"            kwargs[\u0027timeout\u0027] \u003d timeout"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        super(ClosingHttp, self).__init__(**kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_42a243fe","line":32,"updated":"2016-04-14 08:32:24.000000000","message":"I am not sure we want to configure the timeout on a per client basis. Just do\n\n  kwargs[\u0027timeout\u0027] \u003d CONF.validation.http_timeout\n\nAnd don\u0027t change the other files.","commit_id":"ae89394c72268761f62b20daee99b01971f6e38c"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"78145751dd62614d471e2d05486dcdadc39c533f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            kwargs[\u0027cert_reqs\u0027] \u003d \u0027CERT_REQUIRED\u0027"},{"line_number":30,"context_line":"            kwargs[\u0027ca_certs\u0027] \u003d ca_certs"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        if timeout:"},{"line_number":33,"context_line":"            kwargs[\u0027timeout\u0027] \u003d timeout"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        super(ClosingHttp, self).__init__(**kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_3dd76a4c","line":32,"in_reply_to":"5a18252c_42a243fe","updated":"2016-04-14 08:54:10.000000000","message":"if I use CONF.validation.http_timeout in tempest.lib, \nI will have to \"from tempest import config\" which will\nlead to a cycle import error in pep8 check.\n\nBesides, usually only when the tested system has some rarely seen problem(we really met it in our system), the http request\nmay never return, not like the ssh timeout events which may occur frequently. So at first I even want to hard code the \ntimeout value.","commit_id":"ae89394c72268761f62b20daee99b01971f6e38c"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"f86ee6d1198382acdeb44bb4e0a26be065a37b1d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ClosingHttp(urllib3.poolmanager.PoolManager):"},{"line_number":20,"context_line":"    def __init__(self, disable_ssl_certificate_validation\u003dFalse,"},{"line_number":21,"context_line":"                 ca_certs\u003dNone, timeout\u003dNone):"},{"line_number":22,"context_line":"        kwargs \u003d {}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        if disable_ssl_certificate_validation:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_a17099dd","line":21,"updated":"2016-04-25 08:35:55.000000000","message":"Having the timeout only in config won\u0027t solve the problem for any plugin or other tests consuming rest_client / http directly, making this parameter de-facto required for them.\nI think we should have a default value either here or in rest_client, like we do for build_timeout.","commit_id":"33c29465056cd0f41e341a1329ca70285786375f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"5d3f3cb4d2be9e398d83f3f78993ab326575f5ff","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ClosingHttp(urllib3.poolmanager.PoolManager):"},{"line_number":20,"context_line":"    def __init__(self, disable_ssl_certificate_validation\u003dFalse,"},{"line_number":21,"context_line":"                 ca_certs\u003dNone, timeout\u003dNone):"},{"line_number":22,"context_line":"        kwargs \u003d {}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        if disable_ssl_certificate_validation:"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_1cc06b4f","line":21,"in_reply_to":"1a122d0e_5cc9a877","updated":"2016-05-11 13:14:36.000000000","message":"I think having sane defaults is recommended instead. That doesn\u0027t mean the value is hardcoded, it\u0027s actually overridable via config. But if someone consumes this interface from outside tempest, tempest config values might not be there.","commit_id":"33c29465056cd0f41e341a1329ca70285786375f"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"46900d50ef99b24a91c154c4223d23af21c95be9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ClosingHttp(urllib3.poolmanager.PoolManager):"},{"line_number":20,"context_line":"    def __init__(self, disable_ssl_certificate_validation\u003dFalse,"},{"line_number":21,"context_line":"                 ca_certs\u003dNone, timeout\u003dNone):"},{"line_number":22,"context_line":"        kwargs \u003d {}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        if disable_ssl_certificate_validation:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_5cc9a877","line":21,"in_reply_to":"1a122d0e_a17099dd","updated":"2016-04-25 08:56:26.000000000","message":"Yes it sounds reasonable, and I hadn\u0027t put a default value here because \"hard-coding\" is not recommended. I will think \nabout this in a new change.","commit_id":"33c29465056cd0f41e341a1329ca70285786375f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b477f66e1ef11e23accd64a004d978d6666c516b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ClosingHttp(urllib3.poolmanager.PoolManager):"},{"line_number":20,"context_line":"    def __init__(self, disable_ssl_certificate_validation\u003dFalse,"},{"line_number":21,"context_line":"                 ca_certs\u003dNone, timeout\u003dNone):"},{"line_number":22,"context_line":"        kwargs \u003d {}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        if disable_ssl_certificate_validation:"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_9070bfa5","line":21,"in_reply_to":"dab17558_1cc06b4f","updated":"2016-05-11 13:25:13.000000000","message":"There is a default value for this timeout parameter. It is None, and None is a good value, it means \"no timeout\", as it was previously.","commit_id":"33c29465056cd0f41e341a1329ca70285786375f"}],"tempest/lib/common/rest_client.py":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"351195528eb52a309157359c98e5dedf9667375c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                       \u0027vary\u0027, \u0027www-authenticate\u0027))"},{"line_number":96,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":97,"context_line":"        self.http_obj \u003d http.ClosingHttp("},{"line_number":98,"context_line":"            timeout\u003d300,"},{"line_number":99,"context_line":"            disable_ssl_certificate_validation\u003ddscv, ca_certs\u003dca_certs)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _get_type(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_68723e7e","line":98,"updated":"2016-04-12 07:56:56.000000000","message":"Can it be set in config?","commit_id":"34aa0f307f983dd6df08e9916e57f61283b4b3f4"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0b6277178dac3a02bd48d5d2568a609eed63b9cd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                       \u0027vary\u0027, \u0027www-authenticate\u0027))"},{"line_number":96,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":97,"context_line":"        self.http_obj \u003d http.ClosingHttp("},{"line_number":98,"context_line":"            timeout\u003d300,"},{"line_number":99,"context_line":"            disable_ssl_certificate_validation\u003ddscv, ca_certs\u003dca_certs)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _get_type(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_43092531","line":98,"in_reply_to":"5a18252c_237ce971","updated":"2016-04-12 08:32:27.000000000","message":"Still I think it should be in config","commit_id":"34aa0f307f983dd6df08e9916e57f61283b4b3f4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"58321fbb31000525efdfded92520f0922af5c0ff","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                       \u0027vary\u0027, \u0027www-authenticate\u0027))"},{"line_number":96,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":97,"context_line":"        self.http_obj \u003d http.ClosingHttp("},{"line_number":98,"context_line":"            timeout\u003d300,"},{"line_number":99,"context_line":"            disable_ssl_certificate_validation\u003ddscv, ca_certs\u003dca_certs)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _get_type(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_23e22804","line":98,"in_reply_to":"5a18252c_43092531","updated":"2016-04-12 08:44:10.000000000","message":"Then what section of tempest.conf should I add a config item? \nor can I just use the ssh_timeout?","commit_id":"34aa0f307f983dd6df08e9916e57f61283b4b3f4"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"1516b105bf7c8e58b622a8f79e802b7d732d5266","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                       \u0027vary\u0027, \u0027www-authenticate\u0027))"},{"line_number":96,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":97,"context_line":"        self.http_obj \u003d http.ClosingHttp("},{"line_number":98,"context_line":"            timeout\u003d300,"},{"line_number":99,"context_line":"            disable_ssl_certificate_validation\u003ddscv, ca_certs\u003dca_certs)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _get_type(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_237ce971","line":98,"in_reply_to":"5a18252c_68723e7e","updated":"2016-04-12 08:18:02.000000000","message":"Usually only when the tested system has some rarely seen \nproblem, the http request may never return, not like the \nssh timeout events which may occur frequently. So here I\njust put a constant to avoid too much configuration.","commit_id":"34aa0f307f983dd6df08e9916e57f61283b4b3f4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5e3a95a057062a9aa4f790adb6208c0c929e348e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                         TLS server cert"},{"line_number":67,"context_line":"    :param str trace_request: Regex to use for specifying logging the entirety"},{"line_number":68,"context_line":"                              of the request and response payload"},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    TYPE \u003d \"json\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    # The version of the API this client implements"}],"source_content_type":"text/x-python","patch_set":25,"id":"bacf61ea_53617cd2","line":69,"updated":"2016-07-29 23:32:10.000000000","message":"need to add docstring of a new argument.","commit_id":"e02b23d0f9bc26e707dd9483007197eff622a590"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"30c962d7b0aa32a35d477970ee57c45d9b8bf923","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                         TLS server cert"},{"line_number":67,"context_line":"    :param str trace_request: Regex to use for specifying logging the entirety"},{"line_number":68,"context_line":"                              of the request and response payload"},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    TYPE \u003d \"json\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    # The version of the API this client implements"}],"source_content_type":"text/x-python","patch_set":25,"id":"bacf61ea_f31fd005","line":69,"in_reply_to":"bacf61ea_53617cd2","updated":"2016-07-29 23:42:14.000000000","message":"+1","commit_id":"e02b23d0f9bc26e707dd9483007197eff622a590"}],"tempest/lib/services/identity/v2/token_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ef47247687f74ecb83e1cbe6edbc8a811246cdb8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TokenClient(rest_client.RestClient):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, auth_url, disable_ssl_certificate_validation\u003dNone,"},{"line_number":25,"context_line":"                 ca_certs\u003dNone, trace_requests\u003dNone, http_timeout\u003dNone):"},{"line_number":26,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":27,"context_line":"        super(TokenClient, self).__init__("},{"line_number":28,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_0c07cb18","line":25,"updated":"2016-04-14 13:15:53.000000000","message":"Just add **kwargs here","commit_id":"80835e6fcb97f9a5d4bd8e25f8f5a7803ce921c7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ef47247687f74ecb83e1cbe6edbc8a811246cdb8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(TokenClient, self).__init__("},{"line_number":28,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"},{"line_number":29,"context_line":"            ca_certs\u003dca_certs, trace_requests\u003dtrace_requests,"},{"line_number":30,"context_line":"            http_timeout\u003dhttp_timeout)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        if auth_url is None:"},{"line_number":33,"context_line":"            raise exceptions.IdentityError(\"Couldn\u0027t determine auth_url\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_ec224fa2","line":30,"updated":"2016-04-14 13:15:53.000000000","message":"And **kwargs here\n\nHave a look at the other clients (such as compute/base_compute_client.py or compute/servers_client.py)","commit_id":"80835e6fcb97f9a5d4bd8e25f8f5a7803ce921c7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"f86ee6d1198382acdeb44bb4e0a26be065a37b1d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TokenClient(rest_client.RestClient):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, auth_url, disable_ssl_certificate_validation\u003dNone,"},{"line_number":25,"context_line":"                 ca_certs\u003dNone, trace_requests\u003dNone, **kwargs):"},{"line_number":26,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":27,"context_line":"        super(TokenClient, self).__init__("},{"line_number":28,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_21f80949","line":25,"updated":"2016-04-25 08:35:55.000000000","message":"I preferred the initial approach passing http_timeout explicitly here, as it makes the interface clearer - rest_client won\u0027t accept any parameter.\n@jordan: why do you think it\u0027s better to have kwargs?","commit_id":"33c29465056cd0f41e341a1329ca70285786375f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2886f81526f9788d2a9bc4545ad82be2855a070b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TokenClient(rest_client.RestClient):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, auth_url, disable_ssl_certificate_validation\u003dNone,"},{"line_number":25,"context_line":"                 ca_certs\u003dNone, trace_requests\u003dNone, **kwargs):"},{"line_number":26,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":27,"context_line":"        super(TokenClient, self).__init__("},{"line_number":28,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_dc29c39c","line":25,"in_reply_to":"1a122d0e_21f80949","updated":"2016-05-11 13:22:53.000000000","message":"For consistency. base_compute_client.py servers_client.py images_client.py base_volumes_client.py they all take a variable number of kwargs.","commit_id":"33c29465056cd0f41e341a1329ca70285786375f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"aa57f1fe592c5428dfecc488f15675b074d452c4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class TokenClient(rest_client.RestClient):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, auth_url, disable_ssl_certificate_validation\u003dNone,"},{"line_number":25,"context_line":"                 ca_certs\u003dNone, trace_requests\u003dNone, **kwargs):"},{"line_number":26,"context_line":"        dscv \u003d disable_ssl_certificate_validation"},{"line_number":27,"context_line":"        super(TokenClient, self).__init__("},{"line_number":28,"context_line":"            None, None, None, disable_ssl_certificate_validation\u003ddscv,"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_da3d3ec5","line":25,"in_reply_to":"dab17558_dc29c39c","updated":"2016-05-11 14:47:53.000000000","message":"And what is the reason for having that in those?\nIt\u0027s not so critical really, I just thought this makes the interface less readable, but maybe it\u0027s just me.","commit_id":"33c29465056cd0f41e341a1329ca70285786375f"}]}