)]}'
{"tempest/api/volume/admin/test_snapshots_actions.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"1d6268b69dfe45735c6772d4d8787563e517b296","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        params \u003d {cls.name_field: snap_name}"},{"line_number":52,"context_line":"        cls.snapshot \u003d cls.client.create_snapshot("},{"line_number":53,"context_line":"            volume_id\u003dcls.volume[\u0027id\u0027], **params)[\u0027snapshot\u0027]"},{"line_number":54,"context_line":"        waiters.wait_for_snapshot_status(cls.client,"},{"line_number":55,"context_line":"                                         cls.snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def resource_cleanup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_4ca80d20","line":55,"range":{"start_line":54,"start_character":8,"end_line":55,"end_character":73},"updated":"2016-03-25 17:17:52.000000000","message":"Is this call to the waiters really necessary here? the create_snapshot function called above already includes a wait_for_snapshot_status call, this seems redundant.","commit_id":"667aaa23d2d975d89c3f94a0ac1026eb7c5c9056"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"c8941c1ba7f6508d69485b2b1cba113e16fed2da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        params \u003d {cls.name_field: snap_name}"},{"line_number":52,"context_line":"        cls.snapshot \u003d cls.client.create_snapshot("},{"line_number":53,"context_line":"            volume_id\u003dcls.volume[\u0027id\u0027], **params)[\u0027snapshot\u0027]"},{"line_number":54,"context_line":"        waiters.wait_for_snapshot_status(cls.client,"},{"line_number":55,"context_line":"                                         cls.snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def resource_cleanup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_253207f2","line":55,"range":{"start_line":54,"start_character":8,"end_line":55,"end_character":73},"in_reply_to":"da0c15f0_2c4794bc","updated":"2016-03-25 20:01:17.000000000","message":"No problem :)","commit_id":"667aaa23d2d975d89c3f94a0ac1026eb7c5c9056"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"706182a568754ce4178ae245357f8dff1cca3ff5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        params \u003d {cls.name_field: snap_name}"},{"line_number":52,"context_line":"        cls.snapshot \u003d cls.client.create_snapshot("},{"line_number":53,"context_line":"            volume_id\u003dcls.volume[\u0027id\u0027], **params)[\u0027snapshot\u0027]"},{"line_number":54,"context_line":"        waiters.wait_for_snapshot_status(cls.client,"},{"line_number":55,"context_line":"                                         cls.snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def resource_cleanup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_f85b9b52","line":55,"range":{"start_line":54,"start_character":8,"end_line":55,"end_character":73},"in_reply_to":"da0c15f0_4ca80d20","updated":"2016-03-25 18:41:12.000000000","message":"Sorry, but I don\u0027t see any call to the wait_for_snapshot_status function in the create_snapshot method https://github.com/openstack/tempest/blob/master/tempest/services/volume/base/base_snapshots_client.py#L53-L63","commit_id":"667aaa23d2d975d89c3f94a0ac1026eb7c5c9056"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"3ce132b2348ec800248f2c093c0b08df2e85a295","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        params \u003d {cls.name_field: snap_name}"},{"line_number":52,"context_line":"        cls.snapshot \u003d cls.client.create_snapshot("},{"line_number":53,"context_line":"            volume_id\u003dcls.volume[\u0027id\u0027], **params)[\u0027snapshot\u0027]"},{"line_number":54,"context_line":"        waiters.wait_for_snapshot_status(cls.client,"},{"line_number":55,"context_line":"                                         cls.snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def resource_cleanup(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_2c4794bc","line":55,"range":{"start_line":54,"start_character":8,"end_line":55,"end_character":73},"in_reply_to":"da0c15f0_f85b9b52","updated":"2016-03-25 18:58:02.000000000","message":"My bad, I was looking into the wrong client method. It all looks good to me now ;)","commit_id":"667aaa23d2d975d89c3f94a0ac1026eb7c5c9056"}],"tempest/scenario/test_stamp_pattern.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"1d6268b69dfe45735c6772d4d8787563e517b296","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.addCleanup(cleaner)"},{"line_number":76,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":77,"context_line":"                                       volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":78,"context_line":"        waiters.wait_for_snapshot_status(self.snapshots_client,"},{"line_number":79,"context_line":"                                         snapshot[\u0027id\u0027], \u0027available\u0027)"},{"line_number":80,"context_line":"        self.assertEqual(snapshot_name, snapshot[\u0027display_name\u0027])"},{"line_number":81,"context_line":"        return snapshot"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_77631eb2","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":69},"updated":"2016-03-25 17:17:52.000000000","message":"Based on my other comment looks like this call to waiter is not necessary either.","commit_id":"667aaa23d2d975d89c3f94a0ac1026eb7c5c9056"}],"tempest/scenario/test_volume_boot_pattern.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"1d6268b69dfe45735c6772d4d8787563e517b296","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.addCleanup("},{"line_number":88,"context_line":"            self.snapshots_client.wait_for_resource_deletion, snap[\u0027id\u0027])"},{"line_number":89,"context_line":"        self.addCleanup(self.snapshots_client.delete_snapshot, snap[\u0027id\u0027])"},{"line_number":90,"context_line":"        waiters.wait_for_snapshot_status(self.snapshots_client,"},{"line_number":91,"context_line":"                                         snap[\u0027id\u0027], \u0027available\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        # NOTE(e0ne): Cinder API v2 uses name instead of display_name"},{"line_number":94,"context_line":"        if \u0027display_name\u0027 in snap:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_17a462a4","line":91,"range":{"start_line":90,"start_character":8,"end_line":91,"end_character":65},"updated":"2016-03-25 17:17:52.000000000","message":"ditto","commit_id":"667aaa23d2d975d89c3f94a0ac1026eb7c5c9056"}]}