)]}'
{"tempest/tests/test_hacking.py":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"2e2d9570c18f92132cd5ef6e6ae1f3da2326f29e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(0, len(list(checks.no_testtools_skip_decorator("},{"line_number":149,"context_line":"            \" @testtools.skipIf(CONF.something, \u0027msg\u0027)\"))))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_dont_import_local_tempest_code_into_lib(self):"},{"line_number":152,"context_line":"        self.assertEqual(0, len(list(checks.dont_import_local_tempest_into_lib("},{"line_number":153,"context_line":"            \"from tempest.common import waiters\","},{"line_number":154,"context_line":"            \u0027./tempest/common/compute.py\u0027))))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_31308901","line":151,"updated":"2016-03-25 23:25:15.000000000","message":"Could you add another unit test for the logic to trigger the 2nd if in function definition?\n \u0027tempest/lib/\u0027 in filename and\n not (\u0027from tempest\u0027 in logical_line or \u0027import tempest\u0027 in logical_line)","commit_id":"e28f6418e764c5145e0c9eb1a34c714e65369906"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3adbb9e71a96b275fbe8fd766c3a5defeb25953a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(0, len(list(checks.no_testtools_skip_decorator("},{"line_number":149,"context_line":"            \" @testtools.skipIf(CONF.something, \u0027msg\u0027)\"))))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_dont_import_local_tempest_code_into_lib(self):"},{"line_number":152,"context_line":"        self.assertEqual(0, len(list(checks.dont_import_local_tempest_into_lib("},{"line_number":153,"context_line":"            \"from tempest.common import waiters\","},{"line_number":154,"context_line":"            \u0027./tempest/common/compute.py\u0027))))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_3f44f972","line":151,"in_reply_to":"da0c15f0_31308901","updated":"2016-03-29 02:29:46.000000000","message":"Yea that will be nice.\nIn addition, one more for \"import tempest\" in lib files.","commit_id":"e28f6418e764c5145e0c9eb1a34c714e65369906"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bc10234ec5c414c78d06b9731b0dd3de592c2cb1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(0, len(list(checks.no_testtools_skip_decorator("},{"line_number":149,"context_line":"            \" @testtools.skipIf(CONF.something, \u0027msg\u0027)\"))))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_dont_import_local_tempest_code_into_lib(self):"},{"line_number":152,"context_line":"        self.assertEqual(0, len(list(checks.dont_import_local_tempest_into_lib("},{"line_number":153,"context_line":"            \"from tempest.common import waiters\","},{"line_number":154,"context_line":"            \u0027./tempest/common/compute.py\u0027))))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_b42be093","line":151,"in_reply_to":"da0c15f0_31308901","updated":"2016-03-29 18:15:50.000000000","message":"nice point, thanks.\nDone","commit_id":"e28f6418e764c5145e0c9eb1a34c714e65369906"}]}