)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"4a44b4c9fa7823c15c786723f9a3f73294d295b8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            cls.volumes_extension_client \u003d cls.os.volumes_extension_client"},{"line_number":74,"context_line":"            cls.availability_zone_client \u003d ("},{"line_number":75,"context_line":"                cls.os.volume_availability_zone_client)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            cls.snapshots_client \u003d cls.os.snapshots_v2_client"},{"line_number":78,"context_line":"            cls.volumes_client \u003d cls.os.volumes_v2_client"},{"line_number":79,"context_line":"            cls.volumes_extension_client \u003d cls.os.volumes_v2_extension_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_841c9078","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":13},"updated":"2016-04-05 18:30:29.000000000","message":"Shouldn\u0027t this else be replaced by an\nelif cls._api_version \u003d\u003d 2\nas it is done in the BaseVolumeAdminTest?","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"7b866910ad77a2ec08f94cf53e55d87dd35f2a01","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            cls.volumes_extension_client \u003d cls.os.volumes_extension_client"},{"line_number":74,"context_line":"            cls.availability_zone_client \u003d ("},{"line_number":75,"context_line":"                cls.os.volume_availability_zone_client)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            cls.snapshots_client \u003d cls.os.snapshots_v2_client"},{"line_number":78,"context_line":"            cls.volumes_client \u003d cls.os.volumes_v2_client"},{"line_number":79,"context_line":"            cls.volumes_extension_client \u003d cls.os.volumes_v2_extension_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_ed69e3bf","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":13},"in_reply_to":"9a061dce_841c9078","updated":"2016-04-05 23:55:32.000000000","message":"Perhaps, but that is out of scope for this change","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"f4818fcb8a1c8a1fbdec848303f8a4058048b5d4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            cls.volumes_extension_client \u003d cls.os.volumes_extension_client"},{"line_number":74,"context_line":"            cls.availability_zone_client \u003d ("},{"line_number":75,"context_line":"                cls.os.volume_availability_zone_client)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            cls.snapshots_client \u003d cls.os.snapshots_v2_client"},{"line_number":78,"context_line":"            cls.volumes_client \u003d cls.os.volumes_v2_client"},{"line_number":79,"context_line":"            cls.volumes_extension_client \u003d cls.os.volumes_v2_extension_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_ff56855a","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":13},"in_reply_to":"9a061dce_ed69e3bf","updated":"2016-04-06 14:15:13.000000000","message":"cool, I understand.","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"}],"tempest/api/volume/v3/base.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"4a44b4c9fa7823c15c786723f9a3f73294d295b8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def setup_clients(cls):"},{"line_number":32,"context_line":"        super(VolumesV3AdminTest, cls).setup_clients()"},{"line_number":33,"context_line":"        cls.volume_qos_client \u003d cls.os_adm.volume_qos_v2_client"},{"line_number":34,"context_line":"        cls.admin_volume_services_client \u003d cls.os_adm.volume_services_v2_client"},{"line_number":35,"context_line":"        cls.volume_types_client \u003d cls.os_adm.volume_types_v2_client"},{"line_number":36,"context_line":"        cls.admin_volume_client \u003d cls.os_adm.volumes_v2_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_0f37f9e3","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":56},"updated":"2016-04-05 18:30:29.000000000","message":"Are these to be replaced by v3 in the future?","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"7b866910ad77a2ec08f94cf53e55d87dd35f2a01","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def setup_clients(cls):"},{"line_number":32,"context_line":"        super(VolumesV3AdminTest, cls).setup_clients()"},{"line_number":33,"context_line":"        cls.volume_qos_client \u003d cls.os_adm.volume_qos_v2_client"},{"line_number":34,"context_line":"        cls.admin_volume_services_client \u003d cls.os_adm.volume_services_v2_client"},{"line_number":35,"context_line":"        cls.volume_types_client \u003d cls.os_adm.volume_types_v2_client"},{"line_number":36,"context_line":"        cls.admin_volume_client \u003d cls.os_adm.volumes_v2_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_8da947e2","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":56},"in_reply_to":"9a061dce_0f37f9e3","updated":"2016-04-05 23:55:32.000000000","message":"They may be though I know of no concrete plans to at the moment.  They are added here because the parent class has an explicit check for _api_version 1 or 2 and would not define any clients when _api_version\u003d3.\n\nI have a follow-on patch to this that adds a new messages_client (and API tests) that requires the v3 endpoint and adds that definition here.  As v3 is brand new to Cinder I\u0027m sure other clients will be getting updated in the future, but this patch just lays the groundwork for tests that need the v3 endpoint.","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"f4818fcb8a1c8a1fbdec848303f8a4058048b5d4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def setup_clients(cls):"},{"line_number":32,"context_line":"        super(VolumesV3AdminTest, cls).setup_clients()"},{"line_number":33,"context_line":"        cls.volume_qos_client \u003d cls.os_adm.volume_qos_v2_client"},{"line_number":34,"context_line":"        cls.admin_volume_services_client \u003d cls.os_adm.volume_services_v2_client"},{"line_number":35,"context_line":"        cls.volume_types_client \u003d cls.os_adm.volume_types_v2_client"},{"line_number":36,"context_line":"        cls.admin_volume_client \u003d cls.os_adm.volumes_v2_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_5f8051c0","line":33,"range":{"start_line":33,"start_character":54,"end_line":33,"end_character":56},"in_reply_to":"9a061dce_8da947e2","updated":"2016-04-06 14:15:13.000000000","message":"got it.","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"},{"author":{"_account_id":20996,"name":"Avinash Raghavendra","email":"avinash.raghavendra@ericsson.com","username":"eragavi"},"change_message_id":"67f943cafef9bf8a62ca0f21da9b188488514dfe","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.hosts_client \u003d cls.os_adm.volume_hosts_v2_client"},{"line_number":38,"context_line":"        cls.admin_snapshots_client \u003d cls.os_adm.snapshots_v2_client"},{"line_number":39,"context_line":"        cls.backups_adm_client \u003d cls.os_adm.backups_v2_client"},{"line_number":40,"context_line":"        cls.quotas_client \u003d cls.os_adm.volume_quotas_v2_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_217e5619","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":62},"updated":"2016-04-05 17:58:06.000000000","message":"don\u0027t you have to leave a single line space for a method","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"7b866910ad77a2ec08f94cf53e55d87dd35f2a01","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.hosts_client \u003d cls.os_adm.volume_hosts_v2_client"},{"line_number":38,"context_line":"        cls.admin_snapshots_client \u003d cls.os_adm.snapshots_v2_client"},{"line_number":39,"context_line":"        cls.backups_adm_client \u003d cls.os_adm.backups_v2_client"},{"line_number":40,"context_line":"        cls.quotas_client \u003d cls.os_adm.volume_quotas_v2_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_0db6d73c","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":62},"in_reply_to":"9a061dce_217e5619","updated":"2016-04-05 23:55:32.000000000","message":"I\u0027m not sure I understand this comment","commit_id":"6dec6e05a3a7f51cc520d649e2891641bedc3b78"}]}