)]}'
{"tempest/cmd/account_generator.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        endpoint_type\u003d\u0027adminURL\u0027,"},{"line_number":170,"context_line":"        **params"},{"line_number":171,"context_line":"    )"},{"line_number":172,"context_line":"    network_admin \u003d None"},{"line_number":173,"context_line":"    networks_admin \u003d None"},{"line_number":174,"context_line":"    routers_admin \u003d None"},{"line_number":175,"context_line":"    subnets_admin \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_8272aeab","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":24},"updated":"2016-04-06 06:48:26.000000000","message":"we can remove this too","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            endpoint_type\u003d\u0027adminURL\u0027,"},{"line_number":197,"context_line":"            **params)"},{"line_number":198,"context_line":"    return (identity_admin, tenants_admin, roles_admin, users_admin,"},{"line_number":199,"context_line":"            neutron_iso_networks, network_admin, networks_admin, routers_admin,"},{"line_number":200,"context_line":"            subnets_admin)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_c264a6e6","line":199,"range":{"start_line":199,"start_character":34,"end_line":199,"end_character":48},"updated":"2016-04-06 06:48:26.000000000","message":"ditto","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def create_resources(opts, resources):"},{"line_number":204,"context_line":"    (identity_admin, tenants_admin, roles_admin, users_admin,"},{"line_number":205,"context_line":"     neutron_iso_networks, network_admin, networks_admin, routers_admin,"},{"line_number":206,"context_line":"     subnets_admin) \u003d get_admin_clients(opts)"},{"line_number":207,"context_line":"    roles \u003d roles_admin.list_roles()[\u0027roles\u0027]"},{"line_number":208,"context_line":"    for u in resources[\u0027users\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_226482e2","line":205,"range":{"start_line":205,"start_character":27,"end_line":205,"end_character":40},"updated":"2016-04-06 06:48:26.000000000","message":"ditto","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        for u in resources[\u0027users\u0027]:"},{"line_number":249,"context_line":"            tenant \u003d identity.get_tenant_by_name(tenants_admin, u[\u0027tenant\u0027])"},{"line_number":250,"context_line":"            network_name, router_name \u003d create_network_resources("},{"line_number":251,"context_line":"                network_admin, networks_admin, routers_admin, subnets_admin,"},{"line_number":252,"context_line":"                tenant[\u0027id\u0027], u[\u0027name\u0027])"},{"line_number":253,"context_line":"            u[\u0027network\u0027] \u003d network_name"},{"line_number":254,"context_line":"            u[\u0027router\u0027] \u003d router_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_429ff6b3","line":251,"range":{"start_line":251,"start_character":16,"end_line":251,"end_character":30},"updated":"2016-04-06 06:48:26.000000000","message":"ditto","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    LOG.info(\u0027Resources deployed successfully!\u0027)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def create_network_resources(network_admin_client, networks_admin_client,"},{"line_number":279,"context_line":"                             routers_admin_client, subnets_admin_client,"},{"line_number":280,"context_line":"                             tenant_id, name):"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_a2a6d20d","line":278,"range":{"start_line":278,"start_character":29,"end_line":278,"end_character":50},"updated":"2016-04-06 06:48:26.000000000","message":"ditto","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"}],"tempest/cmd/javelin.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            build_interval\u003dCONF.volume.build_interval,"},{"line_number":265,"context_line":"            build_timeout\u003dCONF.volume.build_timeout,"},{"line_number":266,"context_line":"            **default_params)"},{"line_number":267,"context_line":"        self.networks \u003d network_client.NetworkClient("},{"line_number":268,"context_line":"            _auth,"},{"line_number":269,"context_line":"            CONF.network.catalog_type,"},{"line_number":270,"context_line":"            CONF.network.region or CONF.identity.region,"},{"line_number":271,"context_line":"            endpoint_type\u003dCONF.network.endpoint_type,"},{"line_number":272,"context_line":"            build_interval\u003dCONF.network.build_interval,"},{"line_number":273,"context_line":"            build_timeout\u003dCONF.network.build_timeout,"},{"line_number":274,"context_line":"            **default_params)"},{"line_number":275,"context_line":"        self.ports \u003d ports_client.PortsClient("},{"line_number":276,"context_line":"            _auth,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_c2f4a688","side":"PARENT","line":273,"range":{"start_line":267,"start_character":0,"end_line":273,"end_character":53},"updated":"2016-04-06 06:48:26.000000000","message":"This is used in many methods and should be networks_client.NetworksClient from tempest.lib.services.network.networks_client\n\nSeems like this was already broken :)","commit_id":"eda607cb1c89762a54290c4525d81c1b192c421f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"60e243396309d46ac6725edcf31ea11e0b0b6afd","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            build_interval\u003dCONF.volume.build_interval,"},{"line_number":265,"context_line":"            build_timeout\u003dCONF.volume.build_timeout,"},{"line_number":266,"context_line":"            **default_params)"},{"line_number":267,"context_line":"        self.networks \u003d network_client.NetworkClient("},{"line_number":268,"context_line":"            _auth,"},{"line_number":269,"context_line":"            CONF.network.catalog_type,"},{"line_number":270,"context_line":"            CONF.network.region or CONF.identity.region,"},{"line_number":271,"context_line":"            endpoint_type\u003dCONF.network.endpoint_type,"},{"line_number":272,"context_line":"            build_interval\u003dCONF.network.build_interval,"},{"line_number":273,"context_line":"            build_timeout\u003dCONF.network.build_timeout,"},{"line_number":274,"context_line":"            **default_params)"},{"line_number":275,"context_line":"        self.ports \u003d ports_client.PortsClient("},{"line_number":276,"context_line":"            _auth,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_4496cf3f","side":"PARENT","line":273,"range":{"start_line":267,"start_character":0,"end_line":273,"end_character":53},"in_reply_to":"9a061dce_c2f4a688","updated":"2016-04-06 12:55:43.000000000","message":"Oops, nice catch.\nOK, I will fix it on this patch.","commit_id":"eda607cb1c89762a54290c4525d81c1b192c421f"}],"tempest/lib/services/network/ports_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6118a580a4ec3f1a257678a4361837f4e65dd751","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        uri \u003d \u0027/ports\u0027"},{"line_number":48,"context_line":"        return self.create_resource(uri, kwargs)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            self.show_port(id)"},{"line_number":53,"context_line":"        except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_74ad2f9a","line":50,"updated":"2016-04-07 16:00:24.000000000","message":"We should not have \"utility\"/helper functions in the Client classes, but that\u0027s okay for now.","commit_id":"43e7fcff6f42e6ce81d87f7656424698103595d8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"699b01726970d74b8e8a4ad6b00f451753a17ade","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        uri \u003d \u0027/ports\u0027"},{"line_number":48,"context_line":"        return self.create_resource(uri, kwargs)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            self.show_port(id)"},{"line_number":53,"context_line":"        except lib_exc.NotFound:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_afae522b","line":50,"in_reply_to":"9a061dce_74ad2f9a","updated":"2016-04-07 16:18:35.000000000","message":"Ideally, yes.\n\nHowever, this way is implemented in most clients at this time.\nAnd the base rest_client has implemented base waiter method which uses this method of each client.","commit_id":"43e7fcff6f42e6ce81d87f7656424698103595d8"}],"tempest/scenario/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                    raise"},{"line_number":797,"context_line":"        self.assertIsNotNone(result, \u0027Unable to allocate tenant network\u0027)"},{"line_number":798,"context_line":"        subnet \u003d net_resources.DeletableSubnet("},{"line_number":799,"context_line":"            network_client\u003dclient, subnets_client\u003dsubnets_client,"},{"line_number":800,"context_line":"            routers_client\u003drouters_client, **result[\u0027subnet\u0027])"},{"line_number":801,"context_line":"        self.assertEqual(subnet.cidr, str_cidr)"},{"line_number":802,"context_line":"        self.addCleanup(self.delete_wrapper, subnet.delete)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_a2d252d0","side":"PARENT","line":799,"range":{"start_line":799,"start_character":12,"end_line":799,"end_character":34},"updated":"2016-04-06 06:48:26.000000000","message":"This should be removed","commit_id":"eda607cb1c89762a54290c4525d81c1b192c421f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            *args, **kwargs)"},{"line_number":735,"context_line":"        return agents_list[\u0027agents\u0027]"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def _create_subnet(self, network, client\u003dNone, subnets_client\u003dNone,"},{"line_number":738,"context_line":"                       routers_client\u003dNone, namestart\u003d\u0027subnet-smoke\u0027,"},{"line_number":739,"context_line":"                       **kwargs):"},{"line_number":740,"context_line":"        \"\"\"Create a subnet for the given network"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_02e21e9f","line":737,"range":{"start_line":737,"start_character":38,"end_line":737,"end_character":49},"updated":"2016-04-06 06:48:26.000000000","message":"This can be removed.","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"        router.update(admin_state_up\u003dadmin_state_up)"},{"line_number":1165,"context_line":"        self.assertEqual(admin_state_up, router.admin_state_up)"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"    def create_networks(self, client\u003dNone, networks_client\u003dNone,"},{"line_number":1168,"context_line":"                        routers_client\u003dNone, subnets_client\u003dNone,"},{"line_number":1169,"context_line":"                        tenant_id\u003dNone, dns_nameservers\u003dNone):"},{"line_number":1170,"context_line":"        \"\"\"Create a network with a subnet connected to a router."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_f6688b89","line":1167,"range":{"start_line":1167,"start_character":30,"end_line":1167,"end_character":42},"updated":"2016-04-06 06:48:26.000000000","message":"ditto","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3b8203a16d265d08141b141b28a5e2b8e597635","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"            router \u003d self._get_router(client\u003drouters_client,"},{"line_number":1198,"context_line":"                                      tenant_id\u003dtenant_id)"},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"            subnet_kwargs \u003d dict(network\u003dnetwork, client\u003dclient,"},{"line_number":1201,"context_line":"                                 subnets_client\u003dsubnets_client,"},{"line_number":1202,"context_line":"                                 routers_client\u003drouters_client)"},{"line_number":1203,"context_line":"            # use explicit check because empty list is a valid option"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_16e9bf14","line":1200,"range":{"start_line":1200,"start_character":50,"end_line":1200,"end_character":63},"updated":"2016-04-06 06:48:26.000000000","message":"we can remove this too","commit_id":"95ce7f64b44af8a645988bd0b547c04158b4a355"}]}