)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9227e10aecf1eb0ff44e49afe344c75eacc0eaab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Scenario - backup and attach restored encrypted volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added to scenario manager:"},{"line_number":10,"context_line":"- backup client to scenario manager"},{"line_number":11,"context_line":"- Added backup creare and restore"},{"line_number":12,"context_line":"- Changed nova attach to accept server and volume id directly"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_6959a68e","line":10,"updated":"2016-05-24 13:27:23.000000000","message":"The manager should contain code that will be reused in many tests. As of now the backup volume code is only used in one test so no need to put it in a common place. Just put that inside your test case.","commit_id":"165c74d722a79e3e4f67624cdb8c358558a7dc24"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"a0b7fdfb38c579bce38ff846c1e84e7e8de833ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Scenario - backup and attach restored encrypted volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added to scenario manager:"},{"line_number":10,"context_line":"- backup client to scenario manager"},{"line_number":11,"context_line":"- Added backup creare and restore"},{"line_number":12,"context_line":"- Changed nova attach to accept server and volume id directly"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_b86c7237","line":10,"in_reply_to":"bab6814e_6959a68e","updated":"2016-05-24 14:36:06.000000000","message":"Hi Jordon , \nIts a shared library , maybe new scenario test will use it in the future.","commit_id":"165c74d722a79e3e4f67624cdb8c358558a7dc24"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9227e10aecf1eb0ff44e49afe344c75eacc0eaab","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added to scenario manager:"},{"line_number":10,"context_line":"- backup client to scenario manager"},{"line_number":11,"context_line":"- Added backup creare and restore"},{"line_number":12,"context_line":"- Changed nova attach to accept server and volume id directly"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Added a test:"},{"line_number":15,"context_line":"backup encrypted volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_6934064a","line":12,"updated":"2016-05-24 13:27:23.000000000","message":"Why ?","commit_id":"165c74d722a79e3e4f67624cdb8c358558a7dc24"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"a0b7fdfb38c579bce38ff846c1e84e7e8de833ca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added to scenario manager:"},{"line_number":10,"context_line":"- backup client to scenario manager"},{"line_number":11,"context_line":"- Added backup creare and restore"},{"line_number":12,"context_line":"- Changed nova attach to accept server and volume id directly"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Added a test:"},{"line_number":15,"context_line":"backup encrypted volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_b8e63214","line":12,"in_reply_to":"bab6814e_6934064a","updated":"2016-05-24 14:36:06.000000000","message":"Hi Jordan,\nThe nova_attach_detach accpeted instances of server and assumed that \u0027id\u0027 is used for it .\nthe problem was that backup_restore returned a volume  but with a different key type , in order to get the volume id we should have to run : restore[\u0027volume_id\u0027]\n\nChanging the method to stings will allow us to pass id for server and volume ,\nWe would not be limited to a instance only , but others can use it.\n\nWhen we use backup resote we got back a different table ,\nrestore \u003d self.backup_restore(backup[\u0027id\u0027])\n        self.attach_detach_volume(server[\u0027id\u0027], restore[\u0027volume_id\u0027])\n  restore \u003d self.backup_restore(backup[\u0027id\u0027])\n\n\nWhy we should pass an instance when we dont not use it inside ... ?\n\nBenny","commit_id":"165c74d722a79e3e4f67624cdb8c358558a7dc24"}],"tempest/scenario/manager.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9f79e09d6b655b39bd46455fdb7e733d2c98d55f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":292,"context_line":"        return volume"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def backup_create(self, volume_id, name\u003dNone, container\u003dNone,"},{"line_number":295,"context_line":"                      description\u003dNone, incremental\u003dFalse, force\u003dFalse):"},{"line_number":296,"context_line":"        if not name:"},{"line_number":297,"context_line":"            rand_name \u003d data_utils.rand_name(\u0027scenario-type-backup\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_316768b8","line":294,"updated":"2016-06-01 10:52:27.000000000","message":"The manager should contain code that will be reused in many tests. As of now the backup volume code is only used in one test so no need to put it in a common place. Just put that inside your test case.\n\nIf in the future, if another test will need this, then we can move that common code in a common place. For now this manager.py is already huge, it shouldn\"t grow anymore.","commit_id":"bc062ca305ade4dd46806ce9f837db59b99f6feb"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9f79e09d6b655b39bd46455fdb7e733d2c98d55f","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _delete_backup(self, backup_id):"},{"line_number":320,"context_line":"        self.backups_client.delete_backup(backup_id)"},{"line_number":321,"context_line":"        self.backups_client.wait_for_backup_deletion(backup_id)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_restored_volume(self, volume_id):"},{"line_number":324,"context_line":"        self.volumes_client.delete_volume(volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_31fe48ae","line":321,"updated":"2016-06-01 10:52:27.000000000","message":"Why do you call wait_for_backup_deletion here ? Is it really necessary, would the test fail without that line ?","commit_id":"bc062ca305ade4dd46806ce9f837db59b99f6feb"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0719c1a702942a46cf69ba6bf3ae322d4939aafc","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _delete_backup(self, backup_id):"},{"line_number":320,"context_line":"        self.backups_client.delete_backup(backup_id)"},{"line_number":321,"context_line":"        self.backups_client.wait_for_backup_deletion(backup_id)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_restored_volume(self, volume_id):"},{"line_number":324,"context_line":"        self.volumes_client.delete_volume(volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_9c0f2d36","line":321,"in_reply_to":"9abb7d3a_31fe48ae","updated":"2016-06-01 18:21:56.000000000","message":"You are right ! , i removed the waiter and it works !","commit_id":"bc062ca305ade4dd46806ce9f837db59b99f6feb"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9f79e09d6b655b39bd46455fdb7e733d2c98d55f","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_restored_volume(self, volume_id):"},{"line_number":324,"context_line":"        self.volumes_client.delete_volume(volume_id)"},{"line_number":325,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume_id)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _create_loginable_secgroup_rule(self, secgroup_id\u003dNone):"},{"line_number":328,"context_line":"        _client \u003d self.compute_security_groups_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_b1287834","line":325,"updated":"2016-06-01 10:52:27.000000000","message":"Why do you call wait_for_resource_deletion here ? Is it really necessary, would the test fail without that line ?","commit_id":"bc062ca305ade4dd46806ce9f837db59b99f6feb"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"0719c1a702942a46cf69ba6bf3ae322d4939aafc","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_restored_volume(self, volume_id):"},{"line_number":324,"context_line":"        self.volumes_client.delete_volume(volume_id)"},{"line_number":325,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume_id)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _create_loginable_secgroup_rule(self, secgroup_id\u003dNone):"},{"line_number":328,"context_line":"        _client \u003d self.compute_security_groups_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_dc053514","line":325,"in_reply_to":"9abb7d3a_b1287834","updated":"2016-06-01 18:21:56.000000000","message":"You are right ! , i removed the waiter and it works !","commit_id":"bc062ca305ade4dd46806ce9f837db59b99f6feb"}],"tempest/scenario/test_encrypted_cinder_volumes.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9227e10aecf1eb0ff44e49afe344c75eacc0eaab","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @test.idempotent_id(\u002745ff3235-0319-4030-bca6-b67198339e93\u0027)"},{"line_number":87,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":88,"context_line":"    def test_backup_attach_encrypted_cinder_volumes_cryptsetup(self):"},{"line_number":89,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":90,"context_line":"            raise self.skipException(\"Cinder volume backups are disabled\")"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        server \u003d self.launch_instance()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_c9e1b29c","line":89,"updated":"2016-05-24 13:27:23.000000000","message":"Use the skipUnless decorator.","commit_id":"165c74d722a79e3e4f67624cdb8c358558a7dc24"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"a0b7fdfb38c579bce38ff846c1e84e7e8de833ca","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @test.idempotent_id(\u002745ff3235-0319-4030-bca6-b67198339e93\u0027)"},{"line_number":87,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":88,"context_line":"    def test_backup_attach_encrypted_cinder_volumes_cryptsetup(self):"},{"line_number":89,"context_line":"        if not CONF.volume_feature_enabled.backup:"},{"line_number":90,"context_line":"            raise self.skipException(\"Cinder volume backups are disabled\")"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        server \u003d self.launch_instance()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_1e13e75d","line":89,"in_reply_to":"bab6814e_c9e1b29c","updated":"2016-05-24 14:36:06.000000000","message":"ok will be fixed . lets agree on the main issues :)\nBenny","commit_id":"165c74d722a79e3e4f67624cdb8c358558a7dc24"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"294305bacf496ebc5bca749401f602ff9a7a03d2","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.backup,"},{"line_number":87,"context_line":"                          \u0027cinder backup is disabled.\u0027)"},{"line_number":88,"context_line":"    @skip_because(bug\u003d\u00271567263\u0027)"},{"line_number":89,"context_line":"    @test.idempotent_id(\u002745ff3235-0319-4030-bca6-b67198339e93\u0027)"},{"line_number":90,"context_line":"    @test.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":91,"context_line":"    def test_backup_attach_encrypted_cinder_volumes_cryptsetup(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_a5c3ec36","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":32},"updated":"2016-06-01 22:37:05.000000000","message":"A new skipped test can not be merged as the guideline:\n\nHACKING.rst:\n Guidelines\n ----------\n - Do not submit changesets with only testcases which are skipped as\n   they will not be merged.","commit_id":"beff381d913e32ac05afd772c1542b7539eb308d"}]}