)]}'
{"tempest/api/volume/test_volumes_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"226e8fb5c4b066fd48254464cf056b38acb28b0e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            disk_format\u003dCONF.volume.disk_format)[\u0027os-volume_upload_image\u0027]"},{"line_number":125,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":126,"context_line":"        self.addCleanup(self._cleanup_image, image_id)"},{"line_number":127,"context_line":"        self.image_client.wait_for_image_status(image_id, \u0027active\u0027)"},{"line_number":128,"context_line":"        waiters.wait_for_volume_status(self.client,"},{"line_number":129,"context_line":"                                       self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_0a446772","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":67},"updated":"2016-04-12 02:52:57.000000000","message":"If image is not created then it should thrown error at this place (Image not found) also.\n\nand we get the traceback of this call too.","commit_id":"68c3cb05f693708922258f7abb3a3365b867b1b7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6d0cf5f8315e0797ec3a09e5ebdb6f02a89a4645","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        waiters.wait_for_volume_status(self.client,"},{"line_number":129,"context_line":"                                       self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _cleanup_image(self, image_id):"},{"line_number":132,"context_line":"        # Ignores the image deletion"},{"line_number":133,"context_line":"        # in the case that image wasn\u0027t created in the first place"},{"line_number":134,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_3eca4d50","line":131,"updated":"2016-04-11 23:10:59.000000000","message":"There is a similar code on https://github.com/openstack/tempest/blob/master/tempest/api/image/base.py#L48\n\nBut this is *volume* API test, not *image* API test.\nIt is fine to avoid using image base code. In the future, it would be nice to do some cleanup for this kind of pattern.","commit_id":"68c3cb05f693708922258f7abb3a3365b867b1b7"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"dc5330f25668f0810c47f6eac6abf9a02d760fdb","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        waiters.wait_for_volume_status(self.client,"},{"line_number":129,"context_line":"                                       self.volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _cleanup_image(self, image_id):"},{"line_number":132,"context_line":"        # Ignores the image deletion"},{"line_number":133,"context_line":"        # in the case that image wasn\u0027t created in the first place"},{"line_number":134,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_a2423766","line":131,"in_reply_to":"5a18252c_3eca4d50","updated":"2016-04-14 08:51:29.000000000","message":"I have it here: https://review.openstack.org/#/c/277907/","commit_id":"68c3cb05f693708922258f7abb3a3365b867b1b7"}]}