)]}'
{"tempest/lib/api_schema/response/compute/v2_1/parameter_types.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7e133220dda144fb944bb71111b4a5fad41d7e8f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \u0027x-compute-request-id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":100,"context_line":"    \u0027vary\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":101,"context_line":"    \u0027x-openstack-nova-api-version\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":102,"context_line":"    # NOTE(gmann): Validating this as string only as this"},{"line_number":103,"context_line":"    # date in header is returned in different format than"},{"line_number":104,"context_line":"    # ISO 8601 date time format which is not consistent with"},{"line_number":105,"context_line":"    # other date-time format in nova."},{"line_number":106,"context_line":"    # This API is already deprecated so not worth to fix"},{"line_number":107,"context_line":"    # on nova side."},{"line_number":108,"context_line":"    \u0027date\u0027: {"},{"line_number":109,"context_line":"        \u0027type\u0027: \u0027string\u0027"},{"line_number":110,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_1841180c","line":107,"range":{"start_line":102,"start_character":3,"end_line":107,"end_character":19},"updated":"2016-08-03 21:23:27.000000000","message":"Humm, I am a little against this relaxing..\nI can understand it is not worth to change the \"date\" on Nova side, but this seem just relaxing on the validation and it would be possible to change it to different format data after doing this.\nHow don\u0027t we separate this original \u0027data-time\u0027 from a new format?","commit_id":"19c65eb744cac4c54018e98312c6f1a4df9d27ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9c6a1459fe78b1cb5ef1648fabe220410efaa2a5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    \u0027x-compute-request-id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":100,"context_line":"    \u0027vary\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":101,"context_line":"    \u0027x-openstack-nova-api-version\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":102,"context_line":"    # NOTE(gmann): Validating this as string only as this"},{"line_number":103,"context_line":"    # date in header is returned in different format than"},{"line_number":104,"context_line":"    # ISO 8601 date time format which is not consistent with"},{"line_number":105,"context_line":"    # other date-time format in nova."},{"line_number":106,"context_line":"    # This API is already deprecated so not worth to fix"},{"line_number":107,"context_line":"    # on nova side."},{"line_number":108,"context_line":"    \u0027date\u0027: {"},{"line_number":109,"context_line":"        \u0027type\u0027: \u0027string\u0027"},{"line_number":110,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_2ef1a3cd","line":107,"range":{"start_line":102,"start_character":3,"end_line":107,"end_character":19},"in_reply_to":"bacf61ea_1841180c","updated":"2017-01-31 07:41:53.000000000","message":"actually \u0027data-time\u0027 never worked and it just return true from validation. there is typo is that it was \u0027data-time\u0027 no \u0027date-time\u0027","commit_id":"19c65eb744cac4c54018e98312c6f1a4df9d27ad"}],"tempest/lib/common/jsonschema_validator.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8bcb32cb6b75d1454d41f7b16bbd227320e71256","unresolved":false,"context_lines":[{"line_number":21,"context_line":"FORMAT_CHECKER \u003d jsonschema.draft4_format_checker"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE(gmann): Add custome format checker for \u0027date-time\u0027 format because:"},{"line_number":25,"context_line":"# 1. jsonschema needs strict_rfc3339 or isodate module to be installed"},{"line_number":26,"context_line":"#    for proper date-time checking as per rfc3339."},{"line_number":27,"context_line":"# 2. Nova or other OpenStack components handle the date time format as"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b873e5e6","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":26},"updated":"2016-08-03 00:19:46.000000000","message":"nit: custom or customized","commit_id":"bdc3190290adf47dbf49b926036660f5d788df76"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2306b402d26a446dcb5db64ebabf096afbc7ad24","unresolved":false,"context_lines":[{"line_number":21,"context_line":"FORMAT_CHECKER \u003d jsonschema.draft4_format_checker"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# NOTE(gmann): Add custome format checker for \u0027date-time\u0027 format because:"},{"line_number":25,"context_line":"# 1. jsonschema needs strict_rfc3339 or isodate module to be installed"},{"line_number":26,"context_line":"#    for proper date-time checking as per rfc3339."},{"line_number":27,"context_line":"# 2. Nova or other OpenStack components handle the date time format as"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_7387ced7","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":26},"in_reply_to":"bacf61ea_b873e5e6","updated":"2016-08-03 00:40:57.000000000","message":"Done.","commit_id":"bdc3190290adf47dbf49b926036660f5d788df76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8bcb32cb6b75d1454d41f7b16bbd227320e71256","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@FORMAT_CHECKER.checks(\u0027date-time-null\u0027)"},{"line_number":42,"context_line":"def _validate_datetime_or_null_format(instance):"},{"line_number":43,"context_line":"    if instance is None:"},{"line_number":44,"context_line":"        return True"},{"line_number":45,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_d3715a79","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":37},"updated":"2016-08-03 00:19:46.000000000","message":"I guess the format checker works only for string values, and it is not necessary to implement this.","commit_id":"bdc3190290adf47dbf49b926036660f5d788df76"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2306b402d26a446dcb5db64ebabf096afbc7ad24","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@FORMAT_CHECKER.checks(\u0027date-time-null\u0027)"},{"line_number":42,"context_line":"def _validate_datetime_or_null_format(instance):"},{"line_number":43,"context_line":"    if instance is None:"},{"line_number":44,"context_line":"        return True"},{"line_number":45,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_33cb9620","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":37},"in_reply_to":"bacf61ea_d3715a79","updated":"2016-08-03 00:40:57.000000000","message":"actually here we need to support \u0027None\u0027 also as for update_at etc initial it will be \u0027None\u0027 and \u0027None\u0027 can not be validated against string.","commit_id":"bdc3190290adf47dbf49b926036660f5d788df76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7e133220dda144fb944bb71111b4a5fad41d7e8f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#    ISO 8601 which is defined in oslo_utils.timeutils"},{"line_number":29,"context_line":"# so this checker will validate the date-time as defined in"},{"line_number":30,"context_line":"# oslo_utils.timeutils"},{"line_number":31,"context_line":"@FORMAT_CHECKER.checks(\u0027date-time\u0027)"},{"line_number":32,"context_line":"def _validate_datetime_format(instance):"},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        if isinstance(instance, jsonschema.compat.str_types):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_f811a405","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":33},"updated":"2016-08-03 21:23:27.000000000","message":"Related to the other comment, can we define this as \"iso8601-date-time\" or something?","commit_id":"19c65eb744cac4c54018e98312c6f1a4df9d27ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9c6a1459fe78b1cb5ef1648fabe220410efaa2a5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#    ISO 8601 which is defined in oslo_utils.timeutils"},{"line_number":29,"context_line":"# so this checker will validate the date-time as defined in"},{"line_number":30,"context_line":"# oslo_utils.timeutils"},{"line_number":31,"context_line":"@FORMAT_CHECKER.checks(\u0027date-time\u0027)"},{"line_number":32,"context_line":"def _validate_datetime_format(instance):"},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        if isinstance(instance, jsonschema.compat.str_types):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_ceb65ff8","line":31,"range":{"start_line":31,"start_character":24,"end_line":31,"end_character":33},"in_reply_to":"bacf61ea_f811a405","updated":"2017-01-31 07:41:53.000000000","message":"ok.","commit_id":"19c65eb744cac4c54018e98312c6f1a4df9d27ad"}]}