)]}'
{"tempest/api/volume/admin/test_volume_pools.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4878bd57ec1b4997f4cb106bc36739ba0a46c9a5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @test.idempotent_id(\u00270248a46c-e226-4933-be10-ad6fca8227e7\u0027)"},{"line_number":29,"context_line":"    def test_get_pools_without_details(self):"},{"line_number":30,"context_line":"        volume_info \u003d self.admin_volume_client.\\"},{"line_number":31,"context_line":"            list_volumes(detail\u003dTrue, params\u003d{\u0027all_tenants\u0027: 1})[\u0027volumes\u0027]"},{"line_number":32,"context_line":"        vol \u003d [vol for vol in volume_info if vol[\u0027id\u0027] \u003d\u003d self.volume[\u0027id\u0027]]"},{"line_number":33,"context_line":"        self.assertEqual(len(vol), 1)"},{"line_number":34,"context_line":"        cinder_pools \u003d self.admin_volume_client.show_pools()[\u0027pools\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_82cf3f28","line":31,"updated":"2016-04-19 14:17:49.000000000","message":"Why do you need \"all_tenants: 1\" here ?","commit_id":"a9c7a9c540cb5accd911c4a1113db57b7ab8b10f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4878bd57ec1b4997f4cb106bc36739ba0a46c9a5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_get_pools_without_details(self):"},{"line_number":30,"context_line":"        volume_info \u003d self.admin_volume_client.\\"},{"line_number":31,"context_line":"            list_volumes(detail\u003dTrue, params\u003d{\u0027all_tenants\u0027: 1})[\u0027volumes\u0027]"},{"line_number":32,"context_line":"        vol \u003d [vol for vol in volume_info if vol[\u0027id\u0027] \u003d\u003d self.volume[\u0027id\u0027]]"},{"line_number":33,"context_line":"        self.assertEqual(len(vol), 1)"},{"line_number":34,"context_line":"        cinder_pools \u003d self.admin_volume_client.show_pools()[\u0027pools\u0027]"},{"line_number":35,"context_line":"        self.assertIn(vol[0][\u0027os-vol-host-attr:host\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_22510b37","line":32,"updated":"2016-04-19 14:17:49.000000000","message":"I suggest\n  vol \u003d self.admin_volume_client.show_volume(self.volume[\u0027id\u0027])","commit_id":"a9c7a9c540cb5accd911c4a1113db57b7ab8b10f"},{"author":{"_account_id":19587,"name":"Joshua White","email":"joshua.l.white@intel.com","username":"jwhite"},"change_message_id":"5605eede3e9bfae0d8bd17c7d9879411eaa2747e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        # Create a test shared volume for tests"},{"line_number":26,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @test.idempotent_id(\u00270248a46c-e226-4933-be10-ad6fca8227e7\u0027)"},{"line_number":29,"context_line":"    def test_get_pools_without_details(self):"},{"line_number":30,"context_line":"        volume_info \u003d self.admin_volume_client. \\"},{"line_number":31,"context_line":"            show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_9bb7a1f4","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":63},"updated":"2016-04-19 16:28:03.000000000","message":"The test id is not unique.  It is the same for both test.  Shouldn\u0027t this be different?","commit_id":"1c007b763977c715f5a06d0998dae201003441e6"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"64fbb75da34a1b65545b4970544b2bebadd7af30","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        # Create a test shared volume for tests"},{"line_number":26,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @test.idempotent_id(\u00270248a46c-e226-4933-be10-ad6fca8227e7\u0027)"},{"line_number":29,"context_line":"    def test_get_pools_without_details(self):"},{"line_number":30,"context_line":"        volume_info \u003d self.admin_volume_client. \\"},{"line_number":31,"context_line":"            show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_9e478f76","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":63},"in_reply_to":"1a122d0e_9bb7a1f4","updated":"2016-04-19 17:41:58.000000000","message":"Great catch :)","commit_id":"1c007b763977c715f5a06d0998dae201003441e6"},{"author":{"_account_id":19587,"name":"Joshua White","email":"joshua.l.white@intel.com","username":"jwhite"},"change_message_id":"5605eede3e9bfae0d8bd17c7d9879411eaa2747e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.assertIn(volume_info[\u0027os-vol-host-attr:host\u0027],"},{"line_number":34,"context_line":"                      [pool[\u0027name\u0027] for pool in cinder_pools])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.idempotent_id(\u00270248a46c-e226-4933-be10-ad6fca8227e7\u0027)"},{"line_number":37,"context_line":"    def test_get_pools_with_details(self):"},{"line_number":38,"context_line":"        volume_info \u003d self.admin_volume_client. \\"},{"line_number":39,"context_line":"            show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_5ba8698d","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":63},"updated":"2016-04-19 16:28:03.000000000","message":"See above","commit_id":"1c007b763977c715f5a06d0998dae201003441e6"}],"tempest/services/volume/base/base_volumes_client.py":[{"author":{"_account_id":19587,"name":"Joshua White","email":"joshua.l.white@intel.com","username":"jwhite"},"change_message_id":"5605eede3e9bfae0d8bd17c7d9879411eaa2747e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def show_pools(self, detail\u003dFalse):"},{"line_number":66,"context_line":"        # List all the volumes pools (hosts)"},{"line_number":67,"context_line":"        url \u003d \u0027scheduler-stats/get_pools\u0027"},{"line_number":68,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_9e230fa7","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":18},"updated":"2016-04-19 16:28:03.000000000","message":"Create unit test for show_pools","commit_id":"1c007b763977c715f5a06d0998dae201003441e6"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"64fbb75da34a1b65545b4970544b2bebadd7af30","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def show_pools(self, detail\u003dFalse):"},{"line_number":66,"context_line":"        # List all the volumes pools (hosts)"},{"line_number":67,"context_line":"        url \u003d \u0027scheduler-stats/get_pools\u0027"},{"line_number":68,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2f2e07a5","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":18},"in_reply_to":"1a122d0e_9e230fa7","updated":"2016-04-19 17:41:58.000000000","message":"Sure , where ? send me the path to add it\nThanks, \nBenny","commit_id":"1c007b763977c715f5a06d0998dae201003441e6"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"c1a3cd09d88abab7379c6cf55aca2b1088760cb0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def show_pools(self, detail\u003dFalse):"},{"line_number":66,"context_line":"        # List all the volumes pools (hosts)"},{"line_number":67,"context_line":"        url \u003d \u0027scheduler-stats/get_pools\u0027"},{"line_number":68,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_0875fc62","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":18},"updated":"2016-04-19 21:00:35.000000000","message":"Agree with Josua comment. imo this method should be added as well on the tempest lib at tempest.lib.services.compute.volumes_client.py","commit_id":"d946128ed899b14f42555ab47fcfa7f25a55c223"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"90e2ee5aa1d7600f414fb63b682f2270b854d8b1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def show_pools(self, detail\u003dFalse):"},{"line_number":66,"context_line":"        # List all the volumes pools (hosts)"},{"line_number":67,"context_line":"        url \u003d \u0027scheduler-stats/get_pools\u0027"},{"line_number":68,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b0b705d7","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":18},"in_reply_to":"1a122d0e_0875fc62","updated":"2016-04-20 02:25:16.000000000","message":"Hi ,\nCould you explain why we have a volume api clients  under compute section ? same question for glance ?\nThere are 3 folders: compute /identity / network\nWhy ? why we dont have cinder / glance ?\n\nI prefer to keep the code as is till we understand.\nBenny","commit_id":"d946128ed899b14f42555ab47fcfa7f25a55c223"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7c32b7a14d0a67d516b495821223707a787a345a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def show_pools(self, detail\u003dFalse):"},{"line_number":66,"context_line":"        # List all the volumes pools (hosts)"},{"line_number":67,"context_line":"        url \u003d \u0027scheduler-stats/get_pools\u0027"},{"line_number":68,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4a3a8c35","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":18},"in_reply_to":"1a122d0e_3fcd79b7","updated":"2016-04-23 17:17:49.000000000","message":"This is the correct place for this method. This file is where all interaction with Cinder is done. Nova/compute is not involved here.","commit_id":"d946128ed899b14f42555ab47fcfa7f25a55c223"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"14b918e5c13eb36e8491d5d60df35d5583036645","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":63,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def show_pools(self, detail\u003dFalse):"},{"line_number":66,"context_line":"        # List all the volumes pools (hosts)"},{"line_number":67,"context_line":"        url \u003d \u0027scheduler-stats/get_pools\u0027"},{"line_number":68,"context_line":"        if detail:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_3fcd79b7","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":18},"in_reply_to":"1a122d0e_b0b705d7","updated":"2016-04-20 07:38:49.000000000","message":"Please double check ... under compute we have the method used by nova to cinder .  \nas i know nova wont query get_pools .\nIn case you argree, please remove your -1 , please\nBenny","commit_id":"d946128ed899b14f42555ab47fcfa7f25a55c223"}]}