)]}'
{"etc/tempest.conf.sample":[{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"961fef71ae157a50d174ebc44a4f83627e99db30","unresolved":false,"context_lines":[{"line_number":220,"context_line":"# Number of seconds to time out on waiting for a volume"},{"line_number":221,"context_line":"# to be available or reach an expected status"},{"line_number":222,"context_line":"build_timeout \u003d 300"},{"line_number":223,"context_line":"# Runs Cinder multi-backend tests (requires 2 backend declared in cinder.conf)"},{"line_number":224,"context_line":"# They must have different volume_backend_name (backend1_name and backend2_name"},{"line_number":225,"context_line":"# have to be different)"},{"line_number":226,"context_line":"multi_backend_enabled \u003d false"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPH%2F%2FmIg%3D","line":223,"updated":"2013-05-29 17:25:42.000000000","message":"\"requires 2 backend\" will probably take an \"s\" here too.","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f724e19cfebcd5e78788889af6a839f01b4400b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"# Number of seconds to time out on waiting for a volume"},{"line_number":221,"context_line":"# to be available or reach an expected status"},{"line_number":222,"context_line":"build_timeout \u003d 300"},{"line_number":223,"context_line":"# Runs Cinder multi-backend tests (requires 2 backend declared in cinder.conf)"},{"line_number":224,"context_line":"# They must have different volume_backend_name (backend1_name and backend2_name"},{"line_number":225,"context_line":"# have to be different)"},{"line_number":226,"context_line":"multi_backend_enabled \u003d false"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPH%2F%2FkqM%3D","line":223,"in_reply_to":"AAAAPH%2F%2FmIg%3D","updated":"2013-05-30 08:41:09.000000000","message":"Done","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"}],"tempest/api/volume/admin/test_multi_backend.py":[{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"961fef71ae157a50d174ebc44a4f83627e99db30","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            cls.client.wait_for_resource_deletion(volume_id)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        ## volume types deletion"},{"line_number":100,"context_line":"        for volume_type in cls.volume_type_id_list:"},{"line_number":101,"context_line":"            cls.client2.delete_volume_type(volume_type)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        super(VolumeMultiBackendTest, cls).tearDownClass()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fnko%3D","line":100,"updated":"2013-05-29 17:25:42.000000000","message":"maybe \"volume_type\" can be moved to \"volume_type_id\"?","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f724e19cfebcd5e78788889af6a839f01b4400b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            cls.client.wait_for_resource_deletion(volume_id)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        ## volume types deletion"},{"line_number":100,"context_line":"        for volume_type in cls.volume_type_id_list:"},{"line_number":101,"context_line":"            cls.client2.delete_volume_type(volume_type)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        super(VolumeMultiBackendTest, cls).tearDownClass()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FkqA%3D","line":100,"in_reply_to":"AAAAPH%2F%2Fnko%3D","updated":"2013-05-30 08:41:09.000000000","message":"Done","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"961fef71ae157a50d174ebc44a4f83627e99db30","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.assertTrue(len(volume_host2.split(\"@\")) \u003e 1, msg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":130,"context_line":"    def test_backend_name_get(self):"},{"line_number":131,"context_line":"        # this test checks that the two volumes created at setUp doesn\u0027t"},{"line_number":132,"context_line":"        # belong to the same backend (if they are in the same backend, that"},{"line_number":133,"context_line":"        # means, volume_backend_name distinction is not working properly)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FmJE%3D","line":130,"updated":"2013-05-29 17:25:42.000000000","message":"I\u0027m not really sure about \"get\" here.\nIn fact this test does more than \"just\" check if it can get the backend name, it also checks that the names are different.","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f724e19cfebcd5e78788889af6a839f01b4400b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.assertTrue(len(volume_host2.split(\"@\")) \u003e 1, msg)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":130,"context_line":"    def test_backend_name_get(self):"},{"line_number":131,"context_line":"        # this test checks that the two volumes created at setUp doesn\u0027t"},{"line_number":132,"context_line":"        # belong to the same backend (if they are in the same backend, that"},{"line_number":133,"context_line":"        # means, volume_backend_name distinction is not working properly)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fkp8%3D","line":130,"in_reply_to":"AAAAPH%2F%2FmJE%3D","updated":"2013-05-30 08:41:09.000000000","message":"Done","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"961fef71ae157a50d174ebc44a4f83627e99db30","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        # belong to the same backend (if they are in the same backend, that"},{"line_number":133,"context_line":"        # means, volume_backend_name distinction is not working properly)"},{"line_number":134,"context_line":"        # this test fails if:"},{"line_number":135,"context_line":"        # - tempest.conf is not well configured"},{"line_number":136,"context_line":"        # - the two volumes belongs to the same backend"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if self.backend1_name \u003d\u003d self.backend2_name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fni0%3D","line":135,"updated":"2013-05-29 17:25:42.000000000","message":"skipException is considered as a failure?\nIf it\u0027s not the case, this comment has probably to be updated.","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"bd5d9b32fff5d0f53d1a263c9572b55d33a30b99","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        # belong to the same backend (if they are in the same backend, that"},{"line_number":133,"context_line":"        # means, volume_backend_name distinction is not working properly)"},{"line_number":134,"context_line":"        # this test fails if:"},{"line_number":135,"context_line":"        # - tempest.conf is not well configured"},{"line_number":136,"context_line":"        # - the two volumes belongs to the same backend"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if self.backend1_name \u003d\u003d self.backend2_name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FkjM%3D","line":135,"in_reply_to":"AAAAPH%2F%2FklI%3D","updated":"2013-05-30 09:53:08.000000000","message":"wow, thanks for pointing that out ... so we both seem to agree on the idea that we skip if misconfigured, but Sean suggested to enforce the check elsewhere, maybe we can bring this up during the meeting.","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"3785c7a3b3ee947d7ed4de5f0bcc20e155257c4c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        # belong to the same backend (if they are in the same backend, that"},{"line_number":133,"context_line":"        # means, volume_backend_name distinction is not working properly)"},{"line_number":134,"context_line":"        # this test fails if:"},{"line_number":135,"context_line":"        # - tempest.conf is not well configured"},{"line_number":136,"context_line":"        # - the two volumes belongs to the same backend"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if self.backend1_name \u003d\u003d self.backend2_name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FklI%3D","line":135,"in_reply_to":"AAAAPH%2F%2Fkps%3D","updated":"2013-05-30 09:21:38.000000000","message":"Thanks for the explanation.\nHowever, I remember a review from Sean ( https://review.openstack.org/#/c/23923/18/tempest/tests/volume/admin/test_multi_backend.py l124 ) who didn\u0027t have exactly the same point of view.\nSo, from my understanding, the question is, if something is badly configured in tempest.conf, does it have to be considered as a failure or a skipException ?","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f724e19cfebcd5e78788889af6a839f01b4400b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        # belong to the same backend (if they are in the same backend, that"},{"line_number":133,"context_line":"        # means, volume_backend_name distinction is not working properly)"},{"line_number":134,"context_line":"        # this test fails if:"},{"line_number":135,"context_line":"        # - tempest.conf is not well configured"},{"line_number":136,"context_line":"        # - the two volumes belongs to the same backend"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if self.backend1_name \u003d\u003d self.backend2_name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fkps%3D","line":135,"in_reply_to":"AAAAPH%2F%2Fni0%3D","updated":"2013-05-30 08:41:09.000000000","message":"indeed it is not, I think we should skip if tempest is wrongly configured and report a failure only if, given that everything is correctly set in place, the two volume_host? values are identical (as per last assert)","commit_id":"f88a60ed19f910372fdb59490f0809210fb39b63"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"bb579cb66032db00b52d10d81eb6df4be1a9aec7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FhIk%3D","line":3,"updated":"2013-05-31 13:04:30.000000000","message":"There is a consensus about removing the copyright lines?","commit_id":"b83f0635868d093bdd2e8dc680c5cf6b1009cc74"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9f36fb0bbaf07a2ebd58630e485520bba30a12d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FhCA%3D","line":3,"in_reply_to":"AAAAPH%2F%2FhIk%3D","updated":"2013-05-31 13:44:44.000000000","message":"AFAIK the main issue with the copyright notices, unless they are strip out from code completely, is to make sure that people contributing file them correctly. Legal seems to confirm that they can be removed safely so the route I\u0027m taking is to remove the copyright notice whenever I happen to edit a file but not to mass-remove them","commit_id":"b83f0635868d093bdd2e8dc680c5cf6b1009cc74"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"34e89d668aaf2b1a2e7614017cf932c375900894","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":109,"context_line":"    def test_backend_name_get(self):"},{"line_number":110,"context_line":"        # this test checks that multi backend is enabled for at least the"},{"line_number":111,"context_line":"        # computes where the volumes created in setUp were made"},{"line_number":112,"context_line":"        # if multi-backend is enabled: os-vol-attr:host should be like:"},{"line_number":113,"context_line":"        # host@backend_name"},{"line_number":114,"context_line":"        # this test fails if:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FhKQ%3D","line":111,"updated":"2013-05-31 12:58:22.000000000","message":"as now, only one volume is checked, the comment has probably to be updated:\n\" this test checks that multi backend is enabled for at least the compute where the volume created in setUp was made.\"","commit_id":"b83f0635868d093bdd2e8dc680c5cf6b1009cc74"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9f36fb0bbaf07a2ebd58630e485520bba30a12d4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":109,"context_line":"    def test_backend_name_get(self):"},{"line_number":110,"context_line":"        # this test checks that multi backend is enabled for at least the"},{"line_number":111,"context_line":"        # computes where the volumes created in setUp were made"},{"line_number":112,"context_line":"        # if multi-backend is enabled: os-vol-attr:host should be like:"},{"line_number":113,"context_line":"        # host@backend_name"},{"line_number":114,"context_line":"        # this test fails if:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FhB4%3D","line":111,"in_reply_to":"AAAAPH%2F%2FhKQ%3D","updated":"2013-05-31 13:44:44.000000000","message":"Done","commit_id":"b83f0635868d093bdd2e8dc680c5cf6b1009cc74"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"34e89d668aaf2b1a2e7614017cf932c375900894","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # if multi-backend is enabled: os-vol-attr:host should be like:"},{"line_number":113,"context_line":"        # host@backend_name"},{"line_number":114,"context_line":"        # this test fails if:"},{"line_number":115,"context_line":"        # - multi backend is not enabled"},{"line_number":116,"context_line":"        resp, fetched_volume \u003d self.client.get_volume(self.volume1[\u0027id\u0027])"},{"line_number":117,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FhJo%3D","line":115,"updated":"2013-05-31 12:58:22.000000000","message":"Maybe l114 and l115 can be removed.","commit_id":"b83f0635868d093bdd2e8dc680c5cf6b1009cc74"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9f36fb0bbaf07a2ebd58630e485520bba30a12d4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # if multi-backend is enabled: os-vol-attr:host should be like:"},{"line_number":113,"context_line":"        # host@backend_name"},{"line_number":114,"context_line":"        # this test fails if:"},{"line_number":115,"context_line":"        # - multi backend is not enabled"},{"line_number":116,"context_line":"        resp, fetched_volume \u003d self.client.get_volume(self.volume1[\u0027id\u0027])"},{"line_number":117,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FhB0%3D","line":115,"in_reply_to":"AAAAPH%2F%2FhJo%3D","updated":"2013-05-31 13:44:44.000000000","message":"Done","commit_id":"b83f0635868d093bdd2e8dc680c5cf6b1009cc74"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"34e89d668aaf2b1a2e7614017cf932c375900894","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @attr(type\u003d\u0027gate\u0027)"},{"line_number":125,"context_line":"    @testtools.skipIf(backends_have_same_name,"},{"line_number":126,"context_line":"                      \"Backends configured with same name\")"},{"line_number":127,"context_line":"    def test_backend_name_distinction(self):"},{"line_number":128,"context_line":"        # this test checks that the two volumes created at setUp don\u0027t"},{"line_number":129,"context_line":"        # belong to the same backend (if they are, than the"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FhJc%3D","line":126,"updated":"2013-05-31 12:58:22.000000000","message":"If a consensus was made with \"skipIf\", it\u0027s ok for me :-)","commit_id":"b83f0635868d093bdd2e8dc680c5cf6b1009cc74"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a126c0faade9887ffa22981eebc6955b63cfbf9b","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    @testtools.skipIf(not multi_backend_enabled,"},{"line_number":43,"context_line":"                      \"Cinder multi-backend feature is not available\")"},{"line_number":44,"context_line":"    def setUpClass(cls):"},{"line_number":45,"context_line":"        super(VolumeMultiBackendTest, cls).setUpClass()"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FgWg%3D","side":"PARENT","line":43,"updated":"2013-05-31 17:03:47.000000000","message":"I think the crux of the issue is thinking that multi_backend_enabled is coming from class scope. In this case, it\u0027s coming directly as a reference in the upper level, and because it evaluated early it\u0027s available to the decorator.","commit_id":"6e4156c220342a7fffbba149bc66524f826a68c3"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"adb398f707a843d641c52d8f5d177b98e5a0d36b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        backend1_name \u003d cls.config.volume.backend1_name"},{"line_number":39,"context_line":"        backend2_name \u003d cls.config.volume.backend2_name"},{"line_number":40,"context_line":"        if backend1_name \u003d\u003d backend2_name:"},{"line_number":41,"context_line":"            cls.backends_have_same_name \u003d True"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        adm_user \u003d cls.config.identity.admin_username"},{"line_number":44,"context_line":"        adm_pass \u003d cls.config.identity.admin_password"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fg60%3D","line":41,"updated":"2013-05-31 14:05:13.000000000","message":"I\u0027m not sure this is the place to do that. You probably have to do it directly on the class (l31). (perhaps the following link can help you? https://review.openstack.org/#/c/23923/18/tempest/tests/volume/admin/test_multi_backend.py )\n\nIn fact, in my configuration, the skipIf l123 is never executed (even if the config file is not well configured), that means, backends_have_same_name is always False.","commit_id":"1cef77836a09d43cb0d9e139295ce031069d14c6"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"9791037391212f7069e563868441c8ffe11c7881","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        adm_tenant \u003d cls.config.identity.admin_tenant_name"},{"line_number":40,"context_line":"        auth_url \u003d cls.config.identity.uri"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        cls.volume_client \u003d volumes_client.VolumesClientJSON(cls.config,"},{"line_number":43,"context_line":"                                                             adm_user,"},{"line_number":44,"context_line":"                                                             adm_pass,"},{"line_number":45,"context_line":"                                                             auth_url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2FdaM%3D","line":42,"updated":"2013-06-03 14:39:35.000000000","message":"You move cls.client to cls.volume_client which is more clear, thanks. However, perhaps I missed something, but there is some places in the code where it\u0027s not yet updated (for instance L93, 94, 98, 108, 124).","commit_id":"a088ac4dec753350f3af9f107c17e35159654e22"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"076d60925d9491ee03d494da93399fe327b983fb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        adm_tenant \u003d cls.config.identity.admin_tenant_name"},{"line_number":40,"context_line":"        auth_url \u003d cls.config.identity.uri"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        cls.volume_client \u003d volumes_client.VolumesClientJSON(cls.config,"},{"line_number":43,"context_line":"                                                             adm_user,"},{"line_number":44,"context_line":"                                                             adm_pass,"},{"line_number":45,"context_line":"                                                             auth_url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2FdXE%3D","line":42,"in_reply_to":"AAAAPH%2F%2FdaM%3D","updated":"2013-06-03 15:06:06.000000000","message":"Done","commit_id":"a088ac4dec753350f3af9f107c17e35159654e22"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"9791037391212f7069e563868441c8ffe11c7881","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                                             adm_pass,"},{"line_number":45,"context_line":"                                                             auth_url,"},{"line_number":46,"context_line":"                                                             adm_tenant)"},{"line_number":47,"context_line":"        cls.type_client \u003d volume_types_client.VolumeTypesClientJSON(cls.config,"},{"line_number":48,"context_line":"                                                                    adm_user,"},{"line_number":49,"context_line":"                                                                    adm_pass,"},{"line_number":50,"context_line":"                                                                    auth_url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2FdaE%3D","line":47,"updated":"2013-06-03 14:39:35.000000000","message":"same remark : client2 has been moved to type_client, however L98 for instance is not updated.","commit_id":"a088ac4dec753350f3af9f107c17e35159654e22"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"076d60925d9491ee03d494da93399fe327b983fb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                                             adm_pass,"},{"line_number":45,"context_line":"                                                             auth_url,"},{"line_number":46,"context_line":"                                                             adm_tenant)"},{"line_number":47,"context_line":"        cls.type_client \u003d volume_types_client.VolumeTypesClientJSON(cls.config,"},{"line_number":48,"context_line":"                                                                    adm_user,"},{"line_number":49,"context_line":"                                                                    adm_pass,"},{"line_number":50,"context_line":"                                                                    auth_url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2FdXI%3D","line":47,"in_reply_to":"AAAAPH%2F%2FdaE%3D","updated":"2013-06-03 15:06:06.000000000","message":"Done","commit_id":"a088ac4dec753350f3af9f107c17e35159654e22"},{"author":{"_account_id":6828,"name":"jerome-gallard","email":"jerome.david.gallard@gmail.com","username":"jerome-gallard"},"change_message_id":"9791037391212f7069e563868441c8ffe11c7881","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # this test checks that the two volumes created at setUp don\u0027t"},{"line_number":119,"context_line":"        # belong to the same backend (if they are, than the"},{"line_number":120,"context_line":"        # volume backend distinction is not working properly)"},{"line_number":121,"context_line":"        if self.backend1_name \u003d\u003d self.backend1_name:"},{"line_number":122,"context_line":"            raise self.skipException(\"backends configured with same name\")"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        resp, fetched_volume \u003d self.client.get_volume(self.volume1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2Fdc0%3D","line":121,"updated":"2013-06-03 14:39:35.000000000","message":"here, it should probably be:\nself.backend1_name \u003d\u003d self.backend2_name","commit_id":"a088ac4dec753350f3af9f107c17e35159654e22"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"076d60925d9491ee03d494da93399fe327b983fb","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # this test checks that the two volumes created at setUp don\u0027t"},{"line_number":119,"context_line":"        # belong to the same backend (if they are, than the"},{"line_number":120,"context_line":"        # volume backend distinction is not working properly)"},{"line_number":121,"context_line":"        if self.backend1_name \u003d\u003d self.backend1_name:"},{"line_number":122,"context_line":"            raise self.skipException(\"backends configured with same name\")"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        resp, fetched_volume \u003d self.client.get_volume(self.volume1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAPH%2F%2FdXM%3D","line":121,"in_reply_to":"AAAAPH%2F%2Fdc0%3D","updated":"2013-06-03 15:06:06.000000000","message":"Done","commit_id":"a088ac4dec753350f3af9f107c17e35159654e22"}]}