)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9c370e4e90808778ecaec05adc7bc2d54033be85","unresolved":false,"context_lines":[{"line_number":12,"context_line":"after volume transfer between two tenants."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifb54257ab4264e885d07eb5a7604a46a06a95ad4"},{"line_number":15,"context_line":"Depends-On: Ie0f2739fbb4ee32e04dda508d922d0015b1a92a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9abb7d3a_114a7bac","line":15,"updated":"2016-06-03 19:03:04.000000000","message":"This is not needed at all. Depends-On is only used for cross-repo dependencies. If the code is on the same project all you need to do is make a branch with both commits and the dependcy will be enforce with gerrit, see:\n\nhttp://docs.openstack.org/infra/manual/developers.html#adding-a-dependency","commit_id":"4d64fb342887fe2ef9cc7547052b8c0cf48befbf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"497689be8ec8f126a967e8c070fdb44e70cb7ce5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"after volume transfer between two tenants."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifb54257ab4264e885d07eb5a7604a46a06a95ad4"},{"line_number":15,"context_line":"Depends-On: Ie0f2739fbb4ee32e04dda508d922d0015b1a92a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7aa08908_bc2003f9","line":15,"in_reply_to":"9abb7d3a_114a7bac","updated":"2016-06-05 08:21:16.000000000","message":"Thanks for your comment,\nThere is not more dependency","commit_id":"4d64fb342887fe2ef9cc7547052b8c0cf48befbf"}],"tempest/api/volume/admin/test_volume_quotas.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"0ec993ebc1c6cb04a8e129840a0e12b6fd99b375","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        new_alt_quota \u003d self.quotas_client.show_quota_usage("},{"line_number":145,"context_line":"            self.alt_client.tenant_id)[\u0027quota_set\u0027][\u0027volumes\u0027][\u0027in_use\u0027]"},{"line_number":146,"context_line":"        # Verify the quota usage was updated"},{"line_number":147,"context_line":"        self.assertEqual(alt_quota + 1, new_alt_quota)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class VolumeQuotasAdminV1TestJSON(BaseVolumeQuotasAdminV2TestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d850d634","line":147,"updated":"2016-04-20 10:17:00.000000000","message":"This should be \n  alt_quota + volume[\u0027size\u0027]\n\nWe don\"t know for sure the volume size is 1G.","commit_id":"b175a3740978d5b64e2f94f1bfd46e8f77f438a1"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c7d71f019fdbc3e60fef8fd7f28e7c241a30b00d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        new_alt_quota \u003d self.quotas_client.show_quota_usage("},{"line_number":145,"context_line":"            self.alt_client.tenant_id)[\u0027quota_set\u0027][\u0027volumes\u0027][\u0027in_use\u0027]"},{"line_number":146,"context_line":"        # Verify the quota usage was updated"},{"line_number":147,"context_line":"        self.assertEqual(alt_quota + 1, new_alt_quota)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class VolumeQuotasAdminV1TestJSON(BaseVolumeQuotasAdminV2TestJSON):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_94cc62bc","line":147,"in_reply_to":"1a122d0e_d850d634","updated":"2016-04-20 12:26:30.000000000","message":"Thanks for your comment, it\u0027ll be fixed","commit_id":"b175a3740978d5b64e2f94f1bfd46e8f77f438a1"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"3243721afcc65887fabf9f2c2b9cba76ef80180b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        new_alt_quota \u003d self.quotas_client.show_quota_usage("},{"line_number":145,"context_line":"            self.alt_client.tenant_id)[\u0027quota_set\u0027]"},{"line_number":146,"context_line":"        # Verify the quota usage was updated"},{"line_number":147,"context_line":"        self.assertEqual(alt_quota[\u0027volumes\u0027][\u0027in_use\u0027] + 1,"},{"line_number":148,"context_line":"                         new_alt_quota[\u0027volumes\u0027][\u0027in_use\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.assertEqual(alt_quota[\u0027gigabytes\u0027][\u0027in_use\u0027] +"},{"line_number":151,"context_line":"                         volume[\u0027size\u0027],"},{"line_number":152,"context_line":"                         new_alt_quota[\u0027gigabytes\u0027][\u0027in_use\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"class VolumeQuotasAdminV1TestJSON(BaseVolumeQuotasAdminV2TestJSON):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_71b24f4d","line":152,"range":{"start_line":147,"start_character":8,"end_line":152,"end_character":62},"updated":"2016-04-21 02:42:50.000000000","message":"What about the primary tenant?","commit_id":"dd38edbe666168b0869e299ae939c12b955dfcb8"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"de4534b232ab3ce80faededa9e1971eeda5635b5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.addCleanup(self.admin_volume_client.delete_volume,"},{"line_number":128,"context_line":"                        volume[\u0027id\u0027])"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        tenants_ids \u003d [self.demo_tenant_id, self.alt_client.tenant_id]"},{"line_number":131,"context_line":"        # List of tenants quota usage pre-transfer"},{"line_number":132,"context_line":"        tenants_quota \u003d ["},{"line_number":133,"context_line":"            self.quotas_client.show_quota_usage(id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_d834db4b","line":130,"updated":"2016-04-22 11:52:18.000000000","message":"I am sorry but I find the usage of list here not necessary. First because you only have 2 items. Second because it makes the code harder to read: I must remember that index 0 is for alt tenant and 1 is for primary.\n\nPatchset 3 was better, you should use named variable: primary_quota, new_primary_quota, alt_quota, new_alt_quota.\n\nIt adds 2 or 3 lines of code, but it will be much clearer.\n\nAlso add some blank/empty lines to separate you code in logical blocks.","commit_id":"1b600fd77da66c1fa82fb41fae4d587b08099db8"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"5cba34c3c0523b8715e8c0009977df4013e97122","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            self.demo_tenant_id)[\u0027quota_set\u0027]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        volume \u003d self.create_volume()"},{"line_number":94,"context_line":"        self.addCleanup(self._delete_volume, volume[\u0027id\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        new_quota_usage \u003d self.quotas_client.show_quota_usage("},{"line_number":97,"context_line":"            self.demo_tenant_id)[\u0027quota_set\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_8dcaa74d","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":58},"updated":"2016-05-05 18:45:30.000000000","message":"Is it the cause of the 2 volumes in-use in the earlier patch? Anyway I think it belongs to a different patch.","commit_id":"bba0415c7288ebe8ef6e537ccc76655d1698943e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9c370e4e90808778ecaec05adc7bc2d54033be85","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Verify tenants quota usage was updated"},{"line_number":158,"context_line":"        self.assertEqual(primary_quota[\u0027volumes\u0027][\u0027in_use\u0027] -"},{"line_number":159,"context_line":"                         new_primary_quota[\u0027volumes\u0027][\u0027in_use\u0027],"},{"line_number":160,"context_line":"                         new_alt_quota[\u0027volumes\u0027][\u0027in_use\u0027] -"},{"line_number":161,"context_line":"                         alt_quota[\u0027volumes\u0027][\u0027in_use\u0027])"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_35d68a27","line":159,"updated":"2016-06-03 19:03:04.000000000","message":"There is a potential race condition in this test that we should protect against before we land it. test_quota_usage() doesn\u0027t wait on deleting the server it creates. This is running in the same tenant so if the delete is sluggish for whatever this could fail.\n\nWe should either fix the delete in test_quota_usage() or not rely on any checking of primary_quota here","commit_id":"4d64fb342887fe2ef9cc7547052b8c0cf48befbf"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"497689be8ec8f126a967e8c070fdb44e70cb7ce5","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # Verify tenants quota usage was updated"},{"line_number":158,"context_line":"        self.assertEqual(primary_quota[\u0027volumes\u0027][\u0027in_use\u0027] -"},{"line_number":159,"context_line":"                         new_primary_quota[\u0027volumes\u0027][\u0027in_use\u0027],"},{"line_number":160,"context_line":"                         new_alt_quota[\u0027volumes\u0027][\u0027in_use\u0027] -"},{"line_number":161,"context_line":"                         alt_quota[\u0027volumes\u0027][\u0027in_use\u0027])"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_1c1157ad","line":159,"in_reply_to":"9abb7d3a_35d68a27","updated":"2016-06-05 08:21:16.000000000","message":"I committed the following patch: https://review.openstack.org/#/c/313926/ that already merged to prevent a potential of race condition","commit_id":"4d64fb342887fe2ef9cc7547052b8c0cf48befbf"}]}